[8.x] [Security Solution] Fix incorrect default value for History Window Size (#207827)#208178
Merged
kibanamachine merged 1 commit intoelastic:8.xfrom Jan 24, 2025
Merged
Conversation
…ze (elastic#207827) **Resolves: elastic#207348 ## Summary This PR resolves a bug in the editable History Window Size component, which incorrectly displays "0 seconds" as the default value instead of "7 days". The issue was caused by passing an array of units `(['m', 'h', 'd'])` using an incorrect prop name. Also, I fixed stuck last digit being stuck when trying to remove it **Before my changes: can't remove or reset the last digit** https://github.com/user-attachments/assets/3a7d28ea-ea71-4ee8-8805-902bae1dc3c1 **After my changes: value resets to minValue on last digit removal** https://github.com/user-attachments/assets/1cba36bb-9127-4197-871e-62b978b3612c Work started on: 22-Jan-2025 (cherry picked from commit 8894c1f)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @nikitaindik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation