Skipping sample data test due to bug #20807#20809
Merged
liza-mae merged 1 commit intoelastic:masterfrom Jul 15, 2018
Merged
Conversation
liza-mae
added
test
v6.4.0
v7.0.0
:Sharing
Feature:Dashboard
Contributor
💔 Build Failed |
Contributor
Author
|
PR #20811 fixes the test issue, so no need to disable. Closing. |
Contributor
Author
|
Let me merge this now, in small case that someone needs it to pass a PR and it will be re-enabled as part of PR #20811 which fixes it, once that is merged. |
liza-mae
added a commit
to liza-mae/kibana
that referenced
this pull request
Jul 15, 2018
liza-mae
added a commit
that referenced
this pull request
Jul 15, 2018
Contributor
💚 Build Succeeded |
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure the proper procedure, but there is a kibana bug #20807 that is causing sample data test: 'should launch sample data set dashboard' to fail. It blocks PRs, so I thought we would skip it until #20807 unless that can be fixed quickly.