Skip to content

[Fleet] Fix connector links not visible in agentless flyout#208068

Merged
criamico merged 1 commit intoelastic:mainfrom
criamico:fix_connectors_link
Jan 23, 2025
Merged

[Fleet] Fix connector links not visible in agentless flyout#208068
criamico merged 1 commit intoelastic:mainfrom
criamico:fix_connectors_link

Conversation

@criamico
Copy link
Copy Markdown
Contributor

@criamico criamico commented Jan 23, 2025

Follow up of #203824

Summary

This is a small bugfix for connectors not visible in agentless flyout.

Testing

Screenshot 2025-01-23 at 15 28 20

@criamico criamico self-assigned this Jan 23, 2025
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0 backport:prev-minor labels Jan 23, 2025
@criamico criamico marked this pull request as ready for review January 23, 2025 14:49
@criamico criamico requested a review from a team as a code owner January 23, 2025 14:49
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@criamico criamico enabled auto-merge (squash) January 23, 2025 15:23
@criamico criamico merged commit 1b97e29 into elastic:main Jan 23, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12934378159

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #11 / ShowMoreButton calls onShowMoreClick on button click
  • [job] [logs] Jest Tests #11 / SyncAlertsSwitch it toggles the switch

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +13.0B

cc @criamico

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 23, 2025
…208068)

Follow up of elastic#203824

## Summary
This is a small bugfix for connectors not visible in agentless flyout.

## Testing

- Follow the steps here elastic#203824
- Install elastic-connectors integration
`app/fleet/integrations/elastic_connectors-1.0.0/add-integration` and
enroll an agent to it
- The enabled connectors should be visible in the flyout

<img width="870" alt="Screenshot 2025-01-23 at 15 28 20"
src="https://github.com/user-attachments/assets/19cdcbc4-68d5-4e44-875e-15cd849ab84b"
/>

(cherry picked from commit 1b97e29)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 23, 2025
…08068) (#208106)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Fix connector links not visible in agentless flyout
(#208068)](#208068)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cristina
Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-23T17:09:49Z","message":"[Fleet]
Fix connector links not visible in agentless flyout (#208068)\n\nFollow
up of https://github.com/elastic/kibana/pull/203824\r\n\r\n##
Summary\r\nThis is a small bugfix for connectors not visible in
agentless flyout.\r\n\r\n## Testing\r\n\r\n- Follow the steps here
https://github.com/elastic/kibana/pull/203824\r\n- Install
elastic-connectors
integration\r\n`app/fleet/integrations/elastic_connectors-1.0.0/add-integration`
and\r\nenroll an agent to it\r\n- The enabled connectors should be
visible in the flyout\r\n\r\n<img width=\"870\" alt=\"Screenshot
2025-01-23 at 15 28
20\"\r\nsrc=\"https://github.com/user-attachments/assets/19cdcbc4-68d5-4e44-875e-15cd849ab84b\"\r\n/>","sha":"1b97e290ec3d18cb0fee8bc4d8cd3d4222b81c93","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[Fleet]
Fix connector links not visible in agentless
flyout","number":208068,"url":"https://github.com/elastic/kibana/pull/208068","mergeCommit":{"message":"[Fleet]
Fix connector links not visible in agentless flyout (#208068)\n\nFollow
up of https://github.com/elastic/kibana/pull/203824\r\n\r\n##
Summary\r\nThis is a small bugfix for connectors not visible in
agentless flyout.\r\n\r\n## Testing\r\n\r\n- Follow the steps here
https://github.com/elastic/kibana/pull/203824\r\n- Install
elastic-connectors
integration\r\n`app/fleet/integrations/elastic_connectors-1.0.0/add-integration`
and\r\nenroll an agent to it\r\n- The enabled connectors should be
visible in the flyout\r\n\r\n<img width=\"870\" alt=\"Screenshot
2025-01-23 at 15 28
20\"\r\nsrc=\"https://github.com/user-attachments/assets/19cdcbc4-68d5-4e44-875e-15cd849ab84b\"\r\n/>","sha":"1b97e290ec3d18cb0fee8bc4d8cd3d4222b81c93"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208068","number":208068,"mergeCommit":{"message":"[Fleet]
Fix connector links not visible in agentless flyout (#208068)\n\nFollow
up of https://github.com/elastic/kibana/pull/203824\r\n\r\n##
Summary\r\nThis is a small bugfix for connectors not visible in
agentless flyout.\r\n\r\n## Testing\r\n\r\n- Follow the steps here
https://github.com/elastic/kibana/pull/203824\r\n- Install
elastic-connectors
integration\r\n`app/fleet/integrations/elastic_connectors-1.0.0/add-integration`
and\r\nenroll an agent to it\r\n- The enabled connectors should be
visible in the flyout\r\n\r\n<img width=\"870\" alt=\"Screenshot
2025-01-23 at 15 28
20\"\r\nsrc=\"https://github.com/user-attachments/assets/19cdcbc4-68d5-4e44-875e-15cd849ab84b\"\r\n/>","sha":"1b97e290ec3d18cb0fee8bc4d8cd3d4222b81c93"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
…208068)

Follow up of elastic#203824

## Summary
This is a small bugfix for connectors not visible in agentless flyout.

## Testing

- Follow the steps here elastic#203824
- Install elastic-connectors integration
`app/fleet/integrations/elastic_connectors-1.0.0/add-integration` and
enroll an agent to it
- The enabled connectors should be visible in the flyout

<img width="870" alt="Screenshot 2025-01-23 at 15 28 20"
src="https://github.com/user-attachments/assets/19cdcbc4-68d5-4e44-875e-15cd849ab84b"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants