Workaround for yarn interdependency conflicts#20805
Merged
tylersmalley merged 2 commits intoelastic:masterfrom Jul 16, 2018
Merged
Workaround for yarn interdependency conflicts#20805tylersmalley merged 2 commits intoelastic:masterfrom
tylersmalley merged 2 commits intoelastic:masterfrom
Conversation
spalger
reviewed
Jul 14, 2018
packages/kbn-es/package.json
Outdated
Contributor
There was a problem hiding this comment.
I recommend adding kbn-es to the list of packages checked by eslint for dependencies: https://github.com/elastic/kibana/blob/master/.eslintrc.js#L93-L108
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
fix-node-modules
branch
from
d3f9d5a to
54bde8c
Compare
Contributor
💚 Build Succeeded |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Jul 16, 2018
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Jul 16, 2018
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developers are running into issues when switching branches, usually resulting in needing to run
yarn kbn cleanto resolve. This is a really odd issue @spalger has reproduced https://github.com/spalger/reproduce-issues/tree/master/yarn-breaks-deps-of-linked-modules and is working on opening an issue for Yarn.Install dependencies on 6.x branch:
git checkout 6.xyarn kbn cleancd packages/kbn-esyarn; cd ../../x-pack; yarn; cd ../packages/kbn-esMove to master:
git checkout masteryarnCheck the kbn-es package and ansi-styles nested dependency
cat node_modules/ansi-styles/package.json(note the version)yarn checkupdate x-pack:
cd ../../x-pack; yarn; cd ../packages/kbn-esRe-check the kbn-es package and ansi-styles nested dependency
cat node_modules/ansi-styles/package.json(note the version)yarn check... weird, right?
Resolves: #20771