Skip to content

Upgrade EUI to v99.1.0#207724

Merged
acstll merged 15 commits intoelastic:mainfrom
acstll:eui/v99.1.0
Jan 30, 2025
Merged

Upgrade EUI to v99.1.0#207724
acstll merged 15 commits intoelastic:mainfrom
acstll:eui/v99.1.0

Conversation

@acstll
Copy link
Contributor

@acstll acstll commented Jan 22, 2025

99.0.0-borealis.199.1.0-borealis.0

Questions? Please see our Kibana upgrade FAQ.


@elastic/eui

v99.1.0

  • Updated EuiColorPalettePicker - adds append to EuiColorPalettePickerPaletteProps to support appending custom content to the title (#8208)
  • Updated font-weight and font-size of EuiBetaBadges to improve legibility (#8255)
  • Added suppport for titleColor variant warning on EuiStat (#8278)

@elastic/eui-theme-borealis

v0.0.9

  • [Visual Refresh] Support new theme tokens on JSON exports (#8277)
  • Remap few colors for EuiLoadingSpinner and EuiLoadingChart (#8276)
  • [Visual Refresh] Update floating border on EuiPanel (#8270)

@acstll acstll added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting v9.0.0 labels Jan 22, 2025
@acstll acstll self-assigned this Jan 22, 2025
@acstll
Copy link
Contributor Author

acstll commented Jan 22, 2025

/ci

to account for the `title` being mandatory on EuiColorPalettePickerPaletteProps
See elastic/eui#8208 (comment)
@acstll
Copy link
Contributor Author

acstll commented Jan 22, 2025

@elasticmachine merge upstream

@acstll
Copy link
Contributor Author

acstll commented Jan 22, 2025

@nickofthyme I added titles to the COLOR_PALETTEs here: d2f53b4, based on the recent changes you made in elastic/eui#8208 in order to fix a type error — but is this really what you want? 🙂

cc @elastic/kibana-presentation

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the ping...

@acstll acstll marked this pull request as ready for review January 23, 2025 12:39
@acstll acstll requested review from a team as code owners January 23, 2025 12:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@acstll acstll requested review from a team as code owners January 23, 2025 16:08
@acstll
Copy link
Contributor Author

acstll commented Jan 23, 2025

@elasticmachine merge upstream

@kc13greiner kc13greiner self-requested a review January 24, 2025 03:00
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server side screens LGTM!

@acstll acstll enabled auto-merge (squash) January 27, 2025 10:48
@acstll acstll disabled auto-merge January 27, 2025 12:00
@acstll acstll requested a review from a team as a code owner January 28, 2025 13:31
@acstll acstll enabled auto-merge (squash) January 28, 2025 13:40
@acstll
Copy link
Contributor Author

acstll commented Jan 29, 2025

@elastic/security-solution @elastic/kibana-visualizations would be great to get your approval 🙏 (only one more test to fix on main before this is ready)

@acstll acstll merged commit 0c18b44 into elastic:main Jan 30, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / useReplaceCustomField calls the api when invoked with the correct parameters

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 165 166 +1
eventAnnotationListing 740 741 +1
expressionHeatmap 210 211 +1
expressionMetricVis 139 140 +1
expressionPartitionVis 223 224 +1
expressionTagcloud 198 199 +1
expressionXY 300 301 +1
lens 1809 1810 +1
observability 1352 1353 +1
visDefaultEditor 234 235 +1
visTypeTimeseries 544 545 +1
total +11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/palettes 27 28 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
charts 17.3KB 17.4KB +122.0B
controls 495.1KB 495.3KB +182.0B
dashboard 601.8KB 601.9KB +182.0B
expressionPartitionVis 43.5KB 43.6KB +102.0B
expressionTagcloud 27.7KB 27.8KB +102.0B
expressionXY 141.9KB 142.0KB +112.0B
lens 1.6MB 1.6MB +369.0B
maps 3.0MB 3.0MB +281.0B
ml 4.7MB 4.7MB +182.0B
visTypeTimeseries 528.4KB 537.4KB +8.9KB
visTypeVega 1.9MB 1.9MB +182.0B
total +10.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.9MB 5.9MB +17.2KB
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +235.0B
visDefaultEditor 21.5KB 30.4KB +8.9KB
total +26.3KB
Unknown metric groups

API count

id before after diff
@kbn/coloring 190 191 +1
@kbn/palettes 44 47 +3
total +4

History

cc @acstll

@acstll
Copy link
Contributor Author

acstll commented Jan 30, 2025

thank you @nickofthyme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants