Make "legacy" Kibana server aware of connection protocol.#20756
Merged
azasypkin merged 2 commits intoelastic:masterfrom Jul 13, 2018
Merged
Make "legacy" Kibana server aware of connection protocol.#20756azasypkin merged 2 commits intoelastic:masterfrom
azasypkin merged 2 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
epixa
suggested changes
Jul 13, 2018
| server.connection({ | ||
| host: config.get('server.host'), | ||
| port: config.get('server.port'), | ||
| tls: config.get('server.ssl.enabled'), |
Contributor
There was a problem hiding this comment.
The comment above says that these values are the same as the new platform configuration, but that's not the case with this tls config. Here tls is a boolean, but in the new platform it's an object with properties. Can you either make them the same or update the comment so this doesn't look like a bug in the future?
Contributor
Author
There was a problem hiding this comment.
Yep, sure, I'll update comment
epixa
approved these changes
Jul 13, 2018
Contributor
epixa
left a comment
There was a problem hiding this comment.
I tested that PDF reporting from visualize works with https enabled.
LGTM once you update the comment
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
flaky selenium test |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
Author
|
6.x\6.4: 2d8ff67 |
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It somehow slipped under my radar, but we need to make sure that legacy Kibana is aware of TLS as several places in Kibana rely on
server.info.protocolorreq.connection.info.protocol(that's basically the same) to build correct external URLs (e.g. SAML in Security plugin and PDF generation in Reporting plugin).To test, please try to generate PDF reports when ES and Kibana run as shown below:
and then
And yeah, we desperately need TLS-enabled integration/functional tests :)