[6.x] [tslint] use exitCode 1 when linter errors (#20567) #20737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`node scripts/tslint` is used to run the linter on all projects, but isn't currently reporting a non-zero status code when there are failures. This PR ensures that the status code is always 1 when an error occurs in the linters. To test make a change to a TypeScript file that violates the linter rules and run `yarn grunt run:tslint` to make sure that `grunt` is seeing the non-zero exit code and fatal-ing correctly. ```sh yarn grunt run:tslint echo $? # should be 1 ```
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: