Skip to content

[ML] Anomaly detection: Use EUI icons for Rare, Geo and Categorization jobs #207269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbrtj merged 1 commit into from
Jan 21, 2025
Merged

[ML] Anomaly detection: Use EUI icons for Rare, Geo and Categorization jobs #207269

rbrtj merged 1 commit into from
Jan 21, 2025

Conversation

@rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Jan 20, 2025

With elastic/eui#8248 merged and icons now available in EUI, updating them in Kibana.
This addresses #204594.

image

@rbrtj rbrtj added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels labels Jan 20, 2025
@rbrtj rbrtj requested a review from peteharverson January 20, 2025 22:23
@rbrtj rbrtj self-assigned this Jan 20, 2025
@rbrtj rbrtj requested a review from a team as a code owner January 20, 2025 22:23
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 20, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2169 2166 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.8MB 4.7MB -2.0KB

cc @rbrtj

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 21, 2025

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson added the Feature:Anomaly Detection ML anomaly detection label Jan 21, 2025
peteharverson
peteharverson approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested both light and dark mode and look good!

@rbrtj rbrtj merged commit 17be4e6 into elastic:main Jan 21, 2025
19 checks passed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 23, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 23, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 207269 locally

@rbrtj rbrtj added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Jan 23, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 23, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@rbrtj @viduni94
[ML] Anomaly detection: Use EUI icons for Rare, Geo and Categorizatio…
1f663ee 
…n jobs (elastic#207269)

With elastic/eui#8248 merged and icons now
available in EUI, updating them in Kibana.
This addresses elastic#204594.

<img width="904" alt="image"
src="https://github.com/user-attachments/assets/92860afe-df74-44d8-b739-c630d4ca40a2"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@rbrtj rbrtj

Labels

backport:skip This PR does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbrtj @elasticmachine @kibanamachine @peteharverson