[6.x] remove angular dependencies in SavedObjectClient (#20384) #20693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create saved object client that is native javascript * fix savedObjectClient unit tests * get saved object client from chrome when being used outside of angular * update error handlers to pull status code from FetchError * add some debug messages to failing functional test * revert changes to management/_objects * add clicks to import done in import objects test * take screenshots of test only failing in CI * remove functional test screenshot code since test is passing in CI now * remove unused file, clean up saved_objects_client test to not use global, add test to error_auto_create_index to ensure compatibility with kfetch errors * add body to kfetch error * update savedObjectClient.bulkCreate * add bulkCreate wrapper to SavedObjectsClientProvider * mark _createSavedObject and _processBatchQueue as private methods
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: