Re-enable the indexPattern:placeholder setting. Change its value to be an empty string.#20685
Merged
cjcenizal merged 2 commits intoelastic:masterfrom Jul 13, 2018
Conversation
…e an empty string.
cjcenizal
added
bug
cjcenizal
requested review from
bmcconaghy and
ruflin
and removed request for
ruflin
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
Code wise LGTM (but not a Kibana expert). Should we really have it empty by default or have it the way it is in the current version with |
Contributor
Author
|
@ruflin Thanks for taking a look! When you go to the index pattern creation wizard you'll still see |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 13, 2018
…e an empty string. (elastic#20685)
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
…e an empty string. (elastic#20685)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20611