[Security Solution] - remove styled-components and cleanup for timeline header actions#206694
Merged
PhilippeOberti merged 1 commit intoelastic:mainfrom Jan 15, 2025
Merged
Conversation
PhilippeOberti
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
jbudz
approved these changes
Jan 14, 2025
…ne header actions
PhilippeOberti
force-pushed
the
styled-components-2
branch
from
534ea66 to
dbceb91
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
|
janmonschke
approved these changes
Jan 15, 2025
Contributor
janmonschke
left a comment
janmonschke
left a comment
There was a problem hiding this comment.
🎉 Thanks for cleaning this up
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12791332443 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Jan 15, 2025
…ne header actions (elastic#206694) ## Summary Similar to [this previous PR](elastic#206523), this PR originally aimed at replacing the usages styled-components with @emotion/react in the security_solution/public/common/components/header_actions folder. I quickly realized that a lot of props and event components were actually not used at all, so a cleanup was welcome. Absolutely no UI or behavior logic changes should be introduced by this PR. This PR will impact the tables in timeline, and the markdown use in osquery. The biggest code cleanup are: - removing a couple of components related to the header actions used in timeline - removing random unused translations, constants or helper functions #### Timeline query, correlation and pinned tabs    ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit d9b9425) # Conflicts: # packages/kbn-babel-preset/styled_components_files.js
PhilippeOberti
added a commit
that referenced
this pull request
Jan 15, 2025
…timeline header actions (#206694) (#206830) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] - remove styled-components and cleanup for timeline header actions (#206694)](#206694) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-01-15T15:14:28Z","message":"[Security Solution] - remove styled-components and cleanup for timeline header actions (#206694)\n\n## Summary\r\n\r\nSimilar to [this previous\r\nPR](#206523), this PR originally\r\naimed at replacing the usages styled-components with @emotion/react in\r\nthe security_solution/public/common/components/header_actions folder. I\r\nquickly realized that a lot of props and event components were actually\r\nnot used at all, so a cleanup was welcome.\r\n\r\nAbsolutely no UI or behavior logic changes should be introduced by this\r\nPR.\r\n\r\nThis PR will impact the tables in timeline, and the markdown use in\r\nosquery.\r\n\r\nThe biggest code cleanup are:\r\n- removing a couple of components related to the header actions used in\r\ntimeline\r\n- removing random unused translations, constants or helper functions\r\n\r\n#### Timeline query, correlation and pinned tabs\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d9b942537250184e3d802f96ae0a5ed221ad6e38","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0"],"number":206694,"url":"https://github.com/elastic/kibana/pull/206694","mergeCommit":{"message":"[Security Solution] - remove styled-components and cleanup for timeline header actions (#206694)\n\n## Summary\r\n\r\nSimilar to [this previous\r\nPR](#206523), this PR originally\r\naimed at replacing the usages styled-components with @emotion/react in\r\nthe security_solution/public/common/components/header_actions folder. I\r\nquickly realized that a lot of props and event components were actually\r\nnot used at all, so a cleanup was welcome.\r\n\r\nAbsolutely no UI or behavior logic changes should be introduced by this\r\nPR.\r\n\r\nThis PR will impact the tables in timeline, and the markdown use in\r\nosquery.\r\n\r\nThe biggest code cleanup are:\r\n- removing a couple of components related to the header actions used in\r\ntimeline\r\n- removing random unused translations, constants or helper functions\r\n\r\n#### Timeline query, correlation and pinned tabs\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d9b942537250184e3d802f96ae0a5ed221ad6e38"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206694","number":206694,"mergeCommit":{"message":"[Security Solution] - remove styled-components and cleanup for timeline header actions (#206694)\n\n## Summary\r\n\r\nSimilar to [this previous\r\nPR](#206523), this PR originally\r\naimed at replacing the usages styled-components with @emotion/react in\r\nthe security_solution/public/common/components/header_actions folder. I\r\nquickly realized that a lot of props and event components were actually\r\nnot used at all, so a cleanup was welcome.\r\n\r\nAbsolutely no UI or behavior logic changes should be introduced by this\r\nPR.\r\n\r\nThis PR will impact the tables in timeline, and the markdown use in\r\nosquery.\r\n\r\nThe biggest code cleanup are:\r\n- removing a couple of components related to the header actions used in\r\ntimeline\r\n- removing random unused translations, constants or helper functions\r\n\r\n#### Timeline query, correlation and pinned tabs\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d9b942537250184e3d802f96ae0a5ed221ad6e38"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…ne header actions (elastic#206694) ## Summary Similar to [this previous PR](elastic#206523), this PR originally aimed at replacing the usages styled-components with @emotion/react in the security_solution/public/common/components/header_actions folder. I quickly realized that a lot of props and event components were actually not used at all, so a cleanup was welcome. Absolutely no UI or behavior logic changes should be introduced by this PR. This PR will impact the tables in timeline, and the markdown use in osquery. The biggest code cleanup are: - removing a couple of components related to the header actions used in timeline - removing random unused translations, constants or helper functions #### Timeline query, correlation and pinned tabs    ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Similar to this previous PR, this PR originally aimed at replacing the usages styled-components with @emotion/react in the security_solution/public/common/components/header_actions folder. I quickly realized that a lot of props and event components were actually not used at all, so a cleanup was welcome.
Absolutely no UI or behavior logic changes should be introduced by this PR.
This PR will impact the tables in timeline, and the markdown use in osquery.
The biggest code cleanup are:
Timeline query, correlation and pinned tabs
Checklist