[Presentation] Remove unused dependencies#206689
Merged
Heenawter merged 3 commits intoelastic:mainfrom Jan 15, 2025
Merged
Conversation
Heenawter
added
Team:Presentation
Heenawter
force-pushed
the
remove-rgl-dependecy_2025-01-14
branch
from
afe8d6a to
0b46f21
Compare
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
mbondyra
approved these changes
Jan 15, 2025
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12792095413 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Heenawter
added a commit
to Heenawter/kibana
that referenced
this pull request
Jan 15, 2025
Closes elastic#205639 ## Summary Now that elastic#205341 is merged, we can remove both `react-grid-layout` and `react-resizable` since they are no longer used in Dashboard (and Dashboard was the only consumer, so they are no longer used anywhere in Kibana). ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks There are no risks to removing an unused dependency. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 364abf7) # Conflicts: # renovate.json
1 task
Heenawter
added a commit
that referenced
this pull request
Jan 15, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Presentation] Remove unused dependencies (#206689)](#206689) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-15T15:54:54Z","message":"[Presentation] Remove unused dependencies (#206689)\n\nCloses https://github.com/elastic/kibana/issues/205639\r\n\r\n## Summary\r\n\r\nNow that #205341 is merged, we can\r\nremove both `react-grid-layout` and `react-resizable` since they are no\r\nlonger used in Dashboard (and Dashboard was the only consumer, so they\r\nare no longer used anywhere in Kibana).\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n \r\nThere are no risks to removing an unused dependency.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"364abf7b09f55f33e84d2f9b635715fc4de9fd92","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:medium","dependencies","v9.0.0","backport:prev-minor"],"title":"[Presentation] Remove unused dependencies","number":206689,"url":"https://github.com/elastic/kibana/pull/206689","mergeCommit":{"message":"[Presentation] Remove unused dependencies (#206689)\n\nCloses https://github.com/elastic/kibana/issues/205639\r\n\r\n## Summary\r\n\r\nNow that #205341 is merged, we can\r\nremove both `react-grid-layout` and `react-resizable` since they are no\r\nlonger used in Dashboard (and Dashboard was the only consumer, so they\r\nare no longer used anywhere in Kibana).\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n \r\nThere are no risks to removing an unused dependency.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"364abf7b09f55f33e84d2f9b635715fc4de9fd92"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206689","number":206689,"mergeCommit":{"message":"[Presentation] Remove unused dependencies (#206689)\n\nCloses https://github.com/elastic/kibana/issues/205639\r\n\r\n## Summary\r\n\r\nNow that #205341 is merged, we can\r\nremove both `react-grid-layout` and `react-resizable` since they are no\r\nlonger used in Dashboard (and Dashboard was the only consumer, so they\r\nare no longer used anywhere in Kibana).\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n \r\nThere are no risks to removing an unused dependency.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"364abf7b09f55f33e84d2f9b635715fc4de9fd92"}}]}] BACKPORT-->
Heenawter
added a commit
to Heenawter/kibana
that referenced
this pull request
Jan 15, 2025
This reverts commit 364abf7.
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Closes elastic#205639 ## Summary Now that elastic#205341 is merged, we can remove both `react-grid-layout` and `react-resizable` since they are no longer used in Dashboard (and Dashboard was the only consumer, so they are no longer used anywhere in Kibana). ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks There are no risks to removing an unused dependency. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205639
Summary
Now that #205341 is merged, we can remove both
react-grid-layoutandreact-resizablesince they are no longer used in Dashboard (and Dashboard was the only consumer, so they are no longer used anywhere in Kibana).Checklist
release_note:*label is applied per the guidelinesIdentify risks
There are no risks to removing an unused dependency.