Closed
Conversation
Contributor
💚 Build Succeeded |
…hecks are removed
Author
|
Tests all passed when the original code was kept the same except for the introduction of a verification phase directly after Page.captureScreenshot. Next step is to remove that code and double check the error will still be hit. |
Contributor
💚 Build Succeeded |
Author
|
Everything is working now??? Maybe a package was upgraded since the failures? Or more likely, some random timing change is hiding it. :( |
Author
|
retest |
Contributor
💔 Build Failed |
Author
|
Okay, hit the bug that time. Will revert to moving the check earlier again and run a few times. |
Contributor
💔 Build Failed |
Author
|
Failed on selenium tests (#20387 (comment), but xpack passed. jenkins, test this |
Contributor
💚 Build Succeeded |
Author
|
Closing in favor of #20770 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.