Ensure the field exists in the index pattern before grabbing it#20639
Merged
Bargs merged 1 commit intoelastic:masterfrom Jul 13, 2018
trevan:filter-bar-lib-map-phrase-missing-field-check
Merged
Ensure the field exists in the index pattern before grabbing it#20639Bargs merged 1 commit intoelastic:masterfrom trevan:filter-bar-lib-map-phrase-missing-field-check
Bargs merged 1 commit intoelastic:masterfrom
trevan:filter-bar-lib-map-phrase-missing-field-check
Conversation
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
Jenkins, test this |
Contributor
💔 Build Failed |
Contributor
Author
|
It looks like the build failed because of the test that was disabled in #20637. I rebased against master to pick up the disable change. |
Contributor
|
jenkins, test this |
Contributor
💚 Build Succeeded |
Bargs
pushed a commit
to Bargs/kibana
that referenced
this pull request
Jul 13, 2018
Bargs
added a commit
that referenced
this pull request
Jul 16, 2018
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when I upgraded to 6.3, sometimes my filter bars were missing. After tracking it down, it looks like the filter bars were using old fields that have been removed from the index pattern.
Since Kibana already checks for the existence of the index pattern, I thought a simple check for the existence of the field would be nice as well. That way, the filter bar will still show up no matter if the index pattern or the field name is bad.