Skip to content

[8.16] [Discover] Fix document comparison table padding (#205984) #206337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Jan 10, 2025
Merged

[8.16] [Discover] Fix document comparison table padding (#205984) #206337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-unified-data-table/src/components/compare_documents/compare_documents.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ describe('CompareDocuments', () => {
"data-test-subj": "unifiedDataTableCompareDocuments",
"gridStyle": Object {
"border": "horizontal",
"cellPadding": "s",
"cellPadding": "l",
"fontSize": "s",
"header": "underline",
"rowHover": "highlight",
Expand Down
6 changes: 5 additions & 1 deletion packages/kbn-unified-data-table/src/components/compare_documents/compare_documents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export interface CompareDocumentsProps {

const COMPARISON_ROW_HEIGHT: EuiDataGridRowHeightsOptions = { defaultHeight: 'auto' };
const COMPARISON_IN_MEMORY: EuiDataGridInMemory = { level: 'sorting' };
const COMPARISON_GRID_STYLE: EuiDataGridStyle = { ...DATA_GRID_STYLE_DEFAULT, stripes: undefined };
const COMPARISON_GRID_STYLE: EuiDataGridStyle = {
...DATA_GRID_STYLE_DEFAULT,
cellPadding: 'l',
stripes: undefined,
};

const getStorageKey = (consumer: string, key: string) => `${consumer}:dataGridComparison${key}`;

Expand Down