[SecuritySolution] Apply different color tokens for themes#206254
Merged
angorayc merged 5 commits intoelastic:mainfrom Jan 10, 2025
Merged
[SecuritySolution] Apply different color tokens for themes#206254angorayc merged 5 commits intoelastic:mainfrom
angorayc merged 5 commits intoelastic:mainfrom
Conversation
angorayc
added
release_note:skip
Contributor
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
|
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…06254) ## Summary Previous changes applied same tokens for Borealis and Amsterdam: elastic#204631 (comment) PR above causes color changes to the current theme, after discussing with UX, we decide to maintain different color tokens until Borealis is launched. This PR should revert the color changed on Amsterdam by the previous PR and only apply the new color for Borealis. | Current and Amsterdam | Borealis | |-------------------------|----------| |Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` | |Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`| ### Host IPs: | Current and Amsterdam | Borealis | |-------------------------|----------| |<img width="2560" alt="host_IPs" src="https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636" />|<img width="2560" alt="host_bor_light" src="https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2" />| |<img width="2558" alt="host_IPs_dark" src="https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee" />|<img width="2553" alt="host_bor_dark" src="https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8" />| ### Network IPs: | Current and Amsterdam | Borealis | |-------------------------|----------| |<img width="2557" alt="network_IPs" src="https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398" />|<img width="2559" alt="network_bor_light" src="https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f" />| |<img width="2558" alt="host_IPs_dark" src="https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc" />|<img width="2560" alt="network_bor_dark" src="https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac" />| ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 13, 2025
…06254) ## Summary Previous changes applied same tokens for Borealis and Amsterdam: elastic#204631 (comment) PR above causes color changes to the current theme, after discussing with UX, we decide to maintain different color tokens until Borealis is launched. This PR should revert the color changed on Amsterdam by the previous PR and only apply the new color for Borealis. | Current and Amsterdam | Borealis | |-------------------------|----------| |Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` | |Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`| ### Host IPs: | Current and Amsterdam | Borealis | |-------------------------|----------| |<img width="2560" alt="host_IPs" src="https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636" />|<img width="2560" alt="host_bor_light" src="https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2" />| |<img width="2558" alt="host_IPs_dark" src="https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee" />|<img width="2553" alt="host_bor_dark" src="https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8" />| ### Network IPs: | Current and Amsterdam | Borealis | |-------------------------|----------| |<img width="2557" alt="network_IPs" src="https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398" />|<img width="2559" alt="network_bor_light" src="https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f" />| |<img width="2558" alt="host_IPs_dark" src="https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc" />|<img width="2560" alt="network_bor_dark" src="https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac" />| ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 4ca5779)
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 13, 2025
…06254) ## Summary Previous changes applied same tokens for Borealis and Amsterdam: elastic#204631 (comment) PR above causes color changes to the current theme, after discussing with UX, we decide to maintain different color tokens until Borealis is launched. This PR should revert the color changed on Amsterdam by the previous PR and only apply the new color for Borealis. | Current and Amsterdam | Borealis | |-------------------------|----------| |Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` | |Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`| ### Host IPs: | Current and Amsterdam | Borealis | |-------------------------|----------| |<img width="2560" alt="host_IPs" src="https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636" />|<img width="2560" alt="host_bor_light" src="https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2" />| |<img width="2558" alt="host_IPs_dark" src="https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee" />|<img width="2553" alt="host_bor_dark" src="https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8" />| ### Network IPs: | Current and Amsterdam | Borealis | |-------------------------|----------| |<img width="2557" alt="network_IPs" src="https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398" />|<img width="2559" alt="network_bor_light" src="https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f" />| |<img width="2558" alt="host_IPs_dark" src="https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc" />|<img width="2560" alt="network_bor_dark" src="https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac" />| ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 4ca5779)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
angorayc
added
v8.18.0
v8.19.0
and removed
backport:skip
angorayc
added a commit
that referenced
this pull request
Feb 13, 2025
…06254) (#210994) # Backport This will backport the following commits from `main` to `8.18`: - [[SecuritySolution] Apply different color tokens for themes (#206254)](#206254) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-10T18:54:47Z","message":"[SecuritySolution] Apply different color tokens for themes (#206254)\n\n## Summary\r\n\r\nPrevious changes applied same tokens for Borealis and Amsterdam:\r\nhttps://github.com//pull/204631#issuecomment-2573415425\r\n\r\nPR above causes color changes to the current theme, after discussing\r\nwith UX, we decide to maintain different color tokens until Borealis is\r\nlaunched. This PR should revert the color changed on Amsterdam by the\r\nprevious PR and only apply the new color for Borealis.\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |\r\n|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|\r\n\r\n### Host IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2560\" alt=\"host_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636\"\r\n/>|<img width=\"2560\" alt=\"host_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee\"\r\n/>|<img width=\"2553\" alt=\"host_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8\"\r\n/>|\r\n\r\n### Network IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2557\" alt=\"network_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398\"\r\n/>|<img width=\"2559\" alt=\"network_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc\"\r\n/>|<img width=\"2560\" alt=\"network_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac\"\r\n/>|\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ca57799b751e48d7657604ab04b50887e5b624c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","EUI Visual Refresh"],"number":206254,"url":"https://github.com/elastic/kibana/pull/206254","mergeCommit":{"message":"[SecuritySolution] Apply different color tokens for themes (#206254)\n\n## Summary\r\n\r\nPrevious changes applied same tokens for Borealis and Amsterdam:\r\nhttps://github.com//pull/204631#issuecomment-2573415425\r\n\r\nPR above causes color changes to the current theme, after discussing\r\nwith UX, we decide to maintain different color tokens until Borealis is\r\nlaunched. This PR should revert the color changed on Amsterdam by the\r\nprevious PR and only apply the new color for Borealis.\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |\r\n|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|\r\n\r\n### Host IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2560\" alt=\"host_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636\"\r\n/>|<img width=\"2560\" alt=\"host_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee\"\r\n/>|<img width=\"2553\" alt=\"host_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8\"\r\n/>|\r\n\r\n### Network IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2557\" alt=\"network_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398\"\r\n/>|<img width=\"2559\" alt=\"network_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc\"\r\n/>|<img width=\"2560\" alt=\"network_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac\"\r\n/>|\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ca57799b751e48d7657604ab04b50887e5b624c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206254","number":206254,"mergeCommit":{"message":"[SecuritySolution] Apply different color tokens for themes (#206254)\n\n## Summary\r\n\r\nPrevious changes applied same tokens for Borealis and Amsterdam:\r\nhttps://github.com//pull/204631#issuecomment-2573415425\r\n\r\nPR above causes color changes to the current theme, after discussing\r\nwith UX, we decide to maintain different color tokens until Borealis is\r\nlaunched. This PR should revert the color changed on Amsterdam by the\r\nprevious PR and only apply the new color for Borealis.\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |\r\n|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|\r\n\r\n### Host IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2560\" alt=\"host_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636\"\r\n/>|<img width=\"2560\" alt=\"host_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee\"\r\n/>|<img width=\"2553\" alt=\"host_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8\"\r\n/>|\r\n\r\n### Network IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2557\" alt=\"network_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398\"\r\n/>|<img width=\"2559\" alt=\"network_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc\"\r\n/>|<img width=\"2560\" alt=\"network_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac\"\r\n/>|\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ca57799b751e48d7657604ab04b50887e5b624c"}}]}] BACKPORT-->
angorayc
added a commit
that referenced
this pull request
Feb 13, 2025
…6254) (#210993) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Apply different color tokens for themes (#206254)](#206254) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-10T18:54:47Z","message":"[SecuritySolution] Apply different color tokens for themes (#206254)\n\n## Summary\r\n\r\nPrevious changes applied same tokens for Borealis and Amsterdam:\r\nhttps://github.com//pull/204631#issuecomment-2573415425\r\n\r\nPR above causes color changes to the current theme, after discussing\r\nwith UX, we decide to maintain different color tokens until Borealis is\r\nlaunched. This PR should revert the color changed on Amsterdam by the\r\nprevious PR and only apply the new color for Borealis.\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |\r\n|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|\r\n\r\n### Host IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2560\" alt=\"host_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636\"\r\n/>|<img width=\"2560\" alt=\"host_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee\"\r\n/>|<img width=\"2553\" alt=\"host_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8\"\r\n/>|\r\n\r\n### Network IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2557\" alt=\"network_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398\"\r\n/>|<img width=\"2559\" alt=\"network_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc\"\r\n/>|<img width=\"2560\" alt=\"network_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac\"\r\n/>|\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ca57799b751e48d7657604ab04b50887e5b624c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","EUI Visual Refresh"],"number":206254,"url":"https://github.com/elastic/kibana/pull/206254","mergeCommit":{"message":"[SecuritySolution] Apply different color tokens for themes (#206254)\n\n## Summary\r\n\r\nPrevious changes applied same tokens for Borealis and Amsterdam:\r\nhttps://github.com//pull/204631#issuecomment-2573415425\r\n\r\nPR above causes color changes to the current theme, after discussing\r\nwith UX, we decide to maintain different color tokens until Borealis is\r\nlaunched. This PR should revert the color changed on Amsterdam by the\r\nprevious PR and only apply the new color for Borealis.\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |\r\n|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|\r\n\r\n### Host IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2560\" alt=\"host_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636\"\r\n/>|<img width=\"2560\" alt=\"host_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee\"\r\n/>|<img width=\"2553\" alt=\"host_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8\"\r\n/>|\r\n\r\n### Network IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2557\" alt=\"network_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398\"\r\n/>|<img width=\"2559\" alt=\"network_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc\"\r\n/>|<img width=\"2560\" alt=\"network_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac\"\r\n/>|\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ca57799b751e48d7657604ab04b50887e5b624c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206254","number":206254,"mergeCommit":{"message":"[SecuritySolution] Apply different color tokens for themes (#206254)\n\n## Summary\r\n\r\nPrevious changes applied same tokens for Borealis and Amsterdam:\r\nhttps://github.com//pull/204631#issuecomment-2573415425\r\n\r\nPR above causes color changes to the current theme, after discussing\r\nwith UX, we decide to maintain different color tokens until Borealis is\r\nlaunched. This PR should revert the color changed on Amsterdam by the\r\nprevious PR and only apply the new color for Borealis.\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |\r\n|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|\r\n\r\n### Host IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2560\" alt=\"host_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636\"\r\n/>|<img width=\"2560\" alt=\"host_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee\"\r\n/>|<img width=\"2553\" alt=\"host_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8\"\r\n/>|\r\n\r\n### Network IPs:\r\n\r\n| Current and Amsterdam | Borealis |\r\n|-------------------------|----------|\r\n|<img width=\"2557\" alt=\"network_IPs\"\r\nsrc=\"https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398\"\r\n/>|<img width=\"2559\" alt=\"network_bor_light\"\r\nsrc=\"https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f\"\r\n/>|\r\n|<img width=\"2558\" alt=\"host_IPs_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc\"\r\n/>|<img width=\"2560\" alt=\"network_bor_dark\"\r\nsrc=\"https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac\"\r\n/>|\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ca57799b751e48d7657604ab04b50887e5b624c"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previous changes applied same tokens for Borealis and Amsterdam:
#204631 (comment)
PR above causes color changes to the current theme, after discussing with UX, we decide to maintain different color tokens until Borealis is launched. This PR should revert the color changed on Amsterdam by the previous PR and only apply the new color for Borealis.
#d36186euiColorVis4-#EE72A6#9170b8euiColorVis2-#61A2FFHost IPs:
Network IPs:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.