[ci] Ensure no yarn.lock changes are required #20625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
force-pushed
the
ci-yarn-lock
branch
from
ee510c1 to
e46f916
Compare
added 2 commits
July 10, 2018 10:31
When using yarn link, we are copying the dependencies from the sub-projects. If a new package is added to one of those projects, we need to also update the yarn.lock file for it's parent. This is usually done by running `yarn kbn bootstrap`. This ensures that after CI runs bootstrap that there are no local changes. Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
ci-yarn-lock
branch
from
e46f916 to
869a609
Compare
Contributor
💔 Build Failed |
This reverts commit 869a609.
Contributor
💚 Build Succeeded |
Contributor
Author
|
@spalger, this is good to go now. |
Contributor
|
I don't want to hold this up because this issue is wasting a lot dev time of late, but let's not add assertions like this to the ci setup script in the future. If something fails in the setup scripts, it's probably an indication in a bug in the setup script or a bug in the ci infrastructure. If this particular check fails, then it's a bug in that commit of Kibana. |
tylersmalley
added a commit
that referenced
this pull request
Jul 11, 2018
When using yarn link, we are copying the dependencies from the sub-projects. If a new package is added to one of those projects, we need to also update the yarn.lock file for it's parent. This is usually done by running `yarn kbn bootstrap`. This ensures that after CI runs bootstrap that there are no local changes.
Contributor
Author
|
6.4/6.x: d5c720f |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using yarn link, we are copying the dependencies from the sub-projects. If a new package is
added to one of those projects, we need to also update the yarn.lock file for its parent. This
is usually done by running
yarn kbn bootstrap. This ensures that after CI runs bootstrap thatthere are no local changes.