Match chalk dependency version on kibana with the one used on x-pack#20621
Merged
mistic merged 3 commits intoelastic:masterfrom Jul 12, 2018
Merged
Conversation
jbudz
reviewed
Jul 10, 2018
package.json
Outdated
| "bunyan": "1.7.1", | ||
| "cache-loader": "1.0.3", | ||
| "chalk": "2.3.0", | ||
| "chalk": "^2.3.2", |
Contributor
There was a problem hiding this comment.
thoughts on ^2.4.1? i don't have a preference but thought i'd note it
Contributor
Author
There was a problem hiding this comment.
@jbudz looking at the changelog it seems okay to go with ^2.4.1 😃
jbudz
approved these changes
Jul 10, 2018
Contributor
Author
|
@jbudz @tylersmalley I've updated the PR to bump the version of chalk to
Are you okay with that? In case you are, I will do the same for |
Contributor
💔 Build Failed |
Member
|
Jenkins, retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jbudz
approved these changes
Jul 11, 2018
tylersmalley
requested changes
Jul 12, 2018
Member
tylersmalley
left a comment
tylersmalley
left a comment
There was a problem hiding this comment.
Looks like this is consistently failing for yarn es snapshot - mind taking a look at that?
$ node scripts/es snapshot
C:\elastic\kibana\packages\kbn-es\node_modules\chalk\index.js:72
ansiStyles.color.closeRe = new RegExp(escapeStringRegexp(ansiStyles.color.close), 'g');
^
TypeError: Cannot read property 'close' of undefined
at Object.<anonymous> (C:\elastic\kibana\packages\kbn-es\node_modules\chalk\index.js:72:75)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (C:\elastic\kibana\packages\kbn-es\src\cli.js:20:15)
at Module._compile (module.js:652:30)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
tylersmalley
approved these changes
Jul 12, 2018
Member
tylersmalley
left a comment
tylersmalley
left a comment
There was a problem hiding this comment.
Error was due to external branch - LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple PR that matches the
chalkdependency version with the one used byx-pack(version^2.4.1). It also bumps thechalkversion to^2.4.1in the following dependencies and update the lockfile when applied:kibanaxpackpackages/kbn-dev-utilspackages/kbn-espackages/kbn-i18npackages/kbn-plugin-generatorpackages/kbn-pmpackages/kbn-testpackages/kbn-ui-frameworkA pretty close thing was done to
6.xin the following PR: #20629