Skip to content

[Automatic Import ] Enable inference connector for Auto Import#206111

Merged
bhapas merged 7 commits intoelastic:mainfrom
bhapas:automatic_import_inference_connector
Jan 9, 2025
Merged

[Automatic Import ] Enable inference connector for Auto Import#206111
bhapas merged 7 commits intoelastic:mainfrom
bhapas:automatic_import_inference_connector

Conversation

@bhapas
Copy link
Copy Markdown
Contributor

@bhapas bhapas commented Jan 9, 2025 •
edited
Loading

Summary

Enables new inference connector in the Automatic Import.

This PR also fixes the use of inferenceEnabled from useAssistantContext since it is not available in AutoImport.

To test

  1. Update the value for inferenceConnectorOn to true in x-pack/platform/plugins/shared/stack_connectors/common/experimental_features.ts
  2. Create an inference connector using OpenAI creds Configure the inference endpoint for completion and name the endpoint openai-completion-preconfig
  3. Now that the inference endpoint is created, add a preconfigured connector with the same credentials.
  4. Select the preconfigured selector in Automatic Import.
  5. Test the Auto Import flow works.

@bhapas bhapas added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Team:Security-Scalability Security Integrations Scalability Team labels Jan 9, 2025
@bhapas bhapas self-assigned this Jan 9, 2025
@bhapas bhapas requested review from a team as code owners January 9, 2025 16:59
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 9, 2025

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 9, 2025

Pinging @elastic/security-scalability (Team:Security-Scalability)

@bhapas bhapas removed the request for review from a team January 9, 2025 17:01
@stephmilovic stephmilovic mentioned this pull request Jan 9, 2025
Merged
@bhapas bhapas requested a review from stephmilovic January 9, 2025 17:17
@bhapas bhapas mentioned this pull request Jan 8, 2025
Closed
4 tasks
haetamoudi
haetamoudi approved these changes Jan 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@haetamoudi haetamoudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have tested the flow with automatic import

@bhapas bhapas enabled auto-merge (squash) January 9, 2025 19:39
@stephmilovic stephmilovic requested a review from a team as a code owner January 9, 2025 20:35
@stephmilovic stephmilovic requested a review from maximpn January 9, 2025 20:35
@stephmilovic
Revert "fix type again..."
422827c 
This reverts commit e1cbb58.
@stephmilovic stephmilovic removed request for a team and maximpn January 9, 2025 20:36
@bhapas bhapas merged commit 668d88e into elastic:main Jan 9, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 9, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12699245739

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 9, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 886.0KB 878.5KB -7.6KB
securitySolution 22.2MB 22.2MB +346.0B
total -7.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
integrationAssistant 10.4KB 10.4KB -52.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/elastic-assistant 15 14 -1

Total ESLint disabled count

id before after diff
@kbn/elastic-assistant 16 15 -1

History

cc @bhapas

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2025
@bhapas @stephmilovic
[Automatic Import ] Enable inference connector for Auto Import (elast…
1582e88 
…ic#206111)

## Summary

Enables new inference connector in the Automatic Import.

This PR also fixes the use of `inferenceEnabled` from
`useAssistantContext` since it is not available in AutoImport.

## To test

1. Update the value for `inferenceConnectorOn` to `true` in
`x-pack/platform/plugins/shared/stack_connectors/common/experimental_features.ts`
2. Create an inference connector using [OpenAI
creds](https://p.elstc.co/paste/36VivuC+#TnP7-Z7wBKDUg8fQ/lTycSCdwUxEEbHcyQ/Q0i3oEmO).
Configure the inference endpoint for completion and name the endpoint
`openai-completion-preconfig`
3. Now that the inference endpoint is created, add a [preconfigured
connector](https://p.elstc.co/paste/tFWF3LSA#0thBRW05e6KSSkLCDjQiH8GkECQySBiHm6zRMCUThlf)
with the same credentials.
4. Select the preconfigured selector in Automatic Import.
5. Test the Auto Import flow works.

---------

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
(cherry picked from commit 668d88e)
@kibanamachine kibanamachine mentioned this pull request Jan 9, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 9, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 9, 2025
@kibanamachine @bhapas
[8.x] [Automatic Import ] Enable inference connector for Auto Import (#…
362498b 
…206111) (#206146)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Automatic Import ] Enable inference connector for Auto Import
(#206111)](#206111)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bharat
Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-09T22:04:33Z","message":"[Automatic
Import ] Enable inference connector for Auto Import (#206111)\n\n##
Summary\r\n\r\nEnables new inference connector in the Automatic
Import.\r\n\r\nThis PR also fixes the use of `inferenceEnabled`
from\r\n`useAssistantContext` since it is not available in
AutoImport.\r\n\r\n## To test\r\n\r\n1. Update the value for
`inferenceConnectorOn` to `true`
in\r\n`x-pack/platform/plugins/shared/stack_connectors/common/experimental_features.ts`\r\n2.
Create an inference connector using
[OpenAI\r\ncreds](https://p.elstc.co/paste/36VivuC+#TnP7-Z7wBKDUg8fQ/lTycSCdwUxEEbHcyQ/Q0i3oEmO).\r\nConfigure
the inference endpoint for completion and name the
endpoint\r\n`openai-completion-preconfig`\r\n3. Now that the inference
endpoint is created, add a
[preconfigured\r\nconnector](https://p.elstc.co/paste/tFWF3LSA#0thBRW05e6KSSkLCDjQiH8GkECQySBiHm6zRMCUThlf)\r\nwith
the same credentials.\r\n4. Select the preconfigured selector in
Automatic Import.\r\n5. Test the Auto Import flow
works.\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<stephanie.milovic@elastic.co>","sha":"668d88e19e6c8e0b28290ecad377649f507716a3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Security-Scalability"],"title":"[Automatic
Import ] Enable inference connector for Auto
Import","number":206111,"url":"https://github.com/elastic/kibana/pull/206111","mergeCommit":{"message":"[Automatic
Import ] Enable inference connector for Auto Import (#206111)\n\n##
Summary\r\n\r\nEnables new inference connector in the Automatic
Import.\r\n\r\nThis PR also fixes the use of `inferenceEnabled`
from\r\n`useAssistantContext` since it is not available in
AutoImport.\r\n\r\n## To test\r\n\r\n1. Update the value for
`inferenceConnectorOn` to `true`
in\r\n`x-pack/platform/plugins/shared/stack_connectors/common/experimental_features.ts`\r\n2.
Create an inference connector using
[OpenAI\r\ncreds](https://p.elstc.co/paste/36VivuC+#TnP7-Z7wBKDUg8fQ/lTycSCdwUxEEbHcyQ/Q0i3oEmO).\r\nConfigure
the inference endpoint for completion and name the
endpoint\r\n`openai-completion-preconfig`\r\n3. Now that the inference
endpoint is created, add a
[preconfigured\r\nconnector](https://p.elstc.co/paste/tFWF3LSA#0thBRW05e6KSSkLCDjQiH8GkECQySBiHm6zRMCUThlf)\r\nwith
the same credentials.\r\n4. Select the preconfigured selector in
Automatic Import.\r\n5. Test the Auto Import flow
works.\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<stephanie.milovic@elastic.co>","sha":"668d88e19e6c8e0b28290ecad377649f507716a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206111","number":206111,"mergeCommit":{"message":"[Automatic
Import ] Enable inference connector for Auto Import (#206111)\n\n##
Summary\r\n\r\nEnables new inference connector in the Automatic
Import.\r\n\r\nThis PR also fixes the use of `inferenceEnabled`
from\r\n`useAssistantContext` since it is not available in
AutoImport.\r\n\r\n## To test\r\n\r\n1. Update the value for
`inferenceConnectorOn` to `true`
in\r\n`x-pack/platform/plugins/shared/stack_connectors/common/experimental_features.ts`\r\n2.
Create an inference connector using
[OpenAI\r\ncreds](https://p.elstc.co/paste/36VivuC+#TnP7-Z7wBKDUg8fQ/lTycSCdwUxEEbHcyQ/Q0i3oEmO).\r\nConfigure
the inference endpoint for completion and name the
endpoint\r\n`openai-completion-preconfig`\r\n3. Now that the inference
endpoint is created, add a
[preconfigured\r\nconnector](https://p.elstc.co/paste/tFWF3LSA#0thBRW05e6KSSkLCDjQiH8GkECQySBiHm6zRMCUThlf)\r\nwith
the same credentials.\r\n4. Select the preconfigured selector in
Automatic Import.\r\n5. Test the Auto Import flow
works.\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<stephanie.milovic@elastic.co>","sha":"668d88e19e6c8e0b28290ecad377649f507716a3"}}]}]
BACKPORT-->

Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@bhapas @stephmilovic @viduni94
[Automatic Import ] Enable inference connector for Auto Import (elast…
2d271f4 
…ic#206111)

## Summary

Enables new inference connector in the Automatic Import.

This PR also fixes the use of `inferenceEnabled` from
`useAssistantContext` since it is not available in AutoImport.

## To test

1. Update the value for `inferenceConnectorOn` to `true` in
`x-pack/platform/plugins/shared/stack_connectors/common/experimental_features.ts`
2. Create an inference connector using [OpenAI
creds](https://p.elstc.co/paste/36VivuC+#TnP7-Z7wBKDUg8fQ/lTycSCdwUxEEbHcyQ/Q0i3oEmO).
Configure the inference endpoint for completion and name the endpoint
`openai-completion-preconfig`
3. Now that the inference endpoint is created, add a [preconfigured
connector](https://p.elstc.co/paste/tFWF3LSA#0thBRW05e6KSSkLCDjQiH8GkECQySBiHm6zRMCUThlf)
with the same credentials.
4. Select the preconfigured selector in Automatic Import.
5. Test the Auto Import flow works.

---------

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@haetamoudi haetamoudi haetamoudi approved these changes

Assignees

@bhapas bhapas

Labels

release_note:enhancement Team:Security-Scalability Security Integrations Scalability Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bhapas @elasticmachine @kibanamachine @stephmilovic @haetamoudi