[Visual Refresh] behindText datavis and severity color cleanup by mgadewoll · Pull Request #206061 · elastic/kibana

mgadewoll · 2025-01-09T13:44:10Z

Summary

This PR adds cleanups to previously merged Borealis-related updates to usages of severity colors and/or behindText data vis colors as EUI provides matching tokens and initial guidance on usage by now (see point 5) in this FAQ for the guidance).
These updates ensure that we keep parity for Amsterdam colors by using conditional updates while using semantic tokens for Borealis.

Note

Please let me know in case your team already made those changes or has other plans for the code.

ℹ️ Management changes were done separately by the team itself here.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

elasticmachine · 2025-01-14T12:42:50Z

Pinging @elastic/eui-team (EUI)

elasticmachine · 2025-01-14T17:15:07Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2025-01-14T17:15:07Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine · 2025-01-14T17:15:07Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

MiriamAparicio

Changes in obs-ux-infra_services LGTM, thanks for the cleanup 🌟

criamico

I tested Fleet changes locally, LGTM

walterra

ML related changes LGTM, tested the colors on both themes for NER tests.

mgadewoll · 2025-01-20T08:17:31Z

@elasticmachine merge upstream

mgadewoll · 2025-01-20T08:18:17Z

@elastic/obs-ux-management-team and @elastic/kibana-operations could you have a look as well please? 🙂

delanni · 2025-01-21T13:37:01Z

...ication/model_management/test_models/models/question_answering/question_answering_output.tsx

This spot seems to have a different way of checking if the theme is indeed Amsterdam.

I can see how these could be equivalent, but it stands out, maybe it's worth following the pattern with others?

Yeah they mean the same and both have been used, but I agree that it's better to align on one. I'll update to use themeName instead as it's more straight forward. 👍

- reverts Amsterdam colors of previously changed usages by using conditions; uses new available tokens

elasticmachine · 2025-01-21T15:46:41Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 5b09b7d

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #45 / console app console app tabs navigation tabs should be navigable through URL

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.0MB	4.0MB	+736.0B
`fleet`	1.7MB	1.7MB	+158.0B
`ml`	4.8MB	4.8MB	-19.0B
`synthetics`	917.5KB	917.6KB	+124.0B
`uptime`	461.4KB	461.6KB	+200.0B
total			+1.2KB

History

💚 Build #268322 succeeded 2ffb37a3c307025c4d02351ea9d22efc3789632c
💔 Build #267361 failed e7478b049c5ebf6256080e6ff76237a93d433b3f
💔 Build #267082 failed f47b5d695dfad6a70d9c21cf7e7f5fb3df1dd354
💚 Build #266559 succeeded a5ce42e3e8f20619b618c8a74087b274bd3f8d90
💔 Build #265615 failed 9fe0a019cb1278f88fcbe81dc866a13c5d1a583b

…ic#206061) ## Summary This PR adds cleanups to previously merged Borealis-related updates to usages of severity colors and/or `behindText` data vis colors as EUI provides matching tokens and initial guidance on usage by now (see point 5) in this [FAQ](elastic#199715 (comment)) for the guidance). These updates ensure that we keep parity for Amsterdam colors by using conditional updates while using semantic tokens for Borealis. >[!NOTE] Please let me know in case your team already made those changes or has other plans for the code. ℹ️ Management changes were done separately by the team itself [here](elastic#206026). --- ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

mgadewoll added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting EUI Visual Refresh labels Jan 9, 2025

mgadewoll force-pushed the eui/162-163-behindText-and-severity-color-cleanup branch from 9fe0a01 to a5ce42e Compare January 13, 2025 14:48

mgadewoll added the v9.0.0 label Jan 14, 2025

mgadewoll marked this pull request as ready for review January 14, 2025 12:42

mgadewoll requested a review from a team as a code owner January 14, 2025 12:42

mgadewoll requested a review from a team January 14, 2025 12:42

mgadewoll requested review from a team as code owners January 14, 2025 12:42

mgadewoll force-pushed the eui/162-163-behindText-and-severity-color-cleanup branch from a5ce42e to f47b5d6 Compare January 14, 2025 17:15

MiriamAparicio approved these changes Jan 15, 2025

View reviewed changes

mgadewoll force-pushed the eui/162-163-behindText-and-severity-color-cleanup branch from f47b5d6 to e7478b0 Compare January 15, 2025 13:23

criamico approved these changes Jan 16, 2025

View reviewed changes

walterra approved these changes Jan 17, 2025

View reviewed changes

shahzad31 approved these changes Jan 20, 2025

View reviewed changes

delanni reviewed Jan 21, 2025

View reviewed changes

delanni approved these changes Jan 21, 2025

View reviewed changes

refactor: update usages of behindText datavis and severity colors

deb2ac9

- reverts Amsterdam colors of previously changed usages by using conditions; uses new available tokens

refactor: use themeName for checking theme instead of flag

5b09b7d

mgadewoll force-pushed the eui/162-163-behindText-and-severity-color-cleanup branch from 2ffb37a to 5b09b7d Compare January 21, 2025 13:44

mgadewoll enabled auto-merge (squash) January 21, 2025 13:45

mgadewoll merged commit 8050089 into elastic:main Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Visual Refresh] behindText datavis and severity color cleanup#206061

[Visual Refresh] behindText datavis and severity color cleanup#206061
mgadewoll merged 2 commits intoelastic:mainfrom
mgadewoll:eui/162-163-behindText-and-severity-color-cleanup

mgadewoll commented Jan 9, 2025 •

edited

Loading

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

MiriamAparicio left a comment

Uh oh!

criamico left a comment

Uh oh!

walterra left a comment

Uh oh!

mgadewoll commented Jan 20, 2025 •

edited

Loading

Uh oh!

mgadewoll commented Jan 20, 2025

Uh oh!

delanni Jan 21, 2025

Uh oh!

mgadewoll Jan 21, 2025

Uh oh!

elasticmachine commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

mgadewoll commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

elasticmachine commented Jan 14, 2025

Uh oh!

MiriamAparicio left a comment

Choose a reason for hiding this comment

Uh oh!

criamico left a comment

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

mgadewoll commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mgadewoll commented Jan 20, 2025

Uh oh!

delanni Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

mgadewoll Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 21, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mgadewoll commented Jan 9, 2025 •

edited

Loading

mgadewoll commented Jan 20, 2025 •

edited

Loading