Skip to content

[Detection Engine][API Docs] Update request/response examples for value lists APIs#205957

Merged
yctercero merged 24 commits intoelastic:mainfrom
yctercero:update_value_list_openapi_descx
Jan 23, 2025
Merged

[Detection Engine][API Docs] Update request/response examples for value lists APIs#205957
yctercero merged 24 commits intoelastic:mainfrom
yctercero:update_value_list_openapi_descx

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

@yctercero yctercero commented Jan 8, 2025

Summary

As part of the effort to add missing content for Security APIs, this PR introduces a few missing request, response, and parameter examples for Detection Engine Value Lists APIs.

How to Test

Run a local preview in bump, which shows what the output will look like in our production.

  • Install the bump CLI
  • cd x-pack/solutions/security/packages/kbn-securitysolution-exceptions-common and then run npm run openapi:generate followed by npm run openapi:bundle. That last command gives you the path to the bundled file at the end that is used in the next step.
  • Run bump preview x-pack/solutions/security/packages/kbn-securitysolution-lists-common/docs/openapi/ess/security_solution_lists_api_2023_10_31.bundled.schema.yaml

@yctercero yctercero requested a review from a team as a code owner January 8, 2025 19:31
@yctercero yctercero requested a review from nkhristinin January 8, 2025 19:31
@yctercero yctercero added the Team:Detection Engine Security Solution Detection Engine Area label Jan 8, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@yctercero yctercero requested a review from a team January 8, 2025 19:31
@yctercero yctercero added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.16.0 backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Jan 8, 2025
@yctercero yctercero self-assigned this Jan 8, 2025
Copy link
Copy Markdown
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these examples, @yctercero! There are still some parameter descriptions missing (see column B in this spreadsheet) – will that be addressed separately?

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
…ue lists APIs (elastic#205957)

# Summary

As part of the effort to add missing content for Security APIs, this PR
introduces a few missing request, response, and parameter examples for
Detection Engine Value Lists APIs.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 27, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205957 locally

4 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205957 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205957 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205957 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205957 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205957 locally

@yctercero
Copy link
Copy Markdown
Contributor Author

💔 Some backports could not be created

Status Branch Result
8.18 Could not create pull request: Resource not accessible by personal access token
8.17
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 205957

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@yctercero
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

yctercero added a commit that referenced this pull request Feb 5, 2025
…or value lists APIs (#205957) (#209462)

Backporting #205957

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@yctercero
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@yctercero
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

yctercero added a commit that referenced this pull request Feb 6, 2025
…for value lists APIs (#205957) (#209691)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Detection Engine][API Docs] Update request/response examples for
value lists APIs
(#205957)](#205957)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-23T15:19:45Z","message":"[Detection
Engine][API Docs] Update request/response examples for value lists APIs
(#205957)\n\n# Summary\r\n\r\nAs part of the effort to add missing
content for Security APIs, this PR\r\nintroduces a few missing request,
response, and parameter examples for\r\nDetection Engine Value Lists
APIs.","sha":"e396ac9a1438fcb16c2e4f1b61c3633de098d9bf","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","Team:Detection
Engine","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Detection
Engine][API Docs] Update request/response examples for value lists
APIs","number":205957,"url":"https://github.com/elastic/kibana/pull/205957","mergeCommit":{"message":"[Detection
Engine][API Docs] Update request/response examples for value lists APIs
(#205957)\n\n# Summary\r\n\r\nAs part of the effort to add missing
content for Security APIs, this PR\r\nintroduces a few missing request,
response, and parameter examples for\r\nDetection Engine Value Lists
APIs.","sha":"e396ac9a1438fcb16c2e4f1b61c3633de098d9bf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205957","number":205957,"mergeCommit":{"message":"[Detection
Engine][API Docs] Update request/response examples for value lists APIs
(#205957)\n\n# Summary\r\n\r\nAs part of the effort to add missing
content for Security APIs, this PR\r\nintroduces a few missing request,
response, and parameter examples for\r\nDetection Engine Value Lists
APIs.","sha":"e396ac9a1438fcb16c2e4f1b61c3633de098d9bf"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209597","number":209597,"state":"OPEN"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209586","number":209586,"state":"OPEN"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/209462","number":209462,"branch":"8.18","state":"OPEN"}]}]
BACKPORT-->
yctercero added a commit that referenced this pull request Feb 6, 2025
…for value lists APIs (#205957) (#209597)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Detection Engine][API Docs] Update request/response examples for
value lists APIs
(#205957)](#205957)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-23T15:19:45Z","message":"[Detection
Engine][API Docs] Update request/response examples for value lists APIs
(#205957)\n\n# Summary\r\n\r\nAs part of the effort to add missing
content for Security APIs, this PR\r\nintroduces a few missing request,
response, and parameter examples for\r\nDetection Engine Value Lists
APIs.","sha":"e396ac9a1438fcb16c2e4f1b61c3633de098d9bf","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","Team:Detection
Engine","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Detection
Engine][API Docs] Update request/response examples for value lists
APIs","number":205957,"url":"https://github.com/elastic/kibana/pull/205957","mergeCommit":{"message":"[Detection
Engine][API Docs] Update request/response examples for value lists APIs
(#205957)\n\n# Summary\r\n\r\nAs part of the effort to add missing
content for Security APIs, this PR\r\nintroduces a few missing request,
response, and parameter examples for\r\nDetection Engine Value Lists
APIs.","sha":"e396ac9a1438fcb16c2e4f1b61c3633de098d9bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205957","number":205957,"mergeCommit":{"message":"[Detection
Engine][API Docs] Update request/response examples for value lists APIs
(#205957)\n\n# Summary\r\n\r\nAs part of the effort to add missing
content for Security APIs, this PR\r\nintroduces a few missing request,
response, and parameter examples for\r\nDetection Engine Value Lists
APIs.","sha":"e396ac9a1438fcb16c2e4f1b61c3633de098d9bf"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.16.4 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area v8.16.0 v8.16.4 v8.17.0 v8.17.2 v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants