Skip to content

[File Upload Component] Use forms.maxWidth styling from euiTheme #205947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsullivan merged 1 commit into from
Jan 8, 2025
Merged

[File Upload Component] Use forms.maxWidth styling from euiTheme #205947

tsullivan merged 1 commit into from
Jan 8, 2025

Conversation

@tsullivan
Copy link
Member

@tsullivan tsullivan commented Jan 8, 2025

Summary

Follows elastic/eui#8221

@tsullivan tsullivan requested a review from a team as a code owner January 8, 2025 18:25
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Jan 8, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025

Pinging @elastic/appex-sharedux (Team:SharedUX)

paulinashakirova
paulinashakirova approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@paulinashakirova paulinashakirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #63 / discover/security/context_awareness security root profile cell renderers host.name DataView mode should open host.name flyout

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 539.8KB 539.8KB -23.0B
imageEmbeddable 65.4KB 65.3KB -23.0B
total -46.0B

@tsullivan tsullivan merged commit 63c0d18 into elastic:main Jan 8, 2025
16 checks passed
@tsullivan tsullivan deleted the fileupload/use-formmaxwidth-euitheme branch January 8, 2025 20:58
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@tsullivan @viduni94
[File Upload Component] Use forms.maxWidth styling from euiTheme (ela…
0894c46 
…stic#205947)

## Summary

Follows elastic/eui#8221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulinashakirova paulinashakirova paulinashakirova approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tsullivan @elasticmachine @paulinashakirova @kibanamachine