de-angularize indexPatterns Field and FieldList#20589
Merged
nreese merged 5 commits intoelastic:masterfrom Jul 13, 2018
Merged
Conversation
Contributor
💚 Build Succeeded |
cjcenizal
approved these changes
Jul 9, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Code LGTM. I tested locally by using the field chooser in discover and creating a scripted field in management. Everything worked normally. Just had one question.
| }; | ||
| }) | ||
| })); | ||
| jest.mock('ui/chrome', |
Contributor
There was a problem hiding this comment.
Why was this added? I tried running the tests without it and there didn't seem to be any difference.
Contributor
💔 Build Failed |
Contributor
Author
|
unrelated test error in kibana visualization jenkins, test this |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jen-huang
approved these changes
Jul 13, 2018
Contributor
jen-huang
left a comment
jen-huang
left a comment
There was a problem hiding this comment.
Ran locally, tested creating index pattern, editing fields, and using them in visualizations.
LGTM
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 13, 2018
* de-angularize indexPatterns Field and FieldList * do not remove shortDots angular filter * remove ui/chrome mock in _index_pattern test
nreese
added a commit
that referenced
this pull request
Jul 13, 2018
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
* de-angularize indexPatterns Field and FieldList * do not remove shortDots angular filter * remove ui/chrome mock in _index_pattern test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the beginning of removing angular dependency from indexPatterns. It removes angular from Field and FieldList.