-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[DOCS] Dashboard: Includes Add Panel and Inspector #20582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stacey-gammon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, code review only, did not build docs
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the docs/images/Dashboard_example.png screenshot, the first panel is wrapping and this is causing part of the panel contents to be clipped. Would it be possible to get a screen shot without any wrapping in this panel?
docs/dashboard.asciidoc
Outdated
|
|
||
| If you haven't yet indexed data into {es} or created an index pattern, | ||
| you'll be prompted to do so as you follow the steps for creating a dashboard. | ||
| Or, you can use the prebuilt flight data set, available from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to just say a generic message like "use one of the prebuilt sample data sets". That way, if the flight data is ever removed, this comment still makes sense?
nreese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
code review
💔 Build Failed |
|
Jenkins, test this |
💚 Build Succeeded |
* [DOCS] Dashboard: Includes Add Panel and Inspector * [DOCS] Dashboard: Incorporated review comments
This PR updates the Dashboard docs. Changes include:
Inspect command and Add Panel
Changes to Save command