Skip to content

Conversation

@gchaps
Copy link
Contributor

@gchaps gchaps commented Jul 9, 2018

This PR updates the Dashboard docs. Changes include:

  • Inspect command and Add Panel

  • Changes to Save command

Copy link

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, code review only, did not build docs

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs/images/Dashboard_example.png screenshot, the first panel is wrapping and this is causing part of the panel contents to be clipped. Would it be possible to get a screen shot without any wrapping in this panel?


If you haven't yet indexed data into {es} or created an index pattern,
you'll be prompted to do so as you follow the steps for creating a dashboard.
Or, you can use the prebuilt flight data set, available from the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to just say a generic message like "use one of the prebuilt sample data sets". That way, if the flight data is ever removed, this comment still makes sense?

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

@elasticmachine
Copy link
Contributor

💔 Build Failed

@gchaps
Copy link
Contributor Author

gchaps commented Jul 10, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gchaps gchaps merged commit 676c0bd into elastic:master Jul 10, 2018
@gchaps gchaps deleted the docs/dashboard/6.4-updates branch July 10, 2018 22:08
gchaps added a commit to gchaps/kibana that referenced this pull request Jul 10, 2018
* [DOCS] Dashboard: Includes Add Panel and Inspector

* [DOCS] Dashboard: Incorporated review comments
gchaps added a commit that referenced this pull request Jul 11, 2018
* [DOCS] Dashboard: Includes Add Panel and Inspector

* [DOCS] Dashboard: Incorporated review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants