[ResponseOps] Granular connector RBAC followup #205818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doakalexi
changed the title
doakalexi
changed the title
doakalexi
added
Team:ResponseOps
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
paul-tavares
approved these changes
Jan 15, 2025
Contributor
paul-tavares
left a comment
paul-tavares
left a comment
There was a problem hiding this comment.
Thank you for the changes. I checked the PR out and ran through the security solution functionality and LGTM 👍
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12896296671 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 21, 2025
## Summary This PR is followup to, elastic#203503. This PR adds a test to make sure that sub-feature description remains accurate, and changes to hide the connector edit test tab and create connector button when a user only has read access. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### To verify 1. Create a new read only role and disable EDR connectors under the Actions and Connectors privilege 2. Create a new user and assign that role to user 3. Create a Sentinel One connector (It doesn't need to work, you can use fake values for the url and token) 4. Login as the new user and go to the connector page in stack management 5. Verify that the "Create connector" button is not visible 6. Click on the connector you created, verify that you can't see the test tab (cherry picked from commit 12998a8)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 21, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps] Granular connector RBAC followup (#205818)](#205818) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexi Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-21T21:33:54Z","message":"[ResponseOps] Granular connector RBAC followup (#205818)\n\n## Summary\r\n\r\nThis PR is followup to, https://github.com/elastic/kibana/pull/203503.\r\nThis PR adds a test to make sure that sub-feature description remains\r\naccurate, and changes to hide the connector edit test tab and create\r\nconnector button when a user only has read access.\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n1. Create a new read only role and disable EDR connectors under the\r\nActions and Connectors privilege\r\n2. Create a new user and assign that role to user\r\n3. Create a Sentinel One connector (It doesn't need to work, you can use\r\nfake values for the url and token)\r\n4. Login as the new user and go to the connector page in stack\r\nmanagement\r\n5. Verify that the \"Create connector\" button is not visible\r\n6. Click on the connector you created, verify that you can't see the\r\ntest tab","sha":"12998a8fe1823c3ba672ad8ff68a1292ccc72d8e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[ResponseOps] Granular connector RBAC followup","number":205818,"url":"https://github.com/elastic/kibana/pull/205818","mergeCommit":{"message":"[ResponseOps] Granular connector RBAC followup (#205818)\n\n## Summary\r\n\r\nThis PR is followup to, https://github.com/elastic/kibana/pull/203503.\r\nThis PR adds a test to make sure that sub-feature description remains\r\naccurate, and changes to hide the connector edit test tab and create\r\nconnector button when a user only has read access.\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n1. Create a new read only role and disable EDR connectors under the\r\nActions and Connectors privilege\r\n2. Create a new user and assign that role to user\r\n3. Create a Sentinel One connector (It doesn't need to work, you can use\r\nfake values for the url and token)\r\n4. Login as the new user and go to the connector page in stack\r\nmanagement\r\n5. Verify that the \"Create connector\" button is not visible\r\n6. Click on the connector you created, verify that you can't see the\r\ntest tab","sha":"12998a8fe1823c3ba672ad8ff68a1292ccc72d8e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205818","number":205818,"mergeCommit":{"message":"[ResponseOps] Granular connector RBAC followup (#205818)\n\n## Summary\r\n\r\nThis PR is followup to, https://github.com/elastic/kibana/pull/203503.\r\nThis PR adds a test to make sure that sub-feature description remains\r\naccurate, and changes to hide the connector edit test tab and create\r\nconnector button when a user only has read access.\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n1. Create a new read only role and disable EDR connectors under the\r\nActions and Connectors privilege\r\n2. Create a new user and assign that role to user\r\n3. Create a Sentinel One connector (It doesn't need to work, you can use\r\nfake values for the url and token)\r\n4. Login as the new user and go to the connector page in stack\r\nmanagement\r\n5. Verify that the \"Create connector\" button is not visible\r\n6. Click on the connector you created, verify that you can't see the\r\ntest tab","sha":"12998a8fe1823c3ba672ad8ff68a1292ccc72d8e"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexi Doak <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary This PR is followup to, elastic#203503. This PR adds a test to make sure that sub-feature description remains accurate, and changes to hide the connector edit test tab and create connector button when a user only has read access. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### To verify 1. Create a new read only role and disable EDR connectors under the Actions and Connectors privilege 2. Create a new user and assign that role to user 3. Create a Sentinel One connector (It doesn't need to work, you can use fake values for the url and token) 4. Login as the new user and go to the connector page in stack management 5. Verify that the "Create connector" button is not visible 6. Click on the connector you created, verify that you can't see the test tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is followup to, #203503. This PR adds a test to make sure that sub-feature description remains accurate, and changes to hide the connector edit test tab and create connector button when a user only has read access.
Checklist
To verify