Removing kbn-version from the response headers.#20551
Merged
kobelb merged 2 commits intoelastic:masterfrom Jul 13, 2018
Merged
Conversation
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
kobelb
changed the title
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jul 13, 2018
* Removing kbn-version from the response headers. * Removing test assert that we don't need
kobelb
added a commit
that referenced
this pull request
Jul 13, 2018
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
* Removing kbn-version from the response headers. * Removing test assert that we don't need
|
Is there some other way to programatically determine Kibana's version? That is useful for applications using the REST APIs as there may be changes from version to version. For example, it looks like the default dashboard panel sizes have changed from 6 x 3 to 24 x 15 between 6.2 and 6.3. There might be other similar changes. |
Contributor
|
@chavdar The version info should be included in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently always adding the
kbn-versionheader to all responses, but this doesn't appear to be utilized anywhere. The version checking logic is pulling thekbn-versionfrom initial state that is injected.Resolves #20573
"Release Note: No longer setting unnecessary
kbn-versionheader on all HTTP responses"