[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh#205416
Merged
Bluefinger merged 3 commits intoelastic:mainfrom Jan 3, 2025
Merged
[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh#205416Bluefinger merged 3 commits intoelastic:mainfrom
Bluefinger merged 3 commits intoelastic:mainfrom
Conversation
Bluefinger
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
crespocarlos
reviewed
Jan 3, 2025
crespocarlos
approved these changes
Jan 3, 2025
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12599635134 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle. (cherry picked from commit d25dcc1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle. (cherry picked from commit d25dcc1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle. (cherry picked from commit d25dcc1)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
…auto-refresh (#205416) (#205504) # Backport This will backport the following commits from `main` to `8.16`: - [[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)](#205416) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-01-03T15:04:17Z","message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services","v8.16.3","v8.17.1"],"title":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh","number":205416,"url":"https://github.com/elastic/kibana/pull/205416","mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205416","number":205416,"mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
…auto-refresh (#205416) (#205505) # Backport This will backport the following commits from `main` to `8.17`: - [[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)](#205416) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-01-03T15:04:17Z","message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services","v8.16.3","v8.17.1"],"title":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh","number":205416,"url":"https://github.com/elastic/kibana/pull/205416","mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205416","number":205416,"mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
…uto-refresh (#205416) (#205506) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)](#205416) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-01-03T15:04:17Z","message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services","v8.16.3","v8.17.1"],"title":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh","number":205416,"url":"https://github.com/elastic/kibana/pull/205416","mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205416","number":205416,"mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be).
Closes #205414
How to test