Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Add @kbn/shared-ux-router to shared bundle (#204786) #205278

Merged
merged 1 commit into from
Dec 31, 2024
Merged

[8.x] Add @kbn/shared-ux-router to shared bundle (#204786) #205278

merged 1 commit into from
Dec 31, 2024
+3 −0

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Dec 30, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@Dosant
Add @kbn/shared-ux-router to shared bundle (elastic#204786)
05e938b 
## Summary

Part of elastic#204761 . This package
is used by every app and I thought it is worth adding it to the shared
bundle. Especially since it is already part of Bazel.

(cherry picked from commit b64ff10)
@Dosant Dosant enabled auto-merge (squash) December 30, 2024 16:34
@Dosant Dosant mentioned this pull request Dec 30, 2024
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiAssistantManagementSelection 76 65 -11
alerting 231 220 -11
apm 1919 1910 -9
canvas 1282 1271 -11
cases 847 838 -9
cloudDefend 111 102 -9
cloudSecurityPosture 650 642 -8
console 225 214 -11
core 429 418 -11
crossClusterReplication 121 110 -11
dashboard 680 669 -11
dataQuality 78 67 -11
dataUsage 130 119 -11
dataViewManagement 238 229 -9
devTools 31 20 -11
discover 974 966 -8
enterpriseSearch 2322 2313 -9
entityManagerApp 34 23 -11
exploratoryView 172 163 -9
filesManagement 188 177 -11
fleet 1245 1236 -9
graph 300 289 -11
home 257 246 -11
indexLifecycleManagement 252 241 -11
indexManagement 688 679 -9
infra 1525 1518 -7
ingestPipelines 343 332 -11
integrationAssistant 475 466 -9
inventory 247 238 -9
investigateApp 590 579 -11
kibanaOverview 127 116 -11
kubernetesSecurity 203 194 -9
lens 1507 1500 -7
licenseManagement 113 102 -11
logstash 63 52 -11
management 120 109 -11
maps 1250 1241 -9
ml 2120 2113 -7
monitoring 489 478 -11
observability 1061 1053 -8
observabilityAIAssistantApp 424 417 -7
observabilityAiAssistantManagement 395 388 -7
observabilityLogsExplorer 201 192 -9
observabilityOnboarding 251 242 -9
osquery 335 324 -11
profiling 302 291 -11
remoteClusters 113 102 -11
rollup 134 123 -11
savedObjectsManagement 112 101 -11
searchHomepage 142 131 -11
searchIndices 225 214 -11
searchInferenceEndpoints 249 240 -9
searchPlayground 259 248 -11
security 517 506 -11
securitySolution 6459 6451 -8
serverlessSearch 278 269 -9
slo 852 844 -8
snapshotRestore 199 188 -11
spaces 328 317 -11
streamsApp 189 178 -11
synthetics 1029 1020 -9
transform 478 471 -7
triggersActionsUi 856 847 -9
upgradeAssistant 159 148 -11
uptime 581 572 -9
ux 195 186 -9
visualizations 481 472 -9
watcher 177 166 -11
total -667

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 54 55 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 93.4KB 93.4KB -85.0B
alerting 97.7KB 94.3KB -3.3KB
apm 3.5MB 3.5MB -1.4KB
canvas 1.0MB 1.0MB -3.3KB
cases 535.5KB 533.0KB -2.5KB
cloudDefend 232.1KB 230.1KB -2.1KB
cloudSecurityPosture 501.1KB 499.2KB -2.0KB
console 207.7KB 204.4KB -3.4KB
crossClusterReplication 144.1KB 141.5KB -2.6KB
dashboard 634.0KB 630.7KB -3.3KB
dataQuality 26.1KB 22.8KB -3.3KB
dataUsage 240.7KB 237.3KB -3.4KB
dataViewManagement 138.3KB 136.1KB -2.1KB
devTools 5.8KB 2.4KB -3.4KB
discover 812.2KB 810.2KB -1.9KB
enterpriseSearch 2.6MB 2.6MB -2.0KB
entityManagerApp 9.9KB 9.8KB -87.0B
exploratoryView 181.0KB 178.9KB -2.1KB
filesManagement 123.5KB 120.9KB -2.6KB
fleet 1.9MB 1.9MB -6.7KB
graph 416.3KB 412.9KB -3.3KB
home 150.4KB 147.1KB -3.3KB
indexLifecycleManagement 163.9KB 160.6KB -3.3KB
indexManagement 701.7KB 699.6KB -2.1KB
infra 1.7MB 1.7MB +169.0B
ingestPipelines 407.1KB 403.8KB -3.3KB
integrationAssistant 880.8KB 877.6KB -3.2KB
inventory 231.8KB 231.7KB -88.0B
investigateApp 482.8KB 479.4KB -3.4KB
kibanaOverview 53.1KB 49.9KB -3.2KB
kubernetesSecurity 216.7KB 214.6KB -2.1KB
lens 1.5MB 1.5MB -1.7KB
licenseManagement 44.6KB 41.2KB -3.3KB
logstash 31.3KB 28.0KB -3.4KB
management 46.7KB 43.4KB -3.3KB
maps 3.0MB 3.0MB -3.3KB
ml 4.6MB 4.6MB -1.9KB
monitoring 535.3KB 531.9KB -3.4KB
observability 481.2KB 479.0KB -2.2KB
observabilityAIAssistantApp 295.2KB 295.2KB -85.0B
observabilityAiAssistantManagement 98.4KB 98.3KB -89.0B
observabilityLogsExplorer 145.8KB 142.0KB -3.8KB
observabilityOnboarding 281.5KB 279.4KB -2.1KB
osquery 1.0MB 1.0MB -3.3KB
profiling 404.2KB 404.1KB -86.0B
remoteClusters 77.4KB 74.5KB -2.9KB
rollup 113.7KB 110.7KB -3.1KB
savedObjectsManagement 85.1KB 81.8KB -3.4KB
searchHomepage 53.1KB 49.8KB -3.4KB
searchIndices 165.9KB 162.5KB -3.3KB
searchInferenceEndpoints 216.7KB 214.5KB -2.2KB
searchPlayground 161.3KB 158.0KB -3.4KB
security 541.6KB 541.6KB -26.0B
securitySolution 18.5MB 18.5MB -4.7KB
serverlessSearch 335.0KB 328.4KB -6.6KB
slo 835.1KB 831.5KB -3.7KB
snapshotRestore 261.1KB 257.7KB -3.3KB
spaces 256.8KB 256.8KB -18.0B
streamsApp 184.1KB 184.0KB -88.0B
synthetics 1.1MB 1.1MB -2.3KB
transform 473.7KB 471.9KB -1.7KB
triggersActionsUi 1.7MB 1.7MB -12.0KB
upgradeAssistant 158.4KB 155.1KB -3.3KB
uptime 465.6KB 463.5KB -2.1KB
ux 165.5KB 165.4KB -91.0B
visualizations 322.8KB 320.6KB -2.1KB
watcher 164.1KB 161.4KB -2.8KB
total -177.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
aiAssistantManagementSelection 4.7KB 4.7KB -5.0B
alerting 25.6KB 25.6KB -5.0B
apm 38.6KB 38.6KB -5.0B
canvas 14.6KB 14.6KB -5.0B
cases 161.6KB 161.6KB -5.0B
cloudDefend 9.0KB 9.0KB -5.0B
cloudSecurityPosture 17.9KB 17.9KB -5.0B
console 35.7KB 35.7KB -6.0B
core 450.9KB 447.5KB -3.4KB
crossClusterReplication 12.2KB 12.1KB -54.0B
dashboard 49.0KB 49.0KB -5.0B
dataQuality 8.3KB 8.2KB -54.0B
dataUsage 7.5KB 7.4KB -54.0B
dataViewManagement 5.2KB 5.1KB -5.0B
devTools 11.1KB 11.0KB -54.0B
discover 52.3KB 52.3KB -5.0B
enterpriseSearch 52.7KB 52.8KB +61.0B
entityManagerApp 4.9KB 4.9KB -63.0B
exploratoryView 43.9KB 43.9KB -5.0B
filesManagement 3.9KB 3.9KB -5.0B
fleet 170.9KB 170.9KB -13.0B
graph 8.0KB 8.0KB -5.0B
home 11.5KB 11.5KB -5.0B
indexLifecycleManagement 27.5KB 27.5KB -5.0B
indexManagement 44.3KB 44.3KB -5.0B
infra 56.0KB 56.0KB -5.0B
ingestPipelines 15.1KB 15.1KB -54.0B
integrationAssistant 10.4KB 10.4KB -55.0B
inventory 13.0KB 13.0KB -5.0B
investigateApp 11.1KB 11.1KB -5.0B
kbnUiSharedDeps-srcJs 3.5MB 3.5MB +4.2KB
kibanaOverview 15.1KB 15.1KB -5.0B
kubernetesSecurity 6.0KB 5.9KB -63.0B
lens 50.3KB 50.2KB -63.0B
licenseManagement 11.1KB 11.1KB -54.0B
logstash 14.1KB 14.1KB -5.0B
management 10.8KB 10.8KB -5.0B
maps 51.8KB 51.8KB -5.0B
ml 78.3KB 78.3KB -5.0B
monitoring 25.5KB 25.5KB -5.0B
observability 102.7KB 102.7KB -5.0B
observabilityAIAssistantApp 14.8KB 14.8KB -5.0B
observabilityAiAssistantManagement 5.1KB 5.1KB -5.0B
observabilityLogsExplorer 15.1KB 15.1KB -5.0B
observabilityOnboarding 10.3KB 10.4KB +59.0B
osquery 44.5KB 44.4KB -5.0B
profiling 17.6KB 17.6KB -5.0B
remoteClusters 9.0KB 9.0KB -54.0B
rollup 12.0KB 11.9KB -54.0B
savedObjectsManagement 19.8KB 19.8KB -5.0B
searchHomepage 4.7KB 4.6KB -113.0B
searchIndices 7.5KB 7.5KB -55.0B
searchInferenceEndpoints 6.8KB 6.8KB -5.0B
searchPlayground 6.9KB 6.9KB +61.0B
security 66.5KB 62.8KB -3.7KB
securitySolution 86.6KB 86.6KB +61.0B
serverlessSearch 21.8KB 21.8KB -6.0B
slo 29.6KB 29.6KB -5.0B
snapshotRestore 27.1KB 27.1KB -5.0B
spaces 32.3KB 29.0KB -3.3KB
streamsApp 5.4KB 5.4KB -5.0B
synthetics 37.6KB 37.6KB -5.0B
transform 18.4KB 18.3KB -5.0B
triggersActionsUi 126.9KB 126.9KB -13.0B
upgradeAssistant 22.6KB 22.6KB -5.0B
uptime 22.7KB 22.7KB -5.0B
ux 6.8KB 6.8KB -5.0B
visualizations 62.3KB 62.3KB -5.0B
watcher 13.5KB 13.5KB -54.0B
total -7.1KB
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 63 64 +1

async chunk count

id before after diff
fleet 10 9 -1
triggersActionsUi 65 64 -1
total -2

@Dosant Dosant merged commit 13aed70 into elastic:8.x Dec 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eokoneyo eokoneyo eokoneyo approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dosant @elasticmachine @eokoneyo