Skip to content

[Obs AI Assistant] Add route privilege tests for Serverless#205210

Merged
viduni94 merged 4 commits intoelastic:mainfrom
viduni94:add-route-privilege-tests-to-serverless
Jan 3, 2025
Merged

[Obs AI Assistant] Add route privilege tests for Serverless#205210
viduni94 merged 4 commits intoelastic:mainfrom
viduni94:add-route-privilege-tests-to-serverless

Conversation

@viduni94
Copy link
Copy Markdown
Contributor

@viduni94 viduni94 commented Dec 27, 2024 •
edited by kibanamachine
Loading

Closes #204884

Summary

This PR adds security and route privilege tests to the serverless test suite.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@viduni94 viduni94 added release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v8.18.0 labels Dec 27, 2024
@viduni94 viduni94 self-assigned this Dec 27, 2024
@viduni94 viduni94 requested a review from a team as a code owner December 27, 2024 15:10
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 27, 2024

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@viduni94 viduni94 linked an issue Dec 27, 2024 that may be closed by this pull request
[Obs AI Assistant] Route access privilege tests for serverless #204884
Closed
@viduni94 viduni94 force-pushed the add-route-privilege-tests-to-serverless branch from ed525be to c085431 Compare December 27, 2024 15:15
dgieselaar
dgieselaar reviewed Dec 30, 2024
View reviewed changes
...st_serverless/api_integration/test_suites/observability/ai_assistant/tests/chat/chat.spec.ts Outdated
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we skip this?

Copy link
Copy Markdown
Contributor Author

@viduni94 viduni94 Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was skipped as part of the migration to inference endpoints. The discussion thread can be found here - https://github.com/elastic/kibana/pull/199286/files#r1867485436

@viduni94 viduni94 force-pushed the add-route-privilege-tests-to-serverless branch from c085431 to 8852cdc Compare December 30, 2024 13:50
@viduni94 viduni94 requested a review from dgieselaar December 30, 2024 14:18
@viduni94 viduni94 force-pushed the add-route-privilege-tests-to-serverless branch from 21f980b to df3715d Compare January 2, 2025 12:10
@neptunian neptunian mentioned this pull request Jan 2, 2025
Merged
7 tasks
@viduni94 viduni94 force-pushed the add-route-privilege-tests-to-serverless branch from 493d171 to 6beb135 Compare January 3, 2025 13:32
@viduni94 viduni94 removed the request for review from dgieselaar January 3, 2025 13:33
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 3, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #263360 succeeded 21f980b4eafaf07b4613d69fedb86aaf9f4ffba8
  • 💚 Build #263163 succeeded c0854315e2fc3c1e9d9ed59fe6cb00a2b81012c1

cc @viduni94

@viduni94 viduni94 merged commit 7d76276 into elastic:main Jan 3, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 3, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12600593509

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 3, 2025
@viduni94
[Obs AI Assistant] Add route privilege tests for Serverless (elastic#…
50f3c41 
…205210)

Closes elastic#204884

## Summary

This PR adds security and route privilege tests to the serverless test
suite.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 7d76276)
@kibanamachine kibanamachine mentioned this pull request Jan 3, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 3, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 3, 2025
@kibanamachine @viduni94
[8.x] [Obs AI Assistant] Add route privilege tests for Serverless (#2…
8365450 
…05210) (#205517)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Add route privilege tests for Serverless
(#205210)](#205210)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-01-03T16:17:43Z","message":"[Obs
AI Assistant] Add route privilege tests for Serverless
(#205210)\n\nCloses
https://github.com/elastic/kibana/issues/204884\n\n## Summary\n\nThis PR
adds security and route privilege tests to the serverless
test\nsuite.\n\n### Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7d76276d8b1988599916f59052f7ebd9e815a3c5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs
AI Assistant","backport:version","v8.18.0"],"title":"[Obs AI Assistant]
Add route privilege tests for
Serverless","number":205210,"url":"https://github.com/elastic/kibana/pull/205210","mergeCommit":{"message":"[Obs
AI Assistant] Add route privilege tests for Serverless
(#205210)\n\nCloses
https://github.com/elastic/kibana/issues/204884\n\n## Summary\n\nThis PR
adds security and route privilege tests to the serverless
test\nsuite.\n\n### Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7d76276d8b1988599916f59052f7ebd9e815a3c5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205210","number":205210,"mergeCommit":{"message":"[Obs
AI Assistant] Add route privilege tests for Serverless
(#205210)\n\nCloses
https://github.com/elastic/kibana/issues/204884\n\n## Summary\n\nThis PR
adds security and route privilege tests to the serverless
test\nsuite.\n\n### Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7d76276d8b1988599916f59052f7ebd9e815a3c5"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
viduni94 added a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@viduni94
[Obs AI Assistant] Add route privilege tests for Serverless (elastic#…
122bf5b 
…205210)

Closes elastic#204884

## Summary

This PR adds security and route privilege tests to the serverless test
suite.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neptunian neptunian neptunian approved these changes

+2 more reviewers

@dgieselaar dgieselaar dgieselaar left review comments

@sorenlouv sorenlouv sorenlouv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@viduni94 viduni94

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Route access privilege tests for serverless

6 participants

@viduni94 @elasticmachine @kibanamachine @sorenlouv @dgieselaar @neptunian