Enable execution context tracking for SLO, infra and synthetics plugins#204939
Merged
maryam-saeidi merged 5 commits intoelastic:mainfrom Jan 3, 2025
Merged
Conversation
maryam-saeidi
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
commented
Dec 19, 2024
| {settingsTabTitle} | ||
| </EuiHeaderLink> | ||
| <Routes> | ||
| <Routes enableExecutionContextTracking={true}> |
Member
Author
There was a problem hiding this comment.
I am not sure what the difference is between routes on this file. Can someone please check one route from each category and verify if it works as expected?
kdelemme
approved these changes
Dec 19, 2024
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
SLO changes LGTM. I noticed in your screenshot the page_url includes the kibana host prefix, while it was not included before. Is that expected?
Member
Author
Good point, my changes shouldn't have an impact there; maybe @Dosant or @afharo have an idea about this. |
Contributor
Have no idea from the top of my head, need to debug. What I find strange is that on the screenshots SLO and Synthetics have the basePath in page_url, but Infra > Inventory and Infra > Hosts don't. I'd expect these at least to be consistent. It might be that this inconsistency is coming from tracking on different routes-nesting levels, might be worth looking into it to find out what is the difference and if this can be consistent. |
Member
Author
crespocarlos
reviewed
Jan 2, 2025
x-pack/solutions/observability/plugins/infra/public/pages/metrics/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/observability/plugins/infra/public/pages/metrics/index.tsx
Outdated
Show resolved
Hide resolved
crespocarlos
approved these changes
Jan 2, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12595107190 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…ns (elastic#204939) ## Summary This PR enables default execution context tracking (which was added in this [PR](elastic#204547)) for the following plugins: - SLO - Infra - Synthetics |Plugin|Before|After| |---|---|---| |SLO||| |Synthetics||| |Infra > Inventory||| |Infra > Hosts||| (cherry picked from commit 2e92018)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
… plugins (#204939) (#205474) # Backport This will backport the following commits from `main` to `8.x`: - [Enable execution context tracking for SLO, infra and synthetics plugins (#204939)](#204939) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2025-01-03T08:45:21Z","message":"Enable execution context tracking for SLO, infra and synthetics plugins (#204939)\n\n## Summary\r\n\r\nThis PR enables default execution context tracking (which was added in\r\nthis [PR](#204547)) for the\r\nfollowing plugins:\r\n\r\n- SLO\r\n- Infra\r\n- Synthetics\r\n\r\n|Plugin|Before|After|\r\n|---|---|---|\r\n\r\n|SLO|||\r\n\r\n|Synthetics|||\r\n|Infra >\r\nInventory|||\r\n|Infra >\r\nHosts|||","sha":"2e9201855392894ff3de5c765c263ac69d1214d0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"Enable execution context tracking for SLO, infra and synthetics plugins","number":204939,"url":"https://github.com/elastic/kibana/pull/204939","mergeCommit":{"message":"Enable execution context tracking for SLO, infra and synthetics plugins (#204939)\n\n## Summary\r\n\r\nThis PR enables default execution context tracking (which was added in\r\nthis [PR](#204547)) for the\r\nfollowing plugins:\r\n\r\n- SLO\r\n- Infra\r\n- Synthetics\r\n\r\n|Plugin|Before|After|\r\n|---|---|---|\r\n\r\n|SLO|||\r\n\r\n|Synthetics|||\r\n|Infra >\r\nInventory|||\r\n|Infra >\r\nHosts|||","sha":"2e9201855392894ff3de5c765c263ac69d1214d0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204939","number":204939,"mergeCommit":{"message":"Enable execution context tracking for SLO, infra and synthetics plugins (#204939)\n\n## Summary\r\n\r\nThis PR enables default execution context tracking (which was added in\r\nthis [PR](#204547)) for the\r\nfollowing plugins:\r\n\r\n- SLO\r\n- Infra\r\n- Synthetics\r\n\r\n|Plugin|Before|After|\r\n|---|---|---|\r\n\r\n|SLO|||\r\n\r\n|Synthetics|||\r\n|Infra >\r\nInventory|||\r\n|Infra >\r\nHosts|||","sha":"2e9201855392894ff3de5c765c263ac69d1214d0"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…ns (elastic#204939) ## Summary This PR enables default execution context tracking (which was added in this [PR](elastic#204547)) for the following plugins: - SLO - Infra - Synthetics |Plugin|Before|After| |---|---|---| |SLO||| |Synthetics||| |Infra > Inventory||| |Infra > Hosts|||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables default execution context tracking (which was added in this PR) for the following plugins: