[Security Solution][threat hunting explore] EUI refresh: Rename color variables#204908
Merged
angorayc merged 20 commits intoelastic:mainfrom Jan 9, 2025
Merged
[Security Solution][threat hunting explore] EUI refresh: Rename color variables#204908angorayc merged 20 commits intoelastic:mainfrom
angorayc merged 20 commits intoelastic:mainfrom
Conversation
angorayc
added
Team:Threat Hunting:Explore
EUI Visual Refresh
backport:skip
mgadewoll
reviewed
Dec 19, 2024
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
ℹ️ Adding an early review due to upcoming PTO
...ity_solution/public/onboarding/components/onboarding_header/cards/common/link_card.styles.ts
Outdated
Show resolved
Hide resolved
...ns/security/plugins/security_solution/public/common/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
mgadewoll
reviewed
Jan 8, 2025
...ns/security/plugins/security_solution/public/common/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
mgadewoll
reviewed
Jan 8, 2025
...ns/security/plugins/security_solution/public/common/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed
Failed CI StepsHistory
|
mgadewoll
approved these changes
Jan 8, 2025
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
✅ Thanks for the additional updates! Changes LGTM me from EUI side.
I left one small non-blocking suggestion, if you still feel like updating 😅
...ty_solution/public/onboarding/components/onboarding_body/cards/common/card_callout.styles.ts
Outdated
Show resolved
Hide resolved
agusruidiazgd
approved these changes
Jan 9, 2025
Contributor
agusruidiazgd
left a comment
agusruidiazgd
left a comment
There was a problem hiding this comment.
LGTM, thanks Angela!!
|
LGTM Thank you! From our review sync: We need an option for illustrated icons for dark theme. This work will be in separate issue. |
Zacqary
pushed a commit
to Zacqary/kibana
that referenced
this pull request
Jan 9, 2025
… variables (elastic#204908) ## Summary elastic#202499 ### Running Kibana with the Borealis theme In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
… variables (elastic#204908) ## Summary elastic#202499 ### Running Kibana with the Borealis theme In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 12, 2025
… variables (elastic#204908) elastic#202499 In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0c0dd63)
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 12, 2025
… variables (elastic#204908) elastic#202499 In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0c0dd63)
angorayc
added
backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#202499
Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:
Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true
Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start
This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.