Skip to content

[Security Solution] Reviewing rules for upgrading test plan and test coverage#204765

Closed
jpdjere wants to merge 13 commits intoelastic:mainfrom
jpdjere:test-plans-for-review
Closed

[Security Solution] Reviewing rules for upgrading test plan and test coverage#204765
jpdjere wants to merge 13 commits intoelastic:mainfrom
jpdjere:test-plans-for-review

Conversation

@jpdjere
Copy link
Copy Markdown
Contributor

@jpdjere jpdjere commented Dec 18, 2024

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@elasticmachine
Copy link
Copy Markdown
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@jpdjere jpdjere changed the title [Security Solution] Reviewing rules for upgrading test plan [Security Solution] Reviewing rules for upgrading test plan and test coverage Dec 24, 2024
@jpdjere
Copy link
Copy Markdown
Contributor Author

jpdjere commented Dec 27, 2024

Closing in favour of: #205217

@jpdjere jpdjere closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants