[8.x] [kbn-test] add forceNewSession option to re-generate session cookie (#199018)#204583
Merged
stephmilovic merged 1 commit intoelastic:8.xfrom Dec 18, 2024
Merged
Conversation
Contributor
|
Please do not merge this pull request. We disabled auto-merge because we are trying to merge a this big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info. |
Contributor
|
Auto-merge has been re-enabled. Thank you for your patience. :heart |
…lastic#199018) ## Summary Currently FTR caches `Cookies` of Cloud SAML sessions for the complete FTR config run, meaning we only perform actual login once for the specified role. It helps to optimise tests run time and improve stability. While it works most of the time, according to https://github.com/elastic/kibana/issues/71866 Reporting test suite stability depends on token validity (`20m`) and to stabilize it, this PR adds `forceNewSession` option to force request a new SAML session when it is required for specific tests. ``` cookieCredentials = await samlAuth.getM2MApiCookieCredentialsWithRoleScope('admin', { forceNewSession: true, }); ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7608d76) # Conflicts: # packages/kbn-test/index.ts # x-pack/test_serverless/api_integration/test_suites/common/reporting/datastream.ts # x-pack/test_serverless/api_integration/test_suites/common/reporting/generate_csv_discover.ts
dmlemeshko
force-pushed
the
backport/8.x/pr-199018
branch
from
fc99dd8 to
eef56e9
Compare
pheyos
approved these changes
Dec 18, 2024
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation