[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` (#202851) by stephmilovic · Pull Request #204518 · elastic/kibana

stephmilovic · 2024-12-17T05:12:15Z

Backport

This will backport the following commits from main to 8.x:

Sustainable Kibana Architecture: Move modules owned by @elastic/security-solution (#202851)

Questions ?

Please refer to the Backport tool documentation

…rity-solution` (elastic#202851) (cherry picked from commit da25d13) # Conflicts: # .buildkite/scripts/pipelines/pull_request/pipeline.ts # .github/CODEOWNERS # oas_docs/scripts/merge_serverless_oas.js # x-pack/.i18nrc.json # x-pack/packages/kbn-ai-assistant-common/jest.config.js # x-pack/plugins/enterprise_search/public/applications/app_search/components/error_connecting/index.ts # x-pack/plugins/enterprise_search/public/applications/workplace_search/views/error_state/index.ts # x-pack/plugins/security_solution/public/one_discover/cell_renderers/index.ts # x-pack/plugins/security_solution/public/one_discover/constants.ts # x-pack/plugins/security_solution/public/one_discover/index.tsx # x-pack/plugins/security_solution/public/one_discover/jest.config.js # x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json # x-pack/plugins/telemetry_collection_xpack/schema/xpack_security.json # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/actions/action_log/deprecated_action_log.gen.ts # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/actions/action_log/deprecated_action_log.schema.yaml # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/actions/response_actions/isolate/deprecated_isolate.gen.ts # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/actions/response_actions/isolate/deprecated_isolate.schema.yaml # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/actions/response_actions/unisolate/deprecated_unisolate.gen.ts # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/actions/response_actions/unisolate/deprecated_unisolate.schema.yaml # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/policy/deprecated_agent_policy_summary.gen.ts # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/policy/deprecated_agent_policy_summary.schema.yaml # x-pack/solutions/security/plugins/security_solution/common/api/endpoint/policy/deprecated_agent_policy_summary.ts # x-pack/solutions/security/plugins/security_solution/common/api/entity_analytics/risk_engine/engine_configure_saved_object_route.gen.ts # x-pack/solutions/security/plugins/security_solution/common/api/entity_analytics/risk_engine/engine_configure_saved_object_route.schema.yaml # x-pack/solutions/security/plugins/security_solution/common/endpoint/utils/index_name_utilities.test.ts # x-pack/solutions/security/plugins/security_solution/common/endpoint/utils/index_name_utilities.ts # x-pack/solutions/security/plugins/security_solution/public/common/hooks/is_in_security_app.ts # x-pack/solutions/security/plugins/security_solution/public/dashboards/jest.config.js # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/api/hooks/use_configure_risk_engine_saved_object.ts # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/__snapshots__/risk_score_configuration_section.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/risk_score_configuration_section.test.tsx # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/risk_score_configuration_section.tsx # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/risk_score_page_styles.tsx # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/risk_score_useful_links_section.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/shared/hooks/use_navigate_to_left_panel.test.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/shared/hooks/use_navigate_to_left_panel.tsx # x-pack/solutions/security/plugins/security_solution/public/kubernetes/pages/utils/data_view_spec_to_index_pattern.ts # x-pack/solutions/security/plugins/security_solution/public/one_discover/app_wrapper/index.tsx # x-pack/solutions/security/plugins/security_solution/public/one_discover/cell_renderers/cell_renderer.test.tsx # x-pack/solutions/security/plugins/security_solution/public/one_discover/cell_renderers/cell_renderers.tsx # x-pack/solutions/security/plugins/security_solution/public/one_discover/cell_renderers/index.ts # x-pack/solutions/security/plugins/security_solution/public/one_discover/constants.ts # x-pack/solutions/security/plugins/security_solution/public/one_discover/index.tsx # x-pack/solutions/security/plugins/security_solution/scripts/run_cypress/utils.ts # x-pack/solutions/security/plugins/security_solution/server/endpoint/migrations/ensure_indices_exists_for_policies.test.ts # x-pack/solutions/security/plugins/security_solution/server/endpoint/migrations/ensure_indices_exists_for_policies.ts # x-pack/solutions/security/plugins/security_solution/server/endpoint/routes/actions/audit_log.test.ts # x-pack/solutions/security/plugins/security_solution/server/endpoint/routes/actions/audit_log.ts # x-pack/solutions/security/plugins/security_solution/server/endpoint/routes/actions/audit_log_handler.ts # x-pack/solutions/security/plugins/security_solution/server/endpoint/services/actions/actions_audit_log.ts # x-pack/solutions/security/plugins/security_solution/server/lib/entity_analytics/risk_engine/routes/configure_saved_object.test.ts # x-pack/solutions/security/plugins/security_solution/server/lib/entity_analytics/risk_engine/routes/configure_saved_object.ts # x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/README.md # x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/enablement_modal_callout.tsx # x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/index.tsx # x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/lazy.tsx # x-pack/solutions/security/plugins/security_solution_serverless/server/common/services/index.ts # x-pack/solutions/security/plugins/security_solution_serverless/server/common/services/usage_reporting_service.test.ts

elasticmachine · 2024-12-17T05:12:22Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2024-12-17T05:12:23Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

github-actions · 2024-12-17T05:12:29Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

…PR that was not backported

…fix'

elasticmachine · 2024-12-17T07:35:43Z

💔 Build Failed

Buildkite Build
Commit: 9a7bdf5

Failed CI Steps

History

PhilippeOberti · 2024-12-17T08:45:02Z

This backport PR keeps failing because we have a bunch of PRs have been merged to main but not backported. Some of them on purpose, and some where the backport has not been merged yet.
Here’s a non-exhaustive list of PR that were not backported and are causing issues:

[Security Solution] Add Host/User flyout in One Discover. #199279
[Entity Analytics][UI] UI changes for Risk Engine to include closed alerts for risk score calculation #201909
[Security Solution] Add callout to promote blog post #195943
maybe this one [Search][Ent Search deprecation] Removing errors #202437
And here’s the list of backport that are ready but not merged yet:
[8.x] [Security Solution][Endpoint] Cypress test improvements to capture Agent diagnostics file when test fails (#202965) #204485

stephmilovic · 2024-12-17T14:45:30Z

Closing in favor of #204523

stephmilovic requested a review from kibanamachine as a code owner December 17, 2024 05:12

stephmilovic added the backport This PR is a backport of another PR label Dec 17, 2024

stephmilovic enabled auto-merge (squash) December 17, 2024 05:12

botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Dec 17, 2024

stephmilovic mentioned this pull request Dec 17, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/security-solution #202851

Merged

PhilippeOberti approved these changes Dec 17, 2024

View reviewed changes

kibanamachine and others added 10 commits December 17, 2024 05:23

[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'

1a1690a

[CI] Auto-commit changed files from 'yarn openapi:bundle'

43e5ebf

[CI] Auto-commit changed files from 'make api-docs'

cd0316a

fix i18n translations

95bbe7b

remove files left behind in the old security_solution folder, from a …

ef6ca06

…PR that was not backported

fix jest.config broken during merge

189c1a9

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

1ec0132

…fix'

[CI] Auto-commit changed files from 'yarn openapi:generate'

308a4ad

fix telemetry by running node scripts/telemetry_check --fix command

77d62f8

remove code that has not been backported yet (PR open elastic#204485)

9a7bdf5

stephmilovic closed this Dec 17, 2024

auto-merge was automatically disabled December 17, 2024 14:45
Pull request was closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` (#202851)#204518

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` (#202851)#204518
stephmilovic wants to merge 11 commits intoelastic:8.xfrom
stephmilovic:backport/8.x/pr-202851

stephmilovic commented Dec 17, 2024

Uh oh!

elasticmachine commented Dec 17, 2024

Uh oh!

elasticmachine commented Dec 17, 2024

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

elasticmachine commented Dec 17, 2024 •

edited

Loading

Uh oh!

PhilippeOberti commented Dec 17, 2024

Uh oh!

stephmilovic commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

stephmilovic commented Dec 17, 2024

Backport

Questions ?

Uh oh!

elasticmachine commented Dec 17, 2024

Uh oh!

elasticmachine commented Dec 17, 2024

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

elasticmachine commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

PhilippeOberti commented Dec 17, 2024

Uh oh!

stephmilovic commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

elasticmachine commented Dec 17, 2024 •

edited

Loading