Skip to content

[Fleet] Bump install version after removal of deprecated _source.mode…#204471

Merged
nchaulet merged 3 commits intoelastic:mainfrom
nchaulet:bump-fleet-install-version
Dec 17, 2024
Merged

[Fleet] Bump install version after removal of deprecated _source.mode…#204471
nchaulet merged 3 commits intoelastic:mainfrom
nchaulet:bump-fleet-install-version

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Dec 16, 2024 •
edited by kibanamachine
Loading

Description

Following https://github.com/elastic/kibana/pull/202729/files

That PR bump the install version of package, so every packages are reinstalled on setup, and the new index template do not contains the deprecated _source.mode:synthetic value.

@kpollich I tested manually the upgrade and it seems the upgrade assistant still show cirtical issues for old backing index of datastreams
@martijnvg what will be the way to properly fix datastreams here?

Screenshot 2024-12-16 at 1 48 12 PM

@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor v8.18.0 labels Dec 16, 2024
@nchaulet nchaulet self-assigned this Dec 16, 2024
@nchaulet nchaulet requested a review from a team as a code owner December 16, 2024 18:53
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2024

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / Tags when list is long renders a truncated list of tags with full list displayed in tooltip on hover
  • [job] [logs] Jest Tests #16 / updateLatestExecutedState Should call packagePolicy upgrade if keep_policies_up_to_date = true
  • [job] [logs] Jest Tests #16 / updateLatestExecutedState Should call packagePolicy upgrade if keep_policies_up_to_date = true
  • [job] [logs] Jest Tests #16 / updateLatestExecutedState Should save the SO and should not call packagePolicy upgrade if keep_policies_up_to_date = false
  • [job] [logs] Jest Tests #16 / updateLatestExecutedState Should save the SO and should not call packagePolicy upgrade if keep_policies_up_to_date = false

Metrics [docs]

✅ unchanged

History

cc @nchaulet

@martijnvg
Copy link
Copy Markdown
Member

martijnvg commented Dec 17, 2024

@nchaulet I think the intent was that the deprecation warning would only appear for new indices being created with _source.mode mapping attribute. Let me look into this.

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Dec 17, 2024
@nchaulet nchaulet enabled auto-merge (squash) December 17, 2024 15:10
@nchaulet nchaulet merged commit 348ea81 into elastic:main Dec 17, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 17, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @nchaulet

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 17, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12376353560

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 17, 2024
@nchaulet
[Fleet] Bump install version after removal of deprecated _source.mode… (
135a4a7 
elastic#204471)

(cherry picked from commit 348ea81)
@kibanamachine kibanamachine mentioned this pull request Dec 17, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 17, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Dec 17, 2024
Merged
4 tasks
stephmilovic pushed a commit that referenced this pull request Dec 17, 2024
@kibanamachine @nchaulet
[8.x] [Fleet] Bump install version after removal of deprecated _sourc…
442d5f2 
…e.mode… (#204471) (#204604)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Bump install version after removal of deprecated
_source.mode… (#204471)](#204471)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T15:39:08Z","message":"[Fleet]
Bump install version after removal of deprecated _source.mode…
(#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[Fleet]
Bump install version after removal of deprecated
_source.mode…","number":204471,"url":"https://github.com/elastic/kibana/pull/204471","mergeCommit":{"message":"[Fleet]
Bump install version after removal of deprecated _source.mode…
(#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204471","number":204471,"mergeCommit":{"message":"[Fleet]
Bump install version after removal of deprecated _source.mode…
(#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nchaulet @JoseLuisGJ
[Fleet] Bump install version after removal of deprecated _source.mode… (
592dbc5 
elastic#204471)
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@nchaulet @benakansara
[Fleet] Bump install version after removal of deprecated _source.mode… (
0325a3d 
elastic#204471)
nchaulet added a commit to nchaulet/kibana that referenced this pull request Jan 10, 2025
@nchaulet
[Fleet] Bump install version after removal of deprecated _source.mode… (
34a00b2 
elastic#204471)

(cherry picked from commit 348ea81)
@nchaulet nchaulet mentioned this pull request Jan 10, 2025
Merged
@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Jan 10, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nchaulet added a commit that referenced this pull request Jan 10, 2025
@nchaulet
[8.17] [Fleet] Bump install version after removal of deprecated _sour…
cb2209e 
…ce.mode… (#204471) (#206336)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Fleet] Bump install version after removal of deprecated
_source.mode… (#204471)](#204471)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T15:39:08Z","message":"[Fleet]
Bump install version after removal of deprecated _source.mode…
(#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.18.0","v8.17.1","backport:8.17"],"number":204471,"url":"https://github.com/elastic/kibana/pull/204471","mergeCommit":{"message":"[Fleet]
Bump install version after removal of deprecated _source.mode…
(#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204471","number":204471,"mergeCommit":{"message":"[Fleet]
Bump install version after removal of deprecated _source.mode…
(#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/204604","number":204604,"state":"MERGED","mergeCommit":{"sha":"442d5f2b863967fdca5c2404ff84058e76f3f12c","message":"[8.x]
[Fleet] Bump install version after removal of deprecated _source.mode…
(#204471) (#204604)\n\n# Backport\r\n\r\nThis will backport the
following commits from `main` to `8.x`:\r\n- [[Fleet] Bump install
version after removal of deprecated\r\n_source.mode…
(#204471)](https://github.com/elastic/kibana/pull/204471)\r\n\r\n<!---
Backport version: 9.4.3 -->\r\n\r\n### Questions ?\r\nPlease refer to
the [Backport
tool\r\ndocumentation](https://github.com/sqren/backport)\r\n\r\n<!--BACKPORT
[{\"author\":{\"name\":\"Nicolas\r\nChaulet\",\"email\":\"nicolas.chaulet@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-12-17T15:39:08Z\",\"message\":\"[Fleet]\r\nBump
install version after removal of deprecated
_source.mode…\r\n(#204471)\",\"sha\":\"348ea81b1e85e846c855635c51e4e7fc3136bda1\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:Fleet\",\"v9.0.0\",\"backport:prev-minor\",\"v8.18.0\"],\"title\":\"[Fleet]\r\nBump
install version after removal of
deprecated\r\n_source.mode…\",\"number\":204471,\"url\":\"https://github.com/elastic/kibana/pull/204471\",\"mergeCommit\":{\"message\":\"[Fleet]\r\nBump
install version after removal of deprecated
_source.mode…\r\n(#204471)\",\"sha\":\"348ea81b1e85e846c855635c51e4e7fc3136bda1\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/204471\",\"number\":204471,\"mergeCommit\":{\"message\":\"[Fleet]\r\nBump
install version after removal of deprecated
_source.mode…\r\n(#204471)\",\"sha\":\"348ea81b1e85e846c855635c51e4e7fc3136bda1\"}},{\"branch\":\"8.x\",\"label\":\"v8.18.0\",\"branchLabelMappingKey\":\"^v8.18.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\r\nBACKPORT-->\r\n\r\nCo-authored-by:
Nicolas Chaulet
<nicolas.chaulet@elastic.co>"}},{"branch":"8.17","label":"v8.17.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@mistic mistic added v8.17.2 and removed v8.17.1 labels Jan 21, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@nchaulet @viduni94
[Fleet] Bump install version after removal of deprecated _source.mode… (
66f6ba5 
elastic#204471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.17.2 v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nchaulet @elasticmachine @martijnvg @kibanamachine @juliaElastic @mistic