Skip to content

[8.x] [Embeddables Rebuild] Make Serialize Function Synchronous (#203662)#204470

Merged
stephmilovic merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-203662
Dec 17, 2024
Merged

[8.x] [Embeddables Rebuild] Make Serialize Function Synchronous (#203662)#204470
stephmilovic merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-203662

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Dec 16, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) December 16, 2024 18:50
…3662)

changes the signature of the `serializeState` function so that
it no longer returns MaybePromise

(cherry picked from commit abfd590)
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 16, 2024
@kapral18
Copy link
Copy Markdown
Contributor

Please do not merge this pull request. We disabled auto-merge because we are trying to merge a this big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info.

@kapral18 kapral18 disabled auto-merge December 17, 2024 16:39
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 632.9KB 632.7KB -206.0B
discover 813.7KB 813.8KB +109.0B
links 53.0KB 53.0KB -5.0B
total -102.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 51.8KB 51.8KB -15.0B
discover 52.3KB 52.3KB +56.0B
embeddable 55.7KB 55.5KB -140.0B
total -99.0B

cc @ThomThomson

@ThomThomson
Copy link
Copy Markdown
Contributor

@kapral18, thanks for the heads up! Let me know when I'm able to merge.

@kapral18
Copy link
Copy Markdown
Contributor

Auto-merge has been re-enabled. Thank you for your patience. :heart

@stephmilovic stephmilovic merged commit 0862bde into elastic:8.x Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Feature:Embedding Embedding content via iFrame

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants