[Dashboard] EUI Visual Refresh Integration by cqliu1 · Pull Request #204442 · elastic/kibana

cqliu1 · 2024-12-16T16:41:33Z

Summary

Related to #203132.

Part of #204590.

This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the dashboard plugin. This also updates the color of the presentational panel border in edit mode from mediumShade, which was deprecated, to BorderBaseFormsControl as the darker border color.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

.../presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx

mgadewoll · 2024-12-17T08:35:02Z

.../presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx

      (rightHoverActionsRef.current?.offsetWidth ?? 0) +
      (dragHandleRef.current?.offsetWidth ?? 0) +
-      parseInt(euiThemeVars.euiSize, 10) * 2;
+      parseInt(euiTheme.size.m, 10) * 2;


This should probably be euiTheme.size.base as euiSize was 16px and euiTheme.size.m is 12px
(same for the following occurrences)

📖 size docs, migration overview

.../presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx

mgadewoll · 2024-12-17T08:38:41Z

.../presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx

            display: flex;
            justify-content: space-between;
-            padding: 0 ${euiThemeVars.euiSize};
+            padding: 0 ${euiTheme.size.medium};


Blocking euiTheme.size.medium does not exists. Based on the original value, this likely should be euiTheme.size.base.

elasticmachine · 2024-12-17T18:53:36Z

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese · 2024-12-17T19:29:07Z

.../presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx

+
+  const { euiTheme } = useEuiTheme();
+
+  const EDIT_MODE_OUTLINE = `${euiTheme.border.width.thin} dashed ${euiTheme.colors.borderBaseFormsControl}`;


Can you use useMemo to avoid recreating these string on each render.

I think useMemo usage is best left to things which are expensive to compute. useMemo itself can introduce overhead .

…://github.com/cqliu1/kibana into borealis/dashboard/replace-euiThemeVars-usage

mgadewoll

✅ Changes LGTM from EUI side

elasticmachine · 2024-12-18T20:21:54Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 561487c

Failed CI Steps

Jest Tests #12

Test Failures

[job] [logs] Jest Tests #12 / UserCommentPropertyActions renders the correct number of actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`presentationPanel`	15.8KB	15.6KB	-132.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`presentationPanel`	44.0KB	43.9KB	-33.0B

History

💔 Build #261548 failed c39729e

kibanamachine · 2024-12-20T21:48:41Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204442 locally

kibanamachine · 2024-12-23T21:49:02Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204442 locally

kibanamachine · 2024-12-24T21:51:31Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204442 locally

kibanamachine · 2024-12-25T22:48:42Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204442 locally

## Summary Related to elastic#203132. Closes elastic#204590. This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the dashboard plugin. This also updates ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2025-01-23T18:42:34Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12935889514

kibanamachine · 2025-01-23T18:48:06Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204442

Questions ?

Please refer to the Backport tool documentation

mgadewoll · 2025-01-24T09:18:38Z

@cqliu1 Generally we don't expect Borealis changes to be backported.

kibanamachine · 2025-01-27T18:49:14Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204442 locally

cqliu1 · 2025-01-28T00:10:48Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary Related to elastic#203132. Closes elastic#204590. This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the dashboard plugin. This also updates ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 4a6e1e5) # Conflicts: # src/platform/plugins/private/presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx # src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel.tsx

kibanamachine · 2025-01-28T19:52:43Z