[Discover] Fix console warning for invalid DOM property#204417
Merged
acstll merged 1 commit intoelastic:mainfrom Dec 17, 2024
Merged
[Discover] Fix console warning for invalid DOM property#204417acstll merged 1 commit intoelastic:mainfrom
acstll merged 1 commit intoelastic:mainfrom
Conversation
jughosta
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
💚 Build Succeeded
Metrics [docs]
|
kertal
added
the
Feature:UnifiedDocViewer
akowalska622
approved these changes
Dec 17, 2024
Contributor
akowalska622
left a comment
akowalska622
left a comment
There was a problem hiding this comment.
Looks good to me, Arturo!
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12376540392 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
Fixes one of the errors described in elastic#202287 — namely a console warning due to invalid DOM property. (cherry picked from commit 59826cc)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
4 tasks
stephmilovic
pushed a commit
that referenced
this pull request
Dec 17, 2024
… (#204605) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Fix console warning for invalid DOM property (#204417)](#204417) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Arturo Castillo Delgado","email":"arturo.castillo@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T15:49:36Z","message":"[Discover] Fix console warning for invalid DOM property (#204417)\n\nFixes one of the errors described in #202287 — namely a console warning\r\ndue to invalid DOM property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:UnifiedDocViewer"],"title":"[Discover] Fix console warning for invalid DOM property","number":204417,"url":"https://github.com/elastic/kibana/pull/204417","mergeCommit":{"message":"[Discover] Fix console warning for invalid DOM property (#204417)\n\nFixes one of the errors described in #202287 — namely a console warning\r\ndue to invalid DOM property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204417","number":204417,"mergeCommit":{"message":"[Discover] Fix console warning for invalid DOM property (#204417)\n\nFixes one of the errors described in #202287 — namely a console warning\r\ndue to invalid DOM property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21"}}]}] BACKPORT--> Co-authored-by: Arturo Castillo Delgado <arturo.castillo@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
Fixes one of the errors described in elastic#202287 — namely a console warning due to invalid DOM property.
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
Fixes one of the errors described in elastic#202287 — namely a console warning due to invalid DOM property.
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Fixes one of the errors described in elastic#202287 — namely a console warning due to invalid DOM property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes one of the errors described in #202287 — namely a console warning due to invalid DOM property.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.Flaky Test Runner was used on any tests changedThe PR description includes the appropriate Release Notes section, and the correctrelease_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
See some risk examples