[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon#204286
Merged
clintandrewhall merged 9 commits intoelastic:mainfrom Jan 2, 2025
Merged
Conversation
clintandrewhall
added
review
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
clintandrewhall
removed
the
Team: SecuritySolution
clintandrewhall
requested review from
joeypoon,
parkiino and
vitaliidm
and removed request for
joeypoon,
parkiino and
vitaliidm
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
vitaliidm
reviewed
Dec 16, 2024
...security_solution/public/detection_engine/rule_creation_ui/components/ai_assistant/index.tsx
Outdated
Show resolved
Hide resolved
bhapas
approved these changes
Dec 17, 2024
Contributor
bhapas
left a comment
bhapas
left a comment
There was a problem hiding this comment.
LGTM Integration Assistant plugin
vitaliidm
approved these changes
Dec 17, 2024
Contributor
vitaliidm
left a comment
vitaliidm
left a comment
There was a problem hiding this comment.
Detection Engine area LGTM
...platform/packages/shared/kbn-elastic-assistant/impl/assistant/assistant_body/empty_convo.tsx
Outdated
Show resolved
Hide resolved
clintandrewhall
force-pushed
the
ai/assistant-logo-security
branch
from
08fdb43 to
c8296b0
Compare
clintandrewhall
force-pushed
the
ai/assistant-logo-security
branch
from
b9235cf to
16e0ccd
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
References to deprecated APIs
History
|
eokoneyo
approved these changes
Jan 2, 2025
Contributor
eokoneyo
left a comment
eokoneyo
left a comment
There was a problem hiding this comment.
Shared UX changes look good
clintandrewhall
added
v9.0.0
backport:version
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12585508134 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 2, 2025
…stant logo and beacon (elastic#204286) > A follow-up to elastic#203879 ## Summary This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc) Note: the scaling of the icon/avatar _before_ was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit de0dc52)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 2, 2025
…w Assistant logo and beacon (#204286) (#205409) # Backport This will backport the following commits from `main` to `8.x`: - [[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)](#204286) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Clint Andrew Hall","email":"clint.hall@elastic.co"},"sourceCommit":{"committedDate":"2025-01-02T16:27:17Z","message":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages owned by Security. In most cases this was a 1:1\r\nreplacement, but in a few, Icon was replaced with Beacon for\r\nconsistency, (e.g. welcome screens, upsells, etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one different from\r\nEUI. The new components match EUI directly and represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon","number":204286,"url":"https://github.com/elastic/kibana/pull/204286","mergeCommit":{"message":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages owned by Security. In most cases this was a 1:1\r\nreplacement, but in a few, Icon was replaced with Beacon for\r\nconsistency, (e.g. welcome screens, upsells, etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one different from\r\nEUI. The new components match EUI directly and represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204286","number":204286,"mergeCommit":{"message":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages owned by Security. In most cases this was a 1:1\r\nreplacement, but in a few, Icon was replaced with Beacon for\r\nconsistency, (e.g. welcome screens, upsells, etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one different from\r\nEUI. The new components match EUI directly and represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984"}}]}] BACKPORT--> --------- Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…stant logo and beacon (elastic#204286) > A follow-up to elastic#203879 ## Summary This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc) Note: the scaling of the icon/avatar _before_ was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc)
Note: the scaling of the icon/avatar before was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).