[8.x] kibana-management team module move (#203883) by mattkime · Pull Request #204274 · elastic/kibana

mattkime · 2024-12-13T19:04:40Z

Backport

This will backport the following commits from main to 8.x:

kibana-management team module move (#203883)

Questions ?

Please refer to the Backport tool documentation

## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 17 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/cloud-data-migration-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration` | | `@kbn/console-plugin` | `src/platform/plugins/shared/console` | | `@kbn/cross-cluster-replication-plugin` | `x-pack/platform/plugins/private/cross_cluster_replication` | | `@kbn/dev-tools-plugin` | `src/platform/plugins/shared/dev_tools` | | `@kbn/es-ui-shared-plugin` | `src/platform/plugins/shared/es_ui_shared` | | `@kbn/grokdebugger-plugin` | `x-pack/platform/plugins/private/grokdebugger` | | `@kbn/index-lifecycle-management-plugin` | `x-pack/platform/plugins/private/index_lifecycle_management` | | `@kbn/license-api-guard-plugin` | `x-pack/platform/plugins/private/license_api_guard` | | `@kbn/license-management-plugin` | `x-pack/platform/plugins/shared/license_management` | | `@kbn/management-plugin` | `src/platform/plugins/shared/management` | | `@kbn/painless-lab-plugin` | `x-pack/platform/plugins/private/painless_lab` | | `@kbn/remote-clusters-plugin` | `x-pack/platform/plugins/private/remote_clusters` | | `@kbn/rollup-plugin` | `x-pack/platform/plugins/private/rollup` | | `@kbn/runtime-fields-plugin` | `x-pack/platform/plugins/private/runtime_fields` | | `@kbn/searchprofiler-plugin` | `x-pack/platform/plugins/shared/searchprofiler` | | `@kbn/snapshot-restore-plugin` | `x-pack/platform/plugins/private/snapshot_restore` | | `@kbn/watcher-plugin` | `x-pack/platform/plugins/private/watcher` | #### 17 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/deeplinks-devtools` | `src/platform/packages/shared/deeplinks/devtools` | | `@kbn/deeplinks-management` | `src/platform/packages/shared/deeplinks/management` | | `@kbn/default-nav-devtools` | `src/platform/packages/private/default-nav/devtools` | | `@kbn/default-nav-management` | `src/platform/packages/private/default-nav/management` | | `@kbn/index-lifecycle-management-common-shared` | `x-pack/platform/packages/shared/index-lifecycle-management/index_lifecycle_management_common_shared` | | `@kbn/index-management-shared-types` | `x-pack/platform/packages/shared/index-management/index_management_shared_types` | | `@kbn/management-cards-navigation` | `src/platform/packages/shared/kbn-management/cards_navigation` | | `@kbn/management-settings-application` | `src/platform/packages/private/kbn-management/settings/application` | | `@kbn/management-settings-components-field-category` | `src/platform/packages/private/kbn-management/settings/components/field_category` | | `@kbn/management-settings-components-field-input` | `src/platform/packages/shared/kbn-management/settings/components/field_input` | | `@kbn/management-settings-components-field-row` | `src/platform/packages/shared/kbn-management/settings/components/field_row` | | `@kbn/management-settings-components-form` | `src/platform/packages/private/kbn-management/settings/components/form` | | `@kbn/management-settings-field-definition` | `src/platform/packages/shared/kbn-management/settings/field_definition` | | `@kbn/management-settings-types` | `src/platform/packages/shared/kbn-management/settings/types` | | `@kbn/management-settings-utilities` | `src/platform/packages/shared/kbn-management/settings/utilities` | | `@kbn/rollup` | `x-pack/platform/packages/private/rollup` | | `@kbn/unsaved-changes-prompt` | `src/platform/packages/shared/kbn-unsaved-changes-prompt` | <details > <summary>Updated references</summary> ``` ./.buildkite/scripts/steps/console_definitions_sync.sh ./.eslintrc.js ./.i18nrc.json ./docs/developer/contributing/development-tests.asciidoc ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-generate-console-definitions/README.md ./packages/kbn-repo-packages/package-map.json ./packages/kbn-search-connectors/components/cron_editor/readme.md ./packages/kbn-ts-projects/config-paths.json ./src/dev/precommit_hook/casing_check_config.js ./src/dev/storybook/aliases.ts ./src/platform/packages/private/default-nav/devtools/jest.config.js ./src/platform/packages/private/default-nav/management/jest.config.js ./src/platform/packages/private/kbn-management/settings/components/field_category/jest.config.js ./src/platform/packages/shared/deeplinks/devtools/jest.config.js ./src/platform/packages/shared/deeplinks/management/jest.config.js ./src/platform/packages/shared/kbn-management/cards_navigation/jest.config.js ./src/platform/packages/shared/kbn-unsaved-changes-prompt/jest.config.js ./src/platform/plugins/shared/console/README.md ./src/platform/plugins/shared/console/jest.config.js ./src/platform/plugins/shared/console/server/lib/elasticsearch_proxy_config.test.js ./src/platform/plugins/shared/console/server/lib/spec_definitions/json/README.md ./src/platform/plugins/shared/es_ui_shared/.storybook/manager.ts ./src/platform/plugins/shared/es_ui_shared/jest.config.js ./src/platform/plugins/shared/es_ui_shared/static/forms/README.md ./src/platform/plugins/shared/management/jest.config.js ./src/plugins/advanced_settings/README.md ./src/plugins/management/README.md ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/rollup/jest.config.js ./x-pack/platform/packages/shared/index-management/index_management_shared_types/jest.config.js ./x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration/jest.config.js ./x-pack/platform/plugins/private/cross_cluster_replication/jest.config.js ./x-pack/platform/plugins/private/grokdebugger/jest.config.js ./x-pack/platform/plugins/private/index_lifecycle_management/integration_tests/README.md ./x-pack/platform/plugins/private/index_lifecycle_management/jest.config.js ./x-pack/platform/plugins/private/index_lifecycle_management/jest.integration.config.js ./x-pack/platform/plugins/private/license_api_guard/jest.config.js ./x-pack/platform/plugins/private/painless_lab/jest.config.js ./x-pack/platform/plugins/private/remote_clusters/jest.config.js ./x-pack/platform/plugins/private/rollup/jest.config.js ./x-pack/platform/plugins/private/runtime_fields/jest.config.js ./x-pack/platform/plugins/private/snapshot_restore/jest.config.js ./x-pack/platform/plugins/private/watcher/jest.config.js ./x-pack/platform/plugins/shared/license_management/jest.config.js ./x-pack/platform/plugins/shared/searchprofiler/jest.config.js ./x-pack/plugins/index_management/README.md ./x-pack/plugins/triggers_actions_ui/README.md ./x-pack/plugins/triggers_actions_ui/server/data/routes/indices.ts ./x-pack/solutions/security/packages/navigation/src/constants.ts ./x-pack/test/functional/apps/dev_tools/searchprofiler_editor.ts ./yarn.lock ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/default-nav/devtools/jest.config.js:12 src/platform/packages/private/default-nav/devtools/tsconfig.json:2 src/platform/packages/private/default-nav/management/jest.config.js:12 src/platform/packages/private/default-nav/management/tsconfig.json:2 src/platform/packages/private/kbn-management/settings/application/tsconfig.json:2 src/platform/packages/private/kbn-management/settings/components/field_category/jest.config.js:12 src/platform/packages/private/kbn-management/settings/components/field_category/tsconfig.json:2 src/platform/packages/private/kbn-management/settings/components/form/tsconfig.json:2 src/platform/packages/shared/deeplinks/devtools/jest.config.js:12 src/platform/packages/shared/deeplinks/devtools/tsconfig.json:2 src/platform/packages/shared/deeplinks/management/jest.config.js:12 src/platform/packages/shared/deeplinks/management/tsconfig.json:2 src/platform/packages/shared/kbn-management/cards_navigation/jest.config.js:12 src/platform/packages/shared/kbn-management/cards_navigation/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/components/field_input/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/components/field_row/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/field_definition/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/types/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/utilities/tsconfig.json:2 src/platform/packages/shared/kbn-unsaved-changes-prompt/jest.config.js:12 src/platform/packages/shared/kbn-unsaved-changes-prompt/tsconfig.json:2 src/platform/plugins/shared/console/jest.config.js:12 src/platform/plugins/shared/console/tsconfig.json:2 src/platform/plugins/shared/dev_tools/tsconfig.json:2 src/platform/plugins/shared/es_ui_shared/jest.config.js:12 src/platform/plugins/shared/es_ui_shared/tsconfig.json:12 src/platform/plugins/shared/es_ui_shared/tsconfig.json:2 src/platform/plugins/shared/management/jest.config.js:12 src/platform/plugins/shared/management/tsconfig.json:10 src/platform/plugins/shared/management/tsconfig.json:2 x-pack/platform/packages/private/rollup/jest.config.js:10 x-pack/platform/packages/private/rollup/tsconfig.json:2 x-pack/platform/packages/shared/index-lifecycle-management/index_lifecycle_management_common_shared/tsconfig.json:2 x-pack/platform/packages/shared/index-management/index_management_shared_types/jest.config.js:10 x-pack/platform/packages/shared/index-management/index_management_shared_types/tsconfig.json:2 x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration/jest.config.js:10 x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration/tsconfig.json:10 x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration/tsconfig.json:2 x-pack/platform/plugins/private/cross_cluster_replication/jest.config.js:10 x-pack/platform/plugins/private/cross_cluster_replication/tsconfig.json:2 x-pack/platform/plugins/private/grokdebugger/jest.config.js:10 x-pack/platform/plugins/private/grokdebugger/tsconfig.json:10 x-pack/platform/plugins/private/grokdebugger/tsconfig.json:2 x-pack/platform/plugins/private/index_lifecycle_management/jest.config.js:10 x-pack/platform/plugins/private/index_lifecycle_management/jest.integration.config.js:10 x-pack/platform/plugins/private/index_lifecycle_management/tsconfig.json:12 x-pack/platform/plugins/private/index_lifecycle_management/tsconfig.json:2 x-pack/platform/plugins/private/license_api_guard/jest.config.js:10 x-pack/platform/plugins/private/license_api_guard/tsconfig.json:2 x-pack/platform/plugins/private/painless_lab/jest.config.js:10 x-pack/platform/plugins/private/painless_lab/public/styles/_index.scss:1 x-pack/platform/plugins/private/painless_lab/tsconfig.json:2 x-pack/platform/plugins/private/remote_clusters/jest.config.js:10 x-pack/platform/plugins/private/remote_clusters/tsconfig.json:12 x-pack/platform/plugins/private/remote_clusters/tsconfig.json:2 x-pack/platform/plugins/private/rollup/jest.config.js:10 x-pack/platform/plugins/private/rollup/tsconfig.json:2 x-pack/platform/plugins/private/runtime_fields/README.md:155 x-pack/platform/plugins/private/runtime_fields/jest.config.js:10 x-pack/platform/plugins/private/runtime_fields/tsconfig.json:2 x-pack/platform/plugins/private/runtime_fields/tsconfig.json:8 x-pack/platform/plugins/private/snapshot_restore/jest.config.js:10 x-pack/platform/plugins/private/snapshot_restore/tsconfig.json:12 x-pack/platform/plugins/private/snapshot_restore/tsconfig.json:2 x-pack/platform/plugins/private/watcher/jest.config.js:10 x-pack/platform/plugins/private/watcher/tsconfig.json:12 x-pack/platform/plugins/private/watcher/tsconfig.json:2 x-pack/platform/plugins/shared/license_management/jest.config.js:10 x-pack/platform/plugins/shared/license_management/tsconfig.json:2 x-pack/platform/plugins/shared/searchprofiler/jest.config.js:10 x-pack/platform/plugins/shared/searchprofiler/public/application/_app.scss:1 x-pack/platform/plugins/shared/searchprofiler/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2fd8994) # Conflicts: # .github/CODEOWNERS # package.json # tsconfig.base.json # x-pack/.i18nrc.json # yarn.lock

github-actions · 2024-12-13T19:04:57Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/dashboards --update --no-serverless'

…nto backport/8.x/pr-203883

mattkime · 2024-12-13T19:27:30Z

/ci

mattkime · 2024-12-13T20:38:10Z

/ci

mattkime · 2024-12-13T20:41:07Z

/ci

mattkime · 2024-12-13T21:41:32Z

/ci

elasticmachine · 2024-12-13T23:21:51Z

💛 Build succeeded, but was flaky

Failed CI Steps

Fleet Cypress Tests #1

Test Failures

[job] [logs] Fleet Cypress Tests #1 / View agents list Agent status filter should filter on healthy (16 result)
[job] [logs] Fleet Cypress Tests #1 / View agents list Agent status filter should filter on healthy and unhealthy
[job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`devTools`	1	0	-1
`snapshotRestore`	1	0	-1
total			-2

Total ESLint disabled count

id	before	after	diff
`devTools`	1	0	-1
`snapshotRestore`	4	3	-1
total			-2

History

cc @mattkime

mattkime requested a review from kibanamachine as a code owner December 13, 2024 19:04

mattkime added the backport This PR is a backport of another PR label Dec 13, 2024

mattkime enabled auto-merge (squash) December 13, 2024 19:04

mattkime mentioned this pull request Dec 13, 2024

kibana-management team module move #203883

Merged

mattkime self-assigned this Dec 13, 2024

kibanamachine and others added 5 commits December 13, 2024 19:18

update after bootstrap

f43a3d7

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

3446c2e

Merge branch 'backport/8.x/pr-203883' of github.com:mattkime/kibana i…

88fd54d

…nto backport/8.x/pr-203883

Merge branch 'backport/8.x/pr-203883' of github.com:mattkime/kibana i…

eee8a03

…nto backport/8.x/pr-203883

fix i18n

94d6cc8

Merge branch '8.x' into backport/8.x/pr-203883

08259d7

Merge branch '8.x' into backport/8.x/pr-203883

9fccb4b

PhilippeOberti approved these changes Dec 13, 2024

View reviewed changes

mattkime merged commit e6c9e20 into elastic:8.x Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.x] kibana-management team module move (#203883)#204274

[8.x] kibana-management team module move (#203883)#204274
mattkime merged 9 commits intoelastic:8.xfrom
mattkime:backport/8.x/pr-203883

mattkime commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

elasticmachine commented Dec 13, 2024

ESLint disabled in files

Total ESLint disabled count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mattkime commented Dec 13, 2024

Backport

Questions ?

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

mattkime commented Dec 13, 2024

Uh oh!

elasticmachine commented Dec 13, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

ESLint disabled in files

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants