[Observability plugin] Audit new EUI Borealis theme by fkanout · Pull Request #204234 · elastic/kibana

fkanout · 2024-12-13T15:06:15Z

Summary

It fixes #203338

Note

Some of the tokens have been ignored as they were on the server side or common folder, or they are coming from a shared package like packages/react/kibana_context

elasticmachine · 2024-12-16T13:43:59Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

fkanout · 2024-12-16T13:45:19Z

/oblt-deploy

kdelemme

A few questions but otherwise token changes LGTM.

x-pack/plugins/observability_solution/apm/common/viz_colors.ts

...k/plugins/observability_solution/profiling/public/components/topn_functions/function_row.tsx

...ervability_solution/infra/public/components/asset_details/tabs/processes/processes_table.tsx

...ins/synthetics/public/apps/synthetics/components/common/monitor_test_result/status_badge.tsx

elasticmachine · 2024-12-16T14:46:56Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

github-actions · 2024-12-16T14:47:05Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

mgadewoll

@fkanout We need to add the label backport:skip and remove backport:prev-minor.
Borealis changes should not be backported to 8.x versions.

mgadewoll · 2024-12-17T11:21:07Z

x-pack/plugins/observability_solution/apm/common/service_health_status.ts

  switch (status) {
    case ServiceHealthStatus.healthy:
-      return theme.eui.euiColorVis0;
+      return theme.colors.vis.euiColorVis0;


Fyi, vis colors changed. So especially for severity colors like this it means using the same mapping will change colors in Amsterdam. This might need alignment with a designer (not sure which is responsible here?), if that's expected or not.

See this related conversation about this topic.

@mgadewoll, thanks for the heads up! @maciejforcone is our designer, but I don't think we can get his feedback soon enough for the PR due to the holiday period.

However, I chose the 1st option in the related conversation you mentioned. a.k.a using euiColorVisSuccess0, euiColorVisWarning0, and euiColorVisDanger0

@jasonrhodes please let me know if you think we need to do otherwise.

Fyi, we're introducing new severity colors that should cover those cases across Kibana.
We can update to severity colors as follow-up.

x-pack/plugins/observability_solution/apm/public/components/shared/charts/timeseries_chart.tsx

elasticmachine · 2024-12-17T13:33:27Z

💔 Build Failed

Buildkite Build
Commit: aac8ef4
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204234-aac8ef418b16

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #80 / Cloud Security Posture Findings Page onboarding Vulnerabilities - clicking on the No integrations installed prompt action button - install CNVM: navigates to the CNVM integration installation page
[job] [logs] Jest Tests #16 / EmptyBanner with one node does not render null
[job] [logs] Jest Tests #16 / EmptyBanner with one node does not render null
[job] [logs] Jest Tests #16 / Timeline TimelineAxisContainer should render with data
[job] [logs] Jest Tests #16 / Timeline TimelineAxisContainer should render with data
[job] [logs] Jest Tests #16 / Timeline VerticalLinesContainer should render with data
[job] [logs] Jest Tests #16 / Timeline VerticalLinesContainer should render with data
[job] [logs] Jest Tests #16 / useCytoscapeEventHandlers when data is received runs the layout
[job] [logs] Jest Tests #16 / useCytoscapeEventHandlers when data is received runs the layout
[job] [logs] Jest Tests #16 / useCytoscapeEventHandlers when data is received with a service name sets the primary class
[job] [logs] Jest Tests #16 / useCytoscapeEventHandlers when data is received with a service name sets the primary class

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1922	1929	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.3MB	3.4MB	+9.6KB
`infra`	1.7MB	1.7MB	-78.0B
`synthetics`	1.1MB	1.1MB	+18.0B
total			+9.6KB

History

💔 Build #261305 failed d7be7b1
💔 Build #260838 failed cd97121

cc @fkanout

fkanout · 2024-12-17T16:56:02Z

@kdelemme @mgadewoll This PR seems to overlap with other ones scope-wise. I discussed this with @jasonrhodes, and we agreed to scope this PR to update only the files that are owned by our team.
Sorry about letting you double-review this work. But the new PR is significantly smaller. I appreciate your help!

patpascal · 2024-12-18T12:00:08Z

Hi @fkanout! To make our design review as helpful as possible, could you share from a final user's perspective where they might notice the changes (in case it impacts the user)?

fkanout · 2024-12-18T12:13:37Z

closing this in favor of #204615

fkanout and others added 3 commits December 13, 2024 16:05

First two required items

148ad06

Merge branch 'main' into 203338-update-eui-borealis-theme

9ce1584

Merge branch 'main' into 203338-update-eui-borealis-theme

cd97121

fkanout self-assigned this Dec 16, 2024

fkanout added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Dec 16, 2024

fkanout requested review from kkurstak and patpascal December 16, 2024 13:00

fkanout marked this pull request as ready for review December 16, 2024 13:43

fkanout requested a review from a team as a code owner December 16, 2024 13:43

fkanout requested a review from a team December 16, 2024 13:43

fkanout requested a review from a team as a code owner December 16, 2024 13:43

fkanout added v9.0.0 backport:prev-minor release_note:skip Skip the PR/issue when compiling release notes labels Dec 16, 2024

kdelemme reviewed Dec 16, 2024

View reviewed changes

botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Dec 16, 2024

fkanout and others added 5 commits December 17, 2024 11:05

Merge remote-tracking branch 'upstream/main'

31d9e42

Merge branch 'main' into 203338-update-eui-borealis-theme

2d388c7

Merge branch 'main' into 203338-update-eui-borealis-theme

6426aff

Fix withEuiTheme

67030c4

textParagraph

d7be7b1

mgadewoll reviewed Dec 17, 2024

View reviewed changes

fkanout added backport:skip This PR does not require backporting and removed backport:prev-minor labels Dec 17, 2024

Fix theme after merge with main

b3f2993

codereview

aac8ef4

fkanout closed this Dec 18, 2024

Comments

Conversation

fkanout commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Note

Uh oh!

elasticmachine commented Dec 16, 2024

Uh oh!

fkanout commented Dec 16, 2024

Uh oh!

kdelemme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Dec 16, 2024

Uh oh!

github-actions bot commented Dec 16, 2024

🤖 GitHub comments

Uh oh!

mgadewoll left a comment

Choose a reason for hiding this comment

Uh oh!

mgadewoll Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

fkanout Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

mgadewoll Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

fkanout commented Dec 17, 2024

Uh oh!

patpascal commented Dec 18, 2024

Uh oh!

fkanout commented Dec 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fkanout commented Dec 13, 2024 •

edited

Loading

elasticmachine commented Dec 17, 2024 •

edited

Loading