Skip to content

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting-investigations (#202855) #204150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippeOberti merged 1 commit into from
Dec 13, 2024
Merged

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting-investigations (#202855) #204150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 4 additions & 4 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^x-pack\/plugins\/security_solution_ess/,
/^x-pack\/plugins\/security_solution_serverless/,
/^x-pack\/plugins\/task_manager/,
/^x-pack\/plugins\/timelines/,
/^x-pack\/solutions\/security\/plugins\/timelines/,
/^x-pack\/plugins\/triggers_actions_ui\/public\/application\/sections\/action_connector_form/,
/^x-pack\/plugins\/triggers_actions_ui\/public\/application\/context\/actions_connectors_context\.tsx/,
/^x-pack\/plugins\/triggers_actions_ui\/server\/connector_types\/openai/,
Expand Down Expand Up @@ -290,7 +290,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^packages\/kbn-es-query/,
/^packages\/kbn-i18n/,
/^packages\/kbn-i18n-react/,
/^packages\/kbn-expandable-flyout/,
/^x-pack\/solutions\/security\/packages\/expandable-flyout/,
/^packages\/kbn-grouping/,
/^packages\/kbn-resizable-layout/,
/^packages\/kbn-rison/,
Expand Down Expand Up @@ -334,8 +334,8 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^x-pack\/plugins\/security_solution_ess/,
/^x-pack\/plugins\/security_solution_serverless/,
/^x-pack\/plugins\/task_manager/,
/^x-pack\/plugins\/threat_intelligence/,
/^x-pack\/plugins\/timelines/,
/^x-pack\/solutions\/security\/plugins\/threat_intelligence/,
/^x-pack\/solutions\/security\/plugins\/timelines/,
/^x-pack\/plugins\/triggers_actions_ui/,
/^x-pack\/plugins\/usage_collection\/public/,
/^x-pack\/test\/functional\/es_archives\/security_solution/,
Expand Down
12 changes: 6 additions & 6 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,8 +1109,8 @@ module.exports = {
'x-pack/plugins/security_solution/common/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/security_solution_ess/common/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/security_solution_serverless/common/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/timelines/public/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/timelines/common/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/security/plugins/timelines/public/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/security/plugins/timelines/common/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/cases/public/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/cases/common/**/*.{js,mjs,ts,tsx}',
'packages/kbn-cell-actions/**/*.{js,mjs,ts,tsx}',
Expand Down Expand Up @@ -1144,7 +1144,7 @@ module.exports = {
'x-pack/plugins/security_solution/**/*.{ts,tsx}',
'x-pack/plugins/security_solution_ess/**/*.{ts,tsx}',
'x-pack/plugins/security_solution_serverless/**/*.{ts,tsx}',
'x-pack/plugins/timelines/**/*.{ts,tsx}',
'x-pack/solutions/security/plugins/timelines/**/*.{ts,tsx}',
'x-pack/plugins/cases/**/*.{ts,tsx}',
'packages/kbn-cell-actions/**/*.{js,mjs,ts,tsx}',
],
Expand All @@ -1159,7 +1159,7 @@ module.exports = {
'x-pack/plugins/security_solution/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/plugins/security_solution_ess/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/plugins/security_solution_serverless/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/plugins/timelines/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/solutions/security/plugins/timelines/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/plugins/cases/**/*.{test,mock,test_helper}.{ts,tsx}',
'packages/kbn-cell-actions/**/*.{test,mock,test_helper}.{ts,tsx}',
],
Expand All @@ -1180,7 +1180,7 @@ module.exports = {
'x-pack/plugins/security_solution/**/*.{ts,tsx}',
'x-pack/plugins/security_solution_ess/**/*.{ts,tsx}',
'x-pack/plugins/security_solution_serverless/**/*.{ts,tsx}',
'x-pack/plugins/timelines/**/*.{ts,tsx}',
'x-pack/solutions/security/plugins/timelines/**/*.{ts,tsx}',
'x-pack/plugins/cases/**/*.{ts,tsx}',
'packages/kbn-cell-actions/**/*.{ts,tsx}',
],
Expand Down Expand Up @@ -1214,7 +1214,7 @@ module.exports = {
'x-pack/plugins/security_solution/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/security_solution_ess/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/security_solution_serverless/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/timelines/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/security/plugins/timelines/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/cases/**/*.{js,mjs,ts,tsx}',
'packages/kbn-data-stream-adapter/**/*.{js,mjs,ts,tsx}',
'packages/kbn-cell-actions/**/*.{js,mjs,ts,tsx}',
Expand Down
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ src/plugins/event_annotation_listing @elastic/kibana-visualizations
src/plugins/event_annotation @elastic/kibana-visualizations
x-pack/test/plugin_api_integration/plugins/event_log @elastic/response-ops
x-pack/plugins/event_log @elastic/response-ops
packages/kbn-expandable-flyout @elastic/security-threat-hunting-investigations
x-pack/solutions/security/packages/expandable-flyout @elastic/security-threat-hunting-investigations
packages/kbn-expect @elastic/kibana-operations @elastic/appex-qa
x-pack/examples/exploratory_view_example @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/exploratory_view @elastic/obs-ux-management-team
Expand Down Expand Up @@ -960,8 +960,8 @@ x-pack/performance @elastic/appex-qa
x-pack/examples/testing_embedded_lens @elastic/kibana-visualizations
x-pack/examples/third_party_lens_navigation_prompt @elastic/kibana-visualizations
x-pack/examples/third_party_vis_lens_example @elastic/kibana-visualizations
x-pack/plugins/threat_intelligence @elastic/security-threat-hunting-investigations
x-pack/plugins/timelines @elastic/security-threat-hunting-investigations
x-pack/solutions/security/plugins/threat_intelligence @elastic/security-threat-hunting-investigations
x-pack/solutions/security/plugins/timelines @elastic/security-threat-hunting-investigations
packages/kbn-timelion-grammar @elastic/kibana-visualizations
packages/kbn-timerange @elastic/obs-ux-logs-team
packages/kbn-tinymath @elastic/kibana-visualizations
Expand Down
2 changes: 1 addition & 1 deletion .github/codeql/codeql-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ paths-ignore:
- x-pack/plugins/osquery/scripts
- x-pack/plugins/rule_registry/scripts
- x-pack/plugins/security_solution/scripts
- x-pack/plugins/threat_intelligence/scripts
- x-pack/solutions/security/plugins/threat_intelligence/scripts
- x-pack/scripts
- x-pack/test
1 change: 0 additions & 1 deletion .i18nrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
"esQuery": "packages/kbn-es-query/src",
"kbnGridLayout": "packages/kbn-grid-layout",
"esUi": "src/plugins/es_ui_shared",
"expandableFlyout": "packages/kbn-expandable-flyout",
"expressionError": "src/plugins/expression_error",
"expressionGauge": "src/plugins/chart_expressions/expression_gauge",
"expressionHeatmap": "src/plugins/chart_expressions/expression_heatmap",
Expand Down
4 changes: 2 additions & 2 deletions docs/developer/plugin-list.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,11 +938,11 @@ in their infrastructure.
|Gathers all usage collection, retrieving them from both: OSS and X-Pack plugins.


|{kib-repo}blob/{branch}/x-pack/plugins/threat_intelligence/README.md[threatIntelligence]
|{kib-repo}blob/{branch}/x-pack/solutions/security/plugins/threat_intelligence/README.md[threatIntelligence]
|Elastic Threat Intelligence makes it easy to analyze and investigate potential security threats by aggregating data from multiple sources in one place. You’ll be able to view data from all activated threat intelligence feeds and take action.


|{kib-repo}blob/{branch}/x-pack/plugins/timelines/README.md[timelines]
|{kib-repo}blob/{branch}/x-pack/solutions/security/plugins/timelines/README.md[timelines]
|Timelines is a plugin that provides a grid component with accompanying server side apis to help users identify events of interest and perform root cause analysis within Kibana.


Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@
"@kbn/event-annotation-plugin": "link:src/plugins/event_annotation",
"@kbn/event-log-fixture-plugin": "link:x-pack/test/plugin_api_integration/plugins/event_log",
"@kbn/event-log-plugin": "link:x-pack/plugins/event_log",
"@kbn/expandable-flyout": "link:packages/kbn-expandable-flyout",
"@kbn/expandable-flyout": "link:x-pack/solutions/security/packages/expandable-flyout",
"@kbn/exploratory-view-example-plugin": "link:x-pack/examples/exploratory_view_example",
"@kbn/exploratory-view-plugin": "link:x-pack/plugins/observability_solution/exploratory_view",
"@kbn/expression-error-plugin": "link:src/plugins/expression_error",
Expand Down Expand Up @@ -957,8 +957,8 @@
"@kbn/testing-embedded-lens-plugin": "link:x-pack/examples/testing_embedded_lens",
"@kbn/third-party-lens-navigation-prompt-plugin": "link:x-pack/examples/third_party_lens_navigation_prompt",
"@kbn/third-party-vis-lens-example-plugin": "link:x-pack/examples/third_party_vis_lens_example",
"@kbn/threat-intelligence-plugin": "link:x-pack/plugins/threat_intelligence",
"@kbn/timelines-plugin": "link:x-pack/plugins/timelines",
"@kbn/threat-intelligence-plugin": "link:x-pack/solutions/security/plugins/threat_intelligence",
"@kbn/timelines-plugin": "link:x-pack/solutions/security/plugins/timelines",
"@kbn/timelion-grammar": "link:packages/kbn-timelion-grammar",
"@kbn/timerange": "link:packages/kbn-timerange",
"@kbn/tinymath": "link:packages/kbn-tinymath",
Expand Down
2 changes: 1 addition & 1 deletion packages/deeplinks/security/deep_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export enum SecurityPageName {
siemMigrationsRules = 'siem_migrations-rules',
/*
* Warning: Computed values are not permitted in an enum with string valued members
* All threat intelligence page names must match `TIPageId` in x-pack/plugins/threat_intelligence/public/common/navigation/types.ts
* All threat intelligence page names must match `TIPageId` in x-pack/solutions/security/plugins/threat_intelligence/public/common/navigation/types.ts
*/
threatIntelligence = 'threat_intelligence',
timelines = 'timelines',
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-babel-preset/styled_components_files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = {
/packages[\/\\]kbn-ui-shared-deps-(npm|src)[\/\\]/,
/src[\/\\]plugins[\/\\](kibana_react)[\/\\]/,
/x-pack[\/\\]plugins[\/\\](observability_solution\/apm|beats_management|fleet|observability_solution\/infra|lists|observability_solution\/observability|observability_solution\/observability_shared|observability_solution\/exploratory_view|security_solution|timelines|observability_solution\/synthetics|observability_solution\/ux|observability_solution\/uptime)[\/\\]/,
/x-pack[\/\\]solutions[\/\\]security[\/\\]plugins[\/\\](observability_solution\/apm|beats_management|fleet|observability_solution\/infra|lists|observability_solution\/observability|observability_solution\/observability_shared|observability_solution\/exploratory_view|security_solution|timelines|observability_solution\/synthetics|observability_solution\/ux|observability_solution\/uptime)[\/\\]/,
/x-pack[\/\\]test[\/\\]plugin_functional[\/\\]plugins[\/\\]resolver_test[\/\\]/,
/x-pack[\/\\]packages[\/\\]elastic_assistant[\/\\]/,
/x-pack[\/\\]solutions[\/\\]security[\/\\]packages[\/\\]ecs_data_quality_dashboard[\/\\]/,
Expand Down
10 changes: 0 additions & 10 deletions packages/kbn-expandable-flyout/.storybook/main.js
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions packages/kbn-expandable-flyout/jest.config.js
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions packages/kbn-expandable-flyout/src/components/translations.ts
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/dev/storybook/aliases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const storybookAliases = {
discover: 'src/plugins/discover/.storybook',
esql_ast_inspector: 'examples/esql_ast_inspector/.storybook',
es_ui_shared: 'src/plugins/es_ui_shared/.storybook',
expandable_flyout: 'packages/kbn-expandable-flyout/.storybook',
expandable_flyout: 'x-pack/solutions/security/packages/kbn-expandable-flyout/.storybook',
expression_error: 'src/plugins/expression_error/.storybook',
expression_image: 'src/plugins/expression_image/.storybook',
expression_metric_vis: 'src/plugins/chart_expressions/expression_legacy_metric/.storybook',
Expand Down Expand Up @@ -66,7 +66,7 @@ export const storybookAliases = {
serverless: 'packages/serverless/storybook/config',
shared_ux: 'packages/shared-ux/storybook/config',
slo: 'x-pack/plugins/observability_solution/slo/.storybook',
threat_intelligence: 'x-pack/plugins/threat_intelligence/.storybook',
threat_intelligence: 'x-pack/solutions/security/plugins/threat_intelligence/.storybook',
triggers_actions_ui: 'x-pack/plugins/triggers_actions_ui/.storybook',
ui_actions_enhanced: 'src/plugins/ui_actions_enhanced/.storybook',
unified_search: 'src/plugins/unified_search/.storybook',
Expand Down
12 changes: 6 additions & 6 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,8 +890,8 @@
"@kbn/event-log-fixture-plugin/*": ["x-pack/test/plugin_api_integration/plugins/event_log/*"],
"@kbn/event-log-plugin": ["x-pack/plugins/event_log"],
"@kbn/event-log-plugin/*": ["x-pack/plugins/event_log/*"],
"@kbn/expandable-flyout": ["packages/kbn-expandable-flyout"],
"@kbn/expandable-flyout/*": ["packages/kbn-expandable-flyout/*"],
"@kbn/expandable-flyout": ["x-pack/solutions/security/packages/expandable-flyout"],
"@kbn/expandable-flyout/*": ["x-pack/solutions/security/packages/expandable-flyout/*"],
"@kbn/expect": ["packages/kbn-expect"],
"@kbn/expect/*": ["packages/kbn-expect/*"],
"@kbn/exploratory-view-example-plugin": ["x-pack/examples/exploratory_view_example"],
Expand Down Expand Up @@ -1914,10 +1914,10 @@
"@kbn/third-party-lens-navigation-prompt-plugin/*": ["x-pack/examples/third_party_lens_navigation_prompt/*"],
"@kbn/third-party-vis-lens-example-plugin": ["x-pack/examples/third_party_vis_lens_example"],
"@kbn/third-party-vis-lens-example-plugin/*": ["x-pack/examples/third_party_vis_lens_example/*"],
"@kbn/threat-intelligence-plugin": ["x-pack/plugins/threat_intelligence"],
"@kbn/threat-intelligence-plugin/*": ["x-pack/plugins/threat_intelligence/*"],
"@kbn/timelines-plugin": ["x-pack/plugins/timelines"],
"@kbn/timelines-plugin/*": ["x-pack/plugins/timelines/*"],
"@kbn/threat-intelligence-plugin": ["x-pack/solutions/security/plugins/threat_intelligence"],
"@kbn/threat-intelligence-plugin/*": ["x-pack/solutions/security/plugins/threat_intelligence/*"],
"@kbn/timelines-plugin": ["x-pack/solutions/security/plugins/timelines"],
"@kbn/timelines-plugin/*": ["x-pack/solutions/security/plugins/timelines/*"],
"@kbn/timelion-grammar": ["packages/kbn-timelion-grammar"],
"@kbn/timelion-grammar/*": ["packages/kbn-timelion-grammar/*"],
"@kbn/timerange": ["packages/kbn-timerange"],
Expand Down
4 changes: 2 additions & 2 deletions x-pack/.i18nrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@
"plugins/saved_objects_tagging"
],
"xpack.taskManager": "legacy/plugins/task_manager",
"xpack.threatIntelligence": "plugins/threat_intelligence",
"xpack.timelines": "plugins/timelines",
"xpack.threatIntelligence": "solutions/security/plugins/threat_intelligence",
"xpack.timelines": "solutions/security/plugins/timelines",
"xpack.transform": "platform/plugins/private/transform",
"xpack.triggersActionsUI": "plugins/triggers_actions_ui",
"xpack.upgradeAssistant": "plugins/upgrade_assistant",
Expand Down
11 changes: 0 additions & 11 deletions x-pack/platform/plugins/private/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3183,17 +3183,6 @@
"exceptionList-components.wildcardWithWrongOperatorCallout.changeTheOperator": "Changer d'opérateur",
"exceptionList-components.wildcardWithWrongOperatorCallout.matches": "correspond à",
"exceptionList-components.wildcardWithWrongOperatorCallout.title": "Veuillez examiner vos entrées",
"expandableFlyout.previewSection.backButton": "Retour",
"expandableFlyout.previewSection.closeButton": "Fermer",
"expandableFlyout.renderMenu.flyoutResizeButton": "Réinitialiser la taille",
"expandableFlyout.renderMenu.flyoutResizeTitle": "Taille du menu volant",
"expandableFlyout.settingsMenu.flyoutTypeTitle": "Type de menu volant",
"expandableFlyout.settingsMenu.overlayMode": "Superposer",
"expandableFlyout.settingsMenu.overlayTooltip": "Affiche le menu volant sur la page",
"expandableFlyout.settingsMenu.popoverButton": "Paramètres du menu volant",
"expandableFlyout.settingsMenu.popoverTitle": "Paramètres du menu volant",
"expandableFlyout.settingsMenu.pushMode": "Déploiement",
"expandableFlyout.settingsMenu.pushTooltip": "Affiche le menu volant à côté de la page",
"expressionError.errorComponent.description": "Échec de l'expression avec le message :",
"expressionError.errorComponent.title": "Oups ! Échec de l'expression",
"expressionError.renderer.debug.displayName": "Déboguer",
Expand Down
11 changes: 0 additions & 11 deletions x-pack/platform/plugins/private/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3176,17 +3176,6 @@
"exceptionList-components.wildcardWithWrongOperatorCallout.changeTheOperator": "演算子を変更",
"exceptionList-components.wildcardWithWrongOperatorCallout.matches": "一致",
"exceptionList-components.wildcardWithWrongOperatorCallout.title": "エントリを確認してください",
"expandableFlyout.previewSection.backButton": "戻る",
"expandableFlyout.previewSection.closeButton": "閉じる",
"expandableFlyout.renderMenu.flyoutResizeButton": "サイズをリセット",
"expandableFlyout.renderMenu.flyoutResizeTitle": "フライアウトサイズ",
"expandableFlyout.settingsMenu.flyoutTypeTitle": "フライアウトタイプ",
"expandableFlyout.settingsMenu.overlayMode": "オーバーレイ",
"expandableFlyout.settingsMenu.overlayTooltip": "ページ上にフライアウトを表示します",
"expandableFlyout.settingsMenu.popoverButton": "フライアウト設定",
"expandableFlyout.settingsMenu.popoverTitle": "フライアウト設定",
"expandableFlyout.settingsMenu.pushMode": "プッシュ",
"expandableFlyout.settingsMenu.pushTooltip": "ページの横にフライアウトを表示します",
"expressionError.errorComponent.description": "表現が失敗し次のメッセージが返されました：",
"expressionError.errorComponent.title": "おっと！表現が失敗しました",
"expressionError.renderer.debug.displayName": "デバッグ",
Expand Down
Loading