[Rules migration] Add comments tab in the details flyout (#11385)#204084
Merged
e40pud merged 3 commits intoelastic:mainfrom Dec 13, 2024
Merged
[Rules migration] Add comments tab in the details flyout (#11385)#204084e40pud merged 3 commits intoelastic:mainfrom
e40pud merged 3 commits intoelastic:mainfrom
Conversation
e40pud
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
cc @e40pud |
semd
reviewed
Dec 13, 2024
..._solution/public/siem_migrations/rules/components/rule_details_flyout/tabs/summary/index.tsx
Outdated
Show resolved
Hide resolved
semd
approved these changes
Dec 13, 2024
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12324372250 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 13, 2024
…) (elastic#204084) ## Summary [Internal link](elastic/security-team#10820) to the feature details These changes add a "Summary" tab within the migration rule details flyout which will show the AI assistant comments about the translation process of the rule. ## Screenshot <img width="1675" alt="Screenshot 2024-12-12 at 17 39 30" src="https://github.com/user-attachments/assets/213c3e80-70df-482a-8dfd-09fc1e2e54c8" /> (cherry picked from commit bee7f0f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 14, 2024
… (#204084) (#204291) # Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration] Add comments tab in the details flyout (#11385) (#204084)](#204084) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2024-12-13T23:06:35Z","message":"[Rules migration] Add comments tab in the details flyout (#11385) (#204084)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a \"Summary\" tab within the migration rule details\r\nflyout which will show the AI assistant comments about the translation\r\nprocess of the rule.\r\n\r\n## Screenshot\r\n\r\n<img width=\"1675\" alt=\"Screenshot 2024-12-12 at 17 39 30\"\r\nsrc=\"https://github.com/user-attachments/assets/213c3e80-70df-482a-8dfd-09fc1e2e54c8\"\r\n/>","sha":"bee7f0f90e49a34f716e273f33a398873d7d5c5a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules migration] Add comments tab in the details flyout (#11385)","number":204084,"url":"https://github.com/elastic/kibana/pull/204084","mergeCommit":{"message":"[Rules migration] Add comments tab in the details flyout (#11385) (#204084)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a \"Summary\" tab within the migration rule details\r\nflyout which will show the AI assistant comments about the translation\r\nprocess of the rule.\r\n\r\n## Screenshot\r\n\r\n<img width=\"1675\" alt=\"Screenshot 2024-12-12 at 17 39 30\"\r\nsrc=\"https://github.com/user-attachments/assets/213c3e80-70df-482a-8dfd-09fc1e2e54c8\"\r\n/>","sha":"bee7f0f90e49a34f716e273f33a398873d7d5c5a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204084","number":204084,"mergeCommit":{"message":"[Rules migration] Add comments tab in the details flyout (#11385) (#204084)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a \"Summary\" tab within the migration rule details\r\nflyout which will show the AI assistant comments about the translation\r\nprocess of the rule.\r\n\r\n## Screenshot\r\n\r\n<img width=\"1675\" alt=\"Screenshot 2024-12-12 at 17 39 30\"\r\nsrc=\"https://github.com/user-attachments/assets/213c3e80-70df-482a-8dfd-09fc1e2e54c8\"\r\n/>","sha":"bee7f0f90e49a34f716e273f33a398873d7d5c5a"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal link to the feature details
These changes add a "Summary" tab within the migration rule details flyout which will show the AI assistant comments about the translation process of the rule.
Screenshot