Make task_cost_check test resilient to changes in order#204045
Merged
gsoldevila merged 1 commit intoelastic:mainfrom Dec 12, 2024
Merged
Make task_cost_check test resilient to changes in order#204045gsoldevila merged 1 commit intoelastic:mainfrom
task_cost_check test resilient to changes in order#204045gsoldevila merged 1 commit intoelastic:mainfrom
Conversation
gsoldevila
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12300990470 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Dec 16, 2024
…4045) ## Summary Addresses failures such as https://buildkite.com/elastic/kibana-pull-request/builds/259739#0193bb07-c759-4749-965e-10e63ac0810a. We believe the order in which task types are registered might have been affected by the relocation of the `@kbn/observability-ai-assistant-app-plugin` in the scope of _Sustainable Kibana Architecture_. (cherry picked from commit a4e4a60) # Conflicts: # x-pack/plugins/task_manager/server/integration_tests/__snapshots__/task_cost_check.test.ts.snap
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
that referenced
this pull request
Dec 16, 2024
) (#204344) # Backport This will backport the following commits from `main` to `8.x`: - [Make `task_cost_check` test resilient to changes in order (#204045)](#204045) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-12T16:50:03Z","message":"Make `task_cost_check` test resilient to changes in order (#204045)\n\n## Summary\r\n\r\nAddresses failures such as\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/259739#0193bb07-c759-4749-965e-10e63ac0810a.\r\n\r\nWe believe the order in which task types are registered might have been\r\naffected by the relocation of the\r\n`@kbn/observability-ai-assistant-app-plugin` in the scope of\r\n_Sustainable Kibana Architecture_.","sha":"a4e4a6061bdd6d75ae82dd005c507b2e4ed5f230","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport missing","v9.0.0","backport:prev-minor"],"number":204045,"url":"https://github.com/elastic/kibana/pull/204045","mergeCommit":{"message":"Make `task_cost_check` test resilient to changes in order (#204045)\n\n## Summary\r\n\r\nAddresses failures such as\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/259739#0193bb07-c759-4749-965e-10e63ac0810a.\r\n\r\nWe believe the order in which task types are registered might have been\r\naffected by the relocation of the\r\n`@kbn/observability-ai-assistant-app-plugin` in the scope of\r\n_Sustainable Kibana Architecture_.","sha":"a4e4a6061bdd6d75ae82dd005c507b2e4ed5f230"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204045","number":204045,"mergeCommit":{"message":"Make `task_cost_check` test resilient to changes in order (#204045)\n\n## Summary\r\n\r\nAddresses failures such as\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/259739#0193bb07-c759-4749-965e-10e63ac0810a.\r\n\r\nWe believe the order in which task types are registered might have been\r\naffected by the relocation of the\r\n`@kbn/observability-ai-assistant-app-plugin` in the scope of\r\n_Sustainable Kibana Architecture_.","sha":"a4e4a6061bdd6d75ae82dd005c507b2e4ed5f230"}}]}] BACKPORT-->
kibanamachine
added
v8.18.0
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses failures such as https://buildkite.com/elastic/kibana-pull-request/builds/259739#0193bb07-c759-4749-965e-10e63ac0810a.
We believe the order in which task types are registered might have been affected by the relocation of the
@kbn/observability-ai-assistant-app-pluginin the scope of Sustainable Kibana Architecture.