Merged
Conversation
…risk severity updated to use RISK_SEVERITY_COLOUR instead of SEVERITY_COLOUR
CAWilson94
commented
Dec 12, 2024
| low_impact: '#54B399', | ||
| unassigned: euiLightVars.euiColorMediumShade, | ||
| }; | ||
| import { useCriticalityLevelColors } from '../../hooks/use_criticality_level_colors'; |
Contributor
Author
There was a problem hiding this comment.
Moved this to a hook in the hooks folder. Noticed some hooks in asset_criticality aren’t in hooks; both locations make sense, but this follows a better convention.
CAWilson94
commented
Dec 12, 2024
| import { RiskSeverity } from '../../../../../common/search_strategy'; | ||
| import { RiskScoreLevel } from '.'; | ||
| import { SEVERITY_COLOR } from '../../../../overview/components/detection_response/utils'; | ||
| import { RISK_SEVERITY_COLOUR } from '../../../common/utils'; |
Contributor
Author
There was a problem hiding this comment.
Updated RISK_SEVERITY_COLOUR to match updates previously made to index from SEVERITY --> RISK_SEVERITY
CAWilson94
commented
Dec 12, 2024
| </RiskBadge> | ||
| )); | ||
| }> = React.memo(({ severity, hideBackgroundColor = false, 'data-test-subj': dataTestSubj }) => { | ||
| const { euiTheme } = useEuiTheme(); |
Contributor
Author
There was a problem hiding this comment.
This is the change
CAWilson94
commented
Dec 12, 2024
| const { euiTheme } = useEuiTheme(); | ||
| return ( | ||
| <RiskBadge | ||
| color={euiTheme.colors.danger} |
Contributor
Author
There was a problem hiding this comment.
along with this change, the others I think just formatter
…n in place, to change references WiP
…uiTheme hook for colors
… - WiP consider moving back to static mapping if eui can allow
CAWilson94
added
ci:project-deploy-security
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Contributor
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
CAWilson94
added
the
release_note:feature
…rdam theme - Borealis old colors
…everity colour palette is agreed
angorayc
added a commit
that referenced
this pull request
Jan 25, 2025
## Summary Apply severity colors for Borealis theme. #204007 (comment) Update:⚠️ As the final decision for severity color is still pending, the temporary colors are the hard coded color hex: #203387 `TODO` Borealis migration - move from hardcoded values to severity palette elastic/security-team#11606 | Color token | Amsterdam|Borealis| |-------------|------------|------------| | Critical | euiThemeVars.euiColorDanger |```#E7664C```| | High | euiThemeVars.euiColorVis9_behindText |```#DA8B45``` | | Meduiml |euiThemeVars.euiColorVis5_behindText|```#D6BF57``` | | Low | euiThemeVars.euiColorVis0| ```#54B399``` | ### Running Kibana with the Borealis theme In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
machadoum
approved these changes
Jan 27, 2025
Member
machadoum
left a comment
machadoum
left a comment
There was a problem hiding this comment.
The code looks good to me.
I agree with what you said in the video about the severity filter. It is hard to read.
Do you have any update from the design team on that?
CAWilson94
dismissed
mgadewoll’s stale review
Agreed to iterate severity colors for security with designers and eui, so reverted these changes. Reviewer also on PTO so cannot change status.
Contributor
Author
Hello! Yes! Thanks for asking, @codearos gave me a better background color to use, which is updated in the google doc now :) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @CAWilson94 |
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Jan 27, 2025
…#206276) ## Summary Apply severity colors for Borealis theme. elastic#204007 (comment) Update:⚠️ As the final decision for severity color is still pending, the temporary colors are the hard coded color hex: elastic#203387 `TODO` Borealis migration - move from hardcoded values to severity palette elastic/security-team#11606 | Color token | Amsterdam|Borealis| |-------------|------------|------------| | Critical | euiThemeVars.euiColorDanger |```#E7664C```| | High | euiThemeVars.euiColorVis9_behindText |```#DA8B45``` | | Meduiml |euiThemeVars.euiColorVis5_behindText|```#D6BF57``` | | Low | euiThemeVars.euiColorVis0| ```#54B399``` | ### Running Kibana with the Borealis theme In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Jan 27, 2025
## Summary This PR covers required updates for EUI refresh: [elastic#11228](elastic/security-team#11228) The updates should only cover Entity Owned components. ### Severity Colors Blocked Severity colors are on hold until the security severity color palette is finalised. Once agreed, a shared hook will be updated across all of security, replacing the current RISK_SEVERITY_COLOUR mapping. The previous severity colors hook was reverted in preparation for this change. Updates for EA will be tracked accordingly. See https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for more details elastic/security-team#11516 elastic#206276 --- ### Testing Running Kibana with the Borealis theme In order to run Kibana with Borealis, you'll need to do the following: 1. Set the following in kibana.dev.yml: u`iSettings.experimental.themeSwitcherEnabled: true` 2. Run Kibana with the following environment variable set: `KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start` 3. This will expose a toggle under **Stack Management > Advanced Settings > Theme version**, which you can use to toggle between Amsterdam and Borealis. --- More details about each section elastic#199715 #### Borealis Updates Light & Dark Theme ### Screenshots Google Docs for easy read - same screenshots below https://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing --- ## Light Theme ### Entity Store   ### Risk Score  ### Dashboard and Flyout     ## Dark Theme ### Entity Store   ### Risk Score  ### Dashboard and Flyout     --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kapral18
pushed a commit
to kapral18/kibana
that referenced
this pull request
Feb 12, 2025
## Summary This PR covers required updates for EUI refresh: [elastic#11228](elastic/security-team#11228) The updates should only cover Entity Owned components. ### Severity Colors Blocked Severity colors are on hold until the security severity color palette is finalised. Once agreed, a shared hook will be updated across all of security, replacing the current RISK_SEVERITY_COLOUR mapping. The previous severity colors hook was reverted in preparation for this change. Updates for EA will be tracked accordingly. See https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for more details elastic/security-team#11516 elastic#206276 --- ### Testing Running Kibana with the Borealis theme In order to run Kibana with Borealis, you'll need to do the following: 1. Set the following in kibana.dev.yml: u`iSettings.experimental.themeSwitcherEnabled: true` 2. Run Kibana with the following environment variable set: `KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start` 3. This will expose a toggle under **Stack Management > Advanced Settings > Theme version**, which you can use to toggle between Amsterdam and Borealis. --- More details about each section elastic#199715 #### Borealis Updates Light & Dark Theme ### Screenshots Google Docs for easy read - same screenshots below https://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing --- ## Light Theme ### Entity Store   ### Risk Score  ### Dashboard and Flyout     ## Dark Theme ### Entity Store   ### Risk Score  ### Dashboard and Flyout     --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co> (cherry picked from commit 4ecf32b) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/risk_information/index.tsx
kapral18
added a commit
that referenced
this pull request
Feb 12, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [Eui Refresh (#204007)](#204007) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Charlotte Alexandra Wilson","email":"CAWilson94@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-27T11:43:30Z","message":"Eui Refresh (#204007)\n\n## Summary\r\n\r\nThis PR covers required updates for EUI refresh:\r\n[#11228](https://github.com/elastic/security-team/issues/11228)\r\nThe updates should only cover Entity Owned components. \r\n\r\n### Severity Colors Blocked\r\nSeverity colors are on hold until the security severity color palette is\r\nfinalised. Once agreed, a shared hook will be updated across all of\r\nsecurity, replacing the current RISK_SEVERITY_COLOUR mapping. The\r\nprevious severity colors hook was reverted in preparation for this\r\nchange. Updates for EA will be tracked accordingly.\r\n\r\nSee https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for\r\nmore details\r\n\r\nhttps://github.com/elastic/security-team/issues/11516 \r\nhttps://github.com//pull/206276\r\n\r\n---\r\n\r\n### Testing \r\n\r\nRunning Kibana with the Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to do the following:\r\n\r\n1. Set the following in kibana.dev.yml:\r\nu`iSettings.experimental.themeSwitcherEnabled: true`\r\n\r\n2. Run Kibana with the following environment variable set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\" yarn\r\nstart`\r\n\r\n3. This will expose a toggle under **Stack Management > Advanced\r\nSettings > Theme version**, which you can use to toggle\r\nbetween Amsterdam and Borealis.\r\n\r\n---\r\n\r\nMore details about each section\r\nhttps://github.com//issues/199715\r\n\r\n#### Borealis Updates Light & Dark Theme \r\n\r\n### Screenshots \r\nGoogle Docs for easy read - same screenshots below\r\n\r\nhttps://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing\r\n\r\n---\r\n## Light Theme\r\n\r\n### Entity Store \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Dark Theme\r\n\r\n### Entity Store\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Mark Hopkin <mark.hopkin@elastic.co>","sha":"4ecf32b83df2b03f0ad1eae90afede21fc21c9d4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport:skip","v9.0.0","release_note:feature","Team:Cloud Security","ci:project-deploy-security","Team:Entity Analytics","EUI Visual Refresh"],"title":"Eui Refresh ","number":204007,"url":"https://github.com/elastic/kibana/pull/204007","mergeCommit":{"message":"Eui Refresh (#204007)\n\n## Summary\r\n\r\nThis PR covers required updates for EUI refresh:\r\n[#11228](https://github.com/elastic/security-team/issues/11228)\r\nThe updates should only cover Entity Owned components. \r\n\r\n### Severity Colors Blocked\r\nSeverity colors are on hold until the security severity color palette is\r\nfinalised. Once agreed, a shared hook will be updated across all of\r\nsecurity, replacing the current RISK_SEVERITY_COLOUR mapping. The\r\nprevious severity colors hook was reverted in preparation for this\r\nchange. Updates for EA will be tracked accordingly.\r\n\r\nSee https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for\r\nmore details\r\n\r\nhttps://github.com/elastic/security-team/issues/11516 \r\nhttps://github.com//pull/206276\r\n\r\n---\r\n\r\n### Testing \r\n\r\nRunning Kibana with the Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to do the following:\r\n\r\n1. Set the following in kibana.dev.yml:\r\nu`iSettings.experimental.themeSwitcherEnabled: true`\r\n\r\n2. Run Kibana with the following environment variable set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\" yarn\r\nstart`\r\n\r\n3. This will expose a toggle under **Stack Management > Advanced\r\nSettings > Theme version**, which you can use to toggle\r\nbetween Amsterdam and Borealis.\r\n\r\n---\r\n\r\nMore details about each section\r\nhttps://github.com//issues/199715\r\n\r\n#### Borealis Updates Light & Dark Theme \r\n\r\n### Screenshots \r\nGoogle Docs for easy read - same screenshots below\r\n\r\nhttps://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing\r\n\r\n---\r\n## Light Theme\r\n\r\n### Entity Store \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Dark Theme\r\n\r\n### Entity Store\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Mark Hopkin <mark.hopkin@elastic.co>","sha":"4ecf32b83df2b03f0ad1eae90afede21fc21c9d4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204007","number":204007,"mergeCommit":{"message":"Eui Refresh (#204007)\n\n## Summary\r\n\r\nThis PR covers required updates for EUI refresh:\r\n[#11228](https://github.com/elastic/security-team/issues/11228)\r\nThe updates should only cover Entity Owned components. \r\n\r\n### Severity Colors Blocked\r\nSeverity colors are on hold until the security severity color palette is\r\nfinalised. Once agreed, a shared hook will be updated across all of\r\nsecurity, replacing the current RISK_SEVERITY_COLOUR mapping. The\r\nprevious severity colors hook was reverted in preparation for this\r\nchange. Updates for EA will be tracked accordingly.\r\n\r\nSee https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for\r\nmore details\r\n\r\nhttps://github.com/elastic/security-team/issues/11516 \r\nhttps://github.com//pull/206276\r\n\r\n---\r\n\r\n### Testing \r\n\r\nRunning Kibana with the Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to do the following:\r\n\r\n1. Set the following in kibana.dev.yml:\r\nu`iSettings.experimental.themeSwitcherEnabled: true`\r\n\r\n2. Run Kibana with the following environment variable set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\" yarn\r\nstart`\r\n\r\n3. This will expose a toggle under **Stack Management > Advanced\r\nSettings > Theme version**, which you can use to toggle\r\nbetween Amsterdam and Borealis.\r\n\r\n---\r\n\r\nMore details about each section\r\nhttps://github.com//issues/199715\r\n\r\n#### Borealis Updates Light & Dark Theme \r\n\r\n### Screenshots \r\nGoogle Docs for easy read - same screenshots below\r\n\r\nhttps://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing\r\n\r\n---\r\n## Light Theme\r\n\r\n### Entity Store \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Dark Theme\r\n\r\n### Entity Store\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Mark Hopkin <mark.hopkin@elastic.co>","sha":"4ecf32b83df2b03f0ad1eae90afede21fc21c9d4"}}]}] BACKPORT--> Co-authored-by: Charlotte Alexandra Wilson <CAWilson94@users.noreply.github.com>
kapral18
added a commit
that referenced
this pull request
Feb 12, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [Eui Refresh (#204007)](#204007) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Charlotte Alexandra Wilson","email":"CAWilson94@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-27T11:43:30Z","message":"Eui Refresh (#204007)\n\n## Summary\r\n\r\nThis PR covers required updates for EUI refresh:\r\n[#11228](https://github.com/elastic/security-team/issues/11228)\r\nThe updates should only cover Entity Owned components. \r\n\r\n### Severity Colors Blocked\r\nSeverity colors are on hold until the security severity color palette is\r\nfinalised. Once agreed, a shared hook will be updated across all of\r\nsecurity, replacing the current RISK_SEVERITY_COLOUR mapping. The\r\nprevious severity colors hook was reverted in preparation for this\r\nchange. Updates for EA will be tracked accordingly.\r\n\r\nSee https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for\r\nmore details\r\n\r\nhttps://github.com/elastic/security-team/issues/11516 \r\nhttps://github.com//pull/206276\r\n\r\n---\r\n\r\n### Testing \r\n\r\nRunning Kibana with the Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to do the following:\r\n\r\n1. Set the following in kibana.dev.yml:\r\nu`iSettings.experimental.themeSwitcherEnabled: true`\r\n\r\n2. Run Kibana with the following environment variable set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\" yarn\r\nstart`\r\n\r\n3. This will expose a toggle under **Stack Management > Advanced\r\nSettings > Theme version**, which you can use to toggle\r\nbetween Amsterdam and Borealis.\r\n\r\n---\r\n\r\nMore details about each section\r\nhttps://github.com//issues/199715\r\n\r\n#### Borealis Updates Light & Dark Theme \r\n\r\n### Screenshots \r\nGoogle Docs for easy read - same screenshots below\r\n\r\nhttps://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing\r\n\r\n---\r\n## Light Theme\r\n\r\n### Entity Store \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Dark Theme\r\n\r\n### Entity Store\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Mark Hopkin <mark.hopkin@elastic.co>","sha":"4ecf32b83df2b03f0ad1eae90afede21fc21c9d4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport:skip","v9.0.0","release_note:feature","Team:Cloud Security","ci:project-deploy-security","Team:Entity Analytics","EUI Visual Refresh"],"title":"Eui Refresh ","number":204007,"url":"https://github.com/elastic/kibana/pull/204007","mergeCommit":{"message":"Eui Refresh (#204007)\n\n## Summary\r\n\r\nThis PR covers required updates for EUI refresh:\r\n[#11228](https://github.com/elastic/security-team/issues/11228)\r\nThe updates should only cover Entity Owned components. \r\n\r\n### Severity Colors Blocked\r\nSeverity colors are on hold until the security severity color palette is\r\nfinalised. Once agreed, a shared hook will be updated across all of\r\nsecurity, replacing the current RISK_SEVERITY_COLOUR mapping. The\r\nprevious severity colors hook was reverted in preparation for this\r\nchange. Updates for EA will be tracked accordingly.\r\n\r\nSee https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for\r\nmore details\r\n\r\nhttps://github.com/elastic/security-team/issues/11516 \r\nhttps://github.com//pull/206276\r\n\r\n---\r\n\r\n### Testing \r\n\r\nRunning Kibana with the Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to do the following:\r\n\r\n1. Set the following in kibana.dev.yml:\r\nu`iSettings.experimental.themeSwitcherEnabled: true`\r\n\r\n2. Run Kibana with the following environment variable set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\" yarn\r\nstart`\r\n\r\n3. This will expose a toggle under **Stack Management > Advanced\r\nSettings > Theme version**, which you can use to toggle\r\nbetween Amsterdam and Borealis.\r\n\r\n---\r\n\r\nMore details about each section\r\nhttps://github.com//issues/199715\r\n\r\n#### Borealis Updates Light & Dark Theme \r\n\r\n### Screenshots \r\nGoogle Docs for easy read - same screenshots below\r\n\r\nhttps://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing\r\n\r\n---\r\n## Light Theme\r\n\r\n### Entity Store \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Dark Theme\r\n\r\n### Entity Store\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Mark Hopkin <mark.hopkin@elastic.co>","sha":"4ecf32b83df2b03f0ad1eae90afede21fc21c9d4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204007","number":204007,"mergeCommit":{"message":"Eui Refresh (#204007)\n\n## Summary\r\n\r\nThis PR covers required updates for EUI refresh:\r\n[#11228](https://github.com/elastic/security-team/issues/11228)\r\nThe updates should only cover Entity Owned components. \r\n\r\n### Severity Colors Blocked\r\nSeverity colors are on hold until the security severity color palette is\r\nfinalised. Once agreed, a shared hook will be updated across all of\r\nsecurity, replacing the current RISK_SEVERITY_COLOUR mapping. The\r\nprevious severity colors hook was reverted in preparation for this\r\nchange. Updates for EA will be tracked accordingly.\r\n\r\nSee https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for\r\nmore details\r\n\r\nhttps://github.com/elastic/security-team/issues/11516 \r\nhttps://github.com//pull/206276\r\n\r\n---\r\n\r\n### Testing \r\n\r\nRunning Kibana with the Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to do the following:\r\n\r\n1. Set the following in kibana.dev.yml:\r\nu`iSettings.experimental.themeSwitcherEnabled: true`\r\n\r\n2. Run Kibana with the following environment variable set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\" yarn\r\nstart`\r\n\r\n3. This will expose a toggle under **Stack Management > Advanced\r\nSettings > Theme version**, which you can use to toggle\r\nbetween Amsterdam and Borealis.\r\n\r\n---\r\n\r\nMore details about each section\r\nhttps://github.com//issues/199715\r\n\r\n#### Borealis Updates Light & Dark Theme \r\n\r\n### Screenshots \r\nGoogle Docs for easy read - same screenshots below\r\n\r\nhttps://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing\r\n\r\n---\r\n## Light Theme\r\n\r\n### Entity Store \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Dark Theme\r\n\r\n### Entity Store\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Risk Score\r\n\r\n\r\n\r\n\r\n### Dashboard and Flyout\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Mark Hopkin <mark.hopkin@elastic.co>","sha":"4ecf32b83df2b03f0ad1eae90afede21fc21c9d4"}},{"url":"https://github.com/elastic/kibana/pull/210908","number":210908,"branch":"8.x","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Charlotte Alexandra Wilson <CAWilson94@users.noreply.github.com>
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 13, 2025
…#206276) Apply severity colors for Borealis theme. elastic#204007 (comment) Update:⚠️ As the final decision for severity color is still pending, the temporary colors are the hard coded color hex: elastic#203387 `TODO` Borealis migration - move from hardcoded values to severity palette elastic/security-team#11606 | Color token | Amsterdam|Borealis| |-------------|------------|------------| | Critical | euiThemeVars.euiColorDanger |```#E7664C```| | High | euiThemeVars.euiColorVis9_behindText |```#DA8B45``` | | Meduiml |euiThemeVars.euiColorVis5_behindText|```#D6BF57``` | | Low | euiThemeVars.euiColorVis0| ```#54B399``` | In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 235d5eb)
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 13, 2025
…#206276) Apply severity colors for Borealis theme. elastic#204007 (comment) Update:⚠️ As the final decision for severity color is still pending, the temporary colors are the hard coded color hex: elastic#203387 `TODO` Borealis migration - move from hardcoded values to severity palette elastic/security-team#11606 | Color token | Amsterdam|Borealis| |-------------|------------|------------| | Critical | euiThemeVars.euiColorDanger |```#E7664C```| | High | euiThemeVars.euiColorVis9_behindText |```#DA8B45``` | | Meduiml |euiThemeVars.euiColorVis5_behindText|```#D6BF57``` | | Low | euiThemeVars.euiColorVis0| ```#54B399``` | In order to run Kibana with Borealis, you'll need to do the following: Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true Run Kibana with the following environment variable set: KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.  - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 235d5eb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR covers required updates for EUI refresh: #11228
The updates should only cover Entity Owned components.
Severity Colors Blocked
Severity colors are on hold until the security severity color palette is finalised. Once agreed, a shared hook will be updated across all of security, replacing the current RISK_SEVERITY_COLOUR mapping. The previous severity colors hook was reverted in preparation for this change. Updates for EA will be tracked accordingly.
See https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for more details
https://github.com/elastic/security-team/issues/11516
#206276
Testing
Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:
Set the following in kibana.dev.yml: u
iSettings.experimental.themeSwitcherEnabled: trueRun Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn startThis will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle
between Amsterdam and Borealis.
More details about each section #199715
Borealis Updates Light & Dark Theme
Screenshots
Google Docs for easy read - same screenshots below
https://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing
Light Theme
Entity Store
Risk Score
Dashboard and Flyout
Dark Theme
Entity Store
Risk Score
Dashboard and Flyout