-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Observability AI Assistant] Add alert status management to AI Assistant connector #203729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arturoliduena
merged 18 commits into
elastic:main
from
arturoliduena:185032-o11y-AI-Assistant-action-trigger-on-alert-status-change
Feb 10, 2025
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3c7025b
Add alert status management to AI Assistant connector
arturoliduena 7b4ecc2
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 2f615f6
fix types error
arturoliduena 0bae13a
test fix: Add status field to connector types and update tests
arturoliduena c584c0c
add multiple prompts to ai-assistant action
arturoliduena 50bd854
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine fc546a8
update prompt validation
arturoliduena 2fb4fc3
update tests
arturoliduena 04618aa
remove ALERT_STATUS_ALL from Status type definition
arturoliduena a6a894a
Merge branch 'main' into 185032-o11y-AI-Assistant-action-trigger-on-a…
neptunian 7472824
enhance prompt validation to support multiple prompts and improve err…
arturoliduena e1428a6
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine 2fca1a8
refactor validation logic in AI assistan connector
arturoliduena 7ef1784
add tests
arturoliduena 447c8b0
forward-compatible fallback.
arturoliduena a4bfe6d
removing redundant constants
arturoliduena c06d00a
use lodash's isEmpty for status validation check
arturoliduena a53991d
Merge branch 'main' into 185032-o11y-AI-Assistant-action-trigger-on-a…
arturoliduena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmuellr I’ve added forward-compatible fallback to handle the scenario when a new version of the connector runs in a new Kibana and the actions are later picked up by an old Kibana, it will degrade gracefully. we fall back to using just the first prompt and applying it across all statuses, ensuring older Kibana versions can still process the actions without breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the code, there's a new param
prompts. Which is not in the "previous" version of the schema. So if a new Kibana creates an action with thepromptsparam, and an older Kibana runs the action, it will fail validation since it doesn't expect thepromptsparam. Or is this handled in some other way?For this reason, our "intermediate release" doc suggests doing one release with just the schema change, but do not set the property values. That way, in the final release when the property IS set, the previous version of Kibana will at least pass the validation for the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, @pmuellr! I’ve just opened a PR to introduce the intermediate release, as suggested in the documentation. This includes the schema change along with the necessary updates to the action executor to handle both the old and new schemas.
Here’s the PR: #209221
Let me know if you have any feedback!