Skip to content

[Observability] Update required field from 'score' to 'scores'#203584

Merged
arturoliduena merged 1 commit intoelastic:mainfrom
arturoliduena:fix-Error-Toolcall-arguments-for-score
Dec 17, 2024
Merged

[Observability] Update required field from 'score' to 'scores'#203584
arturoliduena merged 1 commit intoelastic:mainfrom
arturoliduena:fix-Error-Toolcall-arguments-for-score

Conversation

@arturoliduena
Copy link
Copy Markdown
Contributor

@arturoliduena arturoliduena commented Dec 10, 2024

Closes #203739

Summary

fix error: “Error scoring documents: Tool call arguments for score were invalid”

[Observability] Update required field from 'score' to 'scores' in scoreSuggestions schema

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@arturoliduena arturoliduena added release_note:fix Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v8.18.0 labels Dec 10, 2024
@arturoliduena arturoliduena requested a review from a team as a code owner December 10, 2024 13:50
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 10, 2024
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, having an API test to cover this would be great!

@arturoliduena
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@arturoliduena arturoliduena force-pushed the fix-Error-Toolcall-arguments-for-score branch from 82ea9e8 to 98fd8b7 Compare December 17, 2024 14:14
@elasticmachine
Copy link
Copy Markdown
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 98fd8b7
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203584-98fd8b787938

History

  • 💚 Build #258743 succeeded 82ea9e8d5b0783b9734dbe59131482c6cd6c59e0

@arturoliduena arturoliduena merged commit 1b52848 into elastic:main Dec 17, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12377322854

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 17, 2024
…ic#203584)

Closes elastic#203739

## Summary

fix error: `“Error scoring documents: Tool call arguments for score were
invalid”`

[Observability] Update required field from 'score' to 'scores' in
scoreSuggestions schema

(cherry picked from commit 1b52848)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stephmilovic pushed a commit that referenced this pull request Dec 17, 2024
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
…ic#203584)

Closes elastic#203739

## Summary

fix error: `“Error scoring documents: Tool call arguments for score were
invalid”`

[Observability] Update required field from 'score' to 'scores' in
scoreSuggestions schema
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
…ic#203584)

Closes elastic#203739

## Summary

fix error: `“Error scoring documents: Tool call arguments for score were
invalid”`

[Observability] Update required field from 'score' to 'scores' in
scoreSuggestions schema
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…ic#203584)

Closes elastic#203739

## Summary

fix error: `“Error scoring documents: Tool call arguments for score were
invalid”`

[Observability] Update required field from 'score' to 'scores' in
scoreSuggestions schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:fix Team:Obs AI Assistant Observability AI Assistant v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Error scoring documents: Tool call arguments for score were invalid

4 participants