[Infra] Fix call to service api#203451
Merged
crespocarlos merged 2 commits intoelastic:mainfrom Dec 10, 2024
Merged
Conversation
crespocarlos
added
backport:prev-minor
Team:obs-ux-infra_services - DEPRECATED
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
approved these changes
Dec 9, 2024
Member
jennypavlova
left a comment
jennypavlova
left a comment
There was a problem hiding this comment.
The code LGTM, just some nits/questions ⬇️
...gins/observability_solution/infra/public/components/asset_details/tabs/overview/services.tsx
Show resolved
Hide resolved
| filters: { [HOST_NAME_FIELD]: hostName }, | ||
| from: dateRange.from, | ||
| to: dateRange.to, | ||
| from: parsedDateRange.from, |
Member
There was a problem hiding this comment.
Nit: As we use both from and to we can simply use ...parsedDateRange here, wdyt?
botelastic
bot
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12257218461 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
fixes [203389](elastic#203389) ## Summary Fix the call to `/api/infra/services` when using a relative date range  ### How to test - Navigate to host detail view, and change the data picker to use relative dates - Click on Submit (cherry picked from commit 1a20fda)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
fixes [203389](elastic#203389) ## Summary Fix the call to `/api/infra/services` when using a relative date range  ### How to test - Navigate to host detail view, and change the data picker to use relative dates - Click on Submit (cherry picked from commit 1a20fda)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Infra] Fix call to service api (#203451)](#203451) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-10T13:33:32Z","message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.17.0","v8.16.2"],"title":"[Infra] Fix call to service api","number":203451,"url":"https://github.com/elastic/kibana/pull/203451","mergeCommit":{"message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203451","number":203451,"mergeCommit":{"message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[Infra] Fix call to service api (#203451)](#203451) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-10T13:33:32Z","message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.17.0","v8.16.2"],"title":"[Infra] Fix call to service api","number":203451,"url":"https://github.com/elastic/kibana/pull/203451","mergeCommit":{"message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203451","number":203451,"mergeCommit":{"message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
This was referenced Dec 10, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
fixes [203389](elastic#203389) ## Summary Fix the call to `/api/infra/services` when using a relative date range  ### How to test - Navigate to host detail view, and change the data picker to use relative dates - Click on Submit
crespocarlos
added a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 3, 2025
fixes [203389](elastic#203389) ## Summary Fix the call to `/api/infra/services` when using a relative date range  ### How to test - Navigate to host detail view, and change the data picker to use relative dates - Click on Submit (cherry picked from commit 1a20fda) # Conflicts: # x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/hooks/use_unified_search.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
crespocarlos
added a commit
that referenced
this pull request
Jan 3, 2025
# Backport This will backport the following commits from `main` to `8.16`: - [[Infra] Fix call to service api (#203451)](#203451) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-10T13:33:32Z","message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.17.0","v8.18.0","v8.16.2"],"number":203451,"url":"https://github.com/elastic/kibana/pull/203451","mergeCommit":{"message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203451","number":203451,"mergeCommit":{"message":"[Infra] Fix call to service api (#203451)\n\nfixes [203389](https://github.com/elastic/kibana/issues/203389)\r\n## Summary\r\n\r\nFix the call to `/api/infra/services` when using a relative date range\r\n\r\n\r\n\r\n\r\n\r\n### How to test\r\n- Navigate to host detail view, and change the data picker to use\r\nrelative dates\r\n- Click on Submit","sha":"1a20fda7021fa49d054c19d4757592dda385f5de"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203576","number":203576,"state":"MERGED","mergeCommit":{"sha":"0f232c352d3baecab8e4d4610f53b7a0b62a52b4","message":"[8.17] [Infra] Fix call to service api (#203451) (#203576)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.17`:\n- [[Infra] Fix call to service api\n(#203451)](https://github.com/elastic/kibana/pull/203451)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Carlos\nCrespo\",\"email\":\"crespocarlos@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-12-10T13:33:32Z\",\"message\":\"[Infra]\nFix call to service api (#203451)\\n\\nfixes\n[203389](https://github.com/elastic/kibana/issues/203389)\\r\\n##\nSummary\\r\\n\\r\\nFix the call to `/api/infra/services` when using a\nrelative date\nrange\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nHow to test\\r\\n- Navigate to host detail view, and change the data\npicker to use\\r\\nrelative dates\\r\\n- Click on\nSubmit\",\"sha\":\"1a20fda7021fa49d054c19d4757592dda385f5de\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"backport:version\",\"v8.17.0\",\"v8.16.2\"],\"title\":\"[Infra]\nFix call to service\napi\",\"number\":203451,\"url\":\"https://github.com/elastic/kibana/pull/203451\",\"mergeCommit\":{\"message\":\"[Infra]\nFix call to service api (#203451)\\n\\nfixes\n[203389](https://github.com/elastic/kibana/issues/203389)\\r\\n##\nSummary\\r\\n\\r\\nFix the call to `/api/infra/services` when using a\nrelative date\nrange\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nHow to test\\r\\n- Navigate to host detail view, and change the data\npicker to use\\r\\nrelative dates\\r\\n- Click on\nSubmit\",\"sha\":\"1a20fda7021fa49d054c19d4757592dda385f5de\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.17\",\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203451\",\"number\":203451,\"mergeCommit\":{\"message\":\"[Infra]\nFix call to service api (#203451)\\n\\nfixes\n[203389](https://github.com/elastic/kibana/issues/203389)\\r\\n##\nSummary\\r\\n\\r\\nFix the call to `/api/infra/services` when using a\nrelative date\nrange\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nHow to test\\r\\n- Navigate to host detail view, and change the data\npicker to use\\r\\nrelative dates\\r\\n- Click on\nSubmit\",\"sha\":\"1a20fda7021fa49d054c19d4757592dda385f5de\"}},{\"branch\":\"8.17\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.16\",\"label\":\"v8.16.2\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203577","number":203577,"state":"MERGED","mergeCommit":{"sha":"ec0cab5bf2e609745233c9e3c27eb7a1d4374d27","message":"[8.x] [Infra] Fix call to service api (#203451) (#203577)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Infra] Fix call to service api\n(#203451)](https://github.com/elastic/kibana/pull/203451)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Carlos\nCrespo\",\"email\":\"crespocarlos@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-12-10T13:33:32Z\",\"message\":\"[Infra]\nFix call to service api (#203451)\\n\\nfixes\n[203389](https://github.com/elastic/kibana/issues/203389)\\r\\n##\nSummary\\r\\n\\r\\nFix the call to `/api/infra/services` when using a\nrelative date\nrange\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nHow to test\\r\\n- Navigate to host detail view, and change the data\npicker to use\\r\\nrelative dates\\r\\n- Click on\nSubmit\",\"sha\":\"1a20fda7021fa49d054c19d4757592dda385f5de\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"backport:version\",\"v8.17.0\",\"v8.16.2\"],\"title\":\"[Infra]\nFix call to service\napi\",\"number\":203451,\"url\":\"https://github.com/elastic/kibana/pull/203451\",\"mergeCommit\":{\"message\":\"[Infra]\nFix call to service api (#203451)\\n\\nfixes\n[203389](https://github.com/elastic/kibana/issues/203389)\\r\\n##\nSummary\\r\\n\\r\\nFix the call to `/api/infra/services` when using a\nrelative date\nrange\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nHow to test\\r\\n- Navigate to host detail view, and change the data\npicker to use\\r\\nrelative dates\\r\\n- Click on\nSubmit\",\"sha\":\"1a20fda7021fa49d054c19d4757592dda385f5de\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.17\",\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203451\",\"number\":203451,\"mergeCommit\":{\"message\":\"[Infra]\nFix call to service api (#203451)\\n\\nfixes\n[203389](https://github.com/elastic/kibana/issues/203389)\\r\\n##\nSummary\\r\\n\\r\\nFix the call to `/api/infra/services` when using a\nrelative date\nrange\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nHow to test\\r\\n- Navigate to host detail view, and change the data\npicker to use\\r\\nrelative dates\\r\\n- Click on\nSubmit\",\"sha\":\"1a20fda7021fa49d054c19d4757592dda385f5de\"}},{\"branch\":\"8.17\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.16\",\"label\":\"v8.16.2\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>"}},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes 203389
Summary
Fix the call to
/api/infra/serviceswhen using a relative date rangeHow to test