[ResponseOps][UI] EUI Visual Refresh integration and QA - replaced deprecated color variables#203120
Merged
georgianaonoleata1904 merged 7 commits intoelastic:ro_eui_theme_borealisfrom Dec 16, 2024
Conversation
georgianaonoleata1904
added
backport:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
georgianaonoleata1904
changed the title
georgianaonoleata1904
changed the base branch from
main
to
ro_eui_theme_borealis
mgadewoll
reviewed
Dec 16, 2024
| // Replicate euiPanel--accent vs euiPanel--subdued | ||
| // Applying these classNames by themselves doesn't work due to a CSS-in-JS issue with EuiPanel | ||
| color: isActive ? '#a8376a' : euiTheme.colors.subduedText, | ||
| color: isActive ? '#a8376a' : euiTheme.colors.textSubdued, |
Contributor
There was a problem hiding this comment.
We should be able to use a token for the static colors as well, I think?
#a8376a could become euiTheme.colors.textAccent which is #A11262 (light) and #EE72A6 (dark).
Contributor
Author
There was a problem hiding this comment.
i ll update it, thanks!
| buttonContentClassName="eui-fullWidth" | ||
| buttonContent={ | ||
| <EuiPanel color="subdued" paddingSize="m"> | ||
| <EuiPanel color={subdued} paddingSize="m"> |
Contributor
There was a problem hiding this comment.
Question: Why do we need to override the default subdued panel here? 🤔
Contributor
Author
There was a problem hiding this comment.
this is still WIP, i ll update it
Contributor
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202550
Summary
previous color token -> new color token
primaryText -> textPrimary
accentText -> textAccent
between this and textSuccess.
warningText -> textWarning
dangerText -> textDanger
text -> textParagraph
title -> textHeading
subduedText -> textSubdued
disabledText -> textDisabled
successText -> textSuccess