Skip to content

Run functional test dev server from snapshot by default#20312

Merged
rhoboat merged 1 commit intoelastic:masterfrom
rhoboat:functionaltestdevserver
Jun 29, 2018
Merged

Run functional test dev server from snapshot by default#20312
rhoboat merged 1 commit intoelastic:masterfrom
rhoboat:functionaltestdevserver

Conversation

@rhoboat
Copy link

@rhoboat rhoboat commented Jun 28, 2018

locally, running yarn test:ui:server should start Elasticsearch from snapshot, not source.

@rhoboat rhoboat requested a review from LeeDr June 28, 2018 17:54
@elasticmachine
Copy link
Contributor

💔 Build Failed

@rhoboat
Copy link
Author

rhoboat commented Jun 29, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thomasneirynck thomasneirynck added the Team:Operations Kibana-Operations Team label Jun 29, 2018
@rhoboat rhoboat requested a review from thomasneirynck June 29, 2018 16:10
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epixa
Copy link
Contributor

epixa commented Jun 29, 2018

What impact does this have on CI?

@rhoboat
Copy link
Author

rhoboat commented Jun 29, 2018

@epixa No impact on CI. It's just for running the yarn test:ui:server which is also going away soon.

@rhoboat rhoboat merged commit 757e7d2 into elastic:master Jun 29, 2018
@rhoboat rhoboat deleted the functionaltestdevserver branch June 29, 2018 18:36
@epixa
Copy link
Contributor

epixa commented Jun 30, 2018

@archanid Please backport this as well.

@rhoboat
Copy link
Author

rhoboat commented Jul 1, 2018

6.x: #20309
6.3: #20310
^ these are backports for the original #18967 PR, which is because those backports took a little longer to merge up, waiting for CI to pass and needed some branch-specific tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported Team:Operations Kibana-Operations Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants